All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vince Weaver <vincent.weaver@maine.edu>
To: Eric Anholt <eric@anholt.net>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: bcm2835: Add the PMU to the devicetree.
Date: Thu, 17 May 2018 10:11:02 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.1805171007260.7820@macbook-air> (raw)
In-Reply-To: <20180517131727.29263-1-eric@anholt.net>

On Thu, 17 May 2018, Eric Anholt wrote:

> diff --git a/arch/arm/boot/dts/bcm2837.dtsi b/arch/arm/boot/dts/bcm2837.dtsi
> index 7704bb029605..1f5e5c782835 100644
> --- a/arch/arm/boot/dts/bcm2837.dtsi
> +++ b/arch/arm/boot/dts/bcm2837.dtsi
> @@ -17,6 +17,12 @@
>  		};
>  	};
>  
> +	arm-pmu {
> +		compatible = "arm,cortex-a53-pmu", "arm,cortex-a7-pmu";
> +		interrupt-parent = <&local_intc>;
> +		interrupts = <9 IRQ_TYPE_LEVEL_HIGH>;
> +	};
> +

why this and not

arm-pmu {
	compatible = "arm,armv8-pmuv3";
	interrupt-parent = <&local_intc>;
	interrupts = <9>;
};

which works, though when I didn't get very far when I submitted the patch 
to add this last August.

Vince

WARNING: multiple messages have this Message-ID (diff)
From: vincent.weaver@maine.edu (Vince Weaver)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: bcm2835: Add the PMU to the devicetree.
Date: Thu, 17 May 2018 10:11:02 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.1805171007260.7820@macbook-air> (raw)
In-Reply-To: <20180517131727.29263-1-eric@anholt.net>

On Thu, 17 May 2018, Eric Anholt wrote:

> diff --git a/arch/arm/boot/dts/bcm2837.dtsi b/arch/arm/boot/dts/bcm2837.dtsi
> index 7704bb029605..1f5e5c782835 100644
> --- a/arch/arm/boot/dts/bcm2837.dtsi
> +++ b/arch/arm/boot/dts/bcm2837.dtsi
> @@ -17,6 +17,12 @@
>  		};
>  	};
>  
> +	arm-pmu {
> +		compatible = "arm,cortex-a53-pmu", "arm,cortex-a7-pmu";
> +		interrupt-parent = <&local_intc>;
> +		interrupts = <9 IRQ_TYPE_LEVEL_HIGH>;
> +	};
> +

why this and not

arm-pmu {
	compatible = "arm,armv8-pmuv3";
	interrupt-parent = <&local_intc>;
	interrupts = <9>;
};

which works, though when I didn't get very far when I submitted the patch 
to add this last August.

Vince

  reply	other threads:[~2018-05-17 14:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 13:17 [PATCH] arm: bcm2835: Add the PMU to the devicetree Eric Anholt
2018-05-17 13:17 ` Eric Anholt
2018-05-17 14:11 ` Vince Weaver [this message]
2018-05-17 14:11   ` Vince Weaver
2018-05-17 14:30   ` Eric Anholt
2018-05-17 14:30     ` Eric Anholt
2018-05-17 16:02     ` Vince Weaver
2018-05-17 16:02       ` Vince Weaver
2018-05-17 16:06   ` Stefan Wahren
2018-05-17 16:06     ` Stefan Wahren
2018-05-17 15:59 ` Stefan Wahren
2018-05-17 15:59   ` Stefan Wahren
2018-05-17 16:34   ` Vince Weaver
2018-05-17 16:34     ` Vince Weaver
2018-05-17 16:55     ` Stefan Wahren
2018-05-17 16:55       ` Stefan Wahren
2018-05-17 18:07       ` Peter Zijlstra
2018-05-17 18:07         ` Peter Zijlstra
2018-05-17 18:27         ` Vince Weaver
2018-05-17 18:27           ` Vince Weaver
2018-05-17 19:31           ` Vince Weaver
2018-05-17 19:31             ` Vince Weaver
2018-05-17 19:59             ` Florian Fainelli
2018-05-17 19:59               ` Florian Fainelli
2018-05-18  8:07               ` Marc Zyngier
2018-05-18  8:07                 ` Marc Zyngier
2018-05-18  9:37                 ` Stefan Wahren
2018-05-18  9:37                   ` Stefan Wahren
2018-05-18  9:49                   ` Marc Zyngier
2018-05-18  9:49                     ` Marc Zyngier
2018-05-17 17:09     ` Eric Anholt
2018-05-17 17:09       ` Eric Anholt
2018-05-17 16:44 ` Peter Robinson
2018-05-17 16:44   ` Peter Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1805171007260.7820@macbook-air \
    --to=vincent.weaver@maine.edu \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.