From: Joseph Myers <joseph@codesourcery.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: carlos <carlos@redhat.com>, Florian Weimer <fweimer@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>, Ben Maurer <bmaurer@fb.com>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Will Deacon <will.deacon@arm.com>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
libc-alpha <libc-alpha@sourceware.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>
Subject: Re: [RFC PATCH] glibc: Perform rseq(2) registration at nptl init and thread creation
Date: Thu, 20 Sep 2018 20:29:43 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1809202028120.17228@digraph.polyomino.org.uk> (raw)
In-Reply-To: <381061785.8994.1537473866841.JavaMail.zimbra@efficios.com>
On Thu, 20 Sep 2018, Mathieu Desnoyers wrote:
> Something like this in pthreadP.h ?
>
> +#ifdef __NR_rseq
> +#include <sysdeps/unix/sysv/linux/rseq-internal.h>
> +#else
> +#include <sysdeps/nptl/rseq-internal.h>
> +#endif /* __NR_rseq. */
>
> where sysdeps/unix/sysv/linux/rseq-internal.h contains the linux
> implementation of rseq_register_current_thread () and
> rseq_unregister_current_thread (), and sysdeps/nptl/rseq-internal.h
> contains stubs.
>
> Am I on the right track ?
It's hard to define the right abstractions for what goes where given that
only Linux uses NPTL since the removal of the NaCl port. I suppose it
does make logical sense for a #include of <linux/rseq.h> to go somewhere
under sysdeps/unix/sysv/linux/.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2018-09-20 20:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 14:44 [RFC PATCH] glibc: Perform rseq(2) registration at nptl init and thread creation Mathieu Desnoyers
2018-09-19 16:37 ` Joseph Myers
2018-09-19 16:37 ` Joseph Myers
2018-09-19 16:53 ` Mathieu Desnoyers
2018-09-19 17:10 ` Joseph Myers
2018-09-20 20:14 ` Mathieu Desnoyers
2018-09-20 20:20 ` Joseph Myers
2018-09-21 16:29 ` Mathieu Desnoyers
2018-09-20 20:04 ` Mathieu Desnoyers
2018-09-20 20:29 ` Joseph Myers [this message]
2018-09-19 17:38 ` Szabolcs Nagy
2018-09-19 19:49 ` Joseph Myers
2018-09-19 19:49 ` Joseph Myers
2018-09-19 20:10 ` Mathieu Desnoyers
2018-09-19 21:01 ` Mathieu Desnoyers
2018-09-20 10:28 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1809202028120.17228@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=bmaurer@fb.com \
--cc=boqun.feng@gmail.com \
--cc=carlos@redhat.com \
--cc=davejwatson@fb.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.