From: Joseph Myers <joseph@codesourcery.com> To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Carlos O'Donell <carlos@redhat.com>, Florian Weimer <fweimer@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Ben Maurer <bmaurer@fb.com>, Peter Zijlstra <peterz@infradead.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Boqun Feng <boqun.feng@gmail.com>, Will Deacon <will.deacon@arm.com>, Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>, <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>, <linux-api@vger.kernel.org> Subject: Re: [RFC PATCH] glibc: Perform rseq(2) registration at nptl init and thread creation Date: Wed, 19 Sep 2018 16:37:31 +0000 [thread overview] Message-ID: <alpine.DEB.2.21.1809191630260.26757@digraph.polyomino.org.uk> (raw) In-Reply-To: <20180919144438.1066-1-mathieu.desnoyers@efficios.com> On Wed, 19 Sep 2018, Mathieu Desnoyers wrote: > Here is a rough prototype registering rseq(2) TLS for each thread > (including main), and unregistering for each thread (excluding > main). "rseq" stands for Restartable Sequences. A final patch would need to add documentation and tests and a NEWS entry and fix various coding style issues. > diff --git a/nptl/Versions b/nptl/Versions > index e7f691da7a..7316c2815d 100644 > --- a/nptl/Versions > +++ b/nptl/Versions > @@ -275,6 +275,7 @@ libpthread { > mtx_init; mtx_lock; mtx_timedlock; mtx_trylock; mtx_unlock; mtx_destroy; > call_once; cnd_broadcast; cnd_destroy; cnd_init; cnd_signal; > cnd_timedwait; cnd_wait; tss_create; tss_delete; tss_get; tss_set; > + __rseq_abi; __rseq_refcount; That's the GLIBC_2.28 section, but 2.28 is already out. New symbols would need to go in GLIBC_2.29 or later (and the ABI test baselines would all need updating). > diff --git a/sysdeps/unix/sysv/linux/rseq.h b/sysdeps/unix/sysv/linux/rseq.h This looks like it's coming from the Linux kernel. Can't the relevant uapi header just be used directly without copying into glibc (with due care to ensure that glibc still builds if the kernel headers used for the build are too old - you need such conditionals anyway if they don't define the relevant syscall number)? -- Joseph S. Myers joseph@codesourcery.com
WARNING: multiple messages have this Message-ID (diff)
From: Joseph Myers <joseph@codesourcery.com> To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Carlos O'Donell <carlos@redhat.com>, Florian Weimer <fweimer@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Ben Maurer <bmaurer@fb.com>, Peter Zijlstra <peterz@infradead.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Boqun Feng <boqun.feng@gmail.com>, Will Deacon <will.deacon@arm.com>, Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>, libc-alpha@sourceware.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [RFC PATCH] glibc: Perform rseq(2) registration at nptl init and thread creation Date: Wed, 19 Sep 2018 16:37:31 +0000 [thread overview] Message-ID: <alpine.DEB.2.21.1809191630260.26757@digraph.polyomino.org.uk> (raw) In-Reply-To: <20180919144438.1066-1-mathieu.desnoyers@efficios.com> On Wed, 19 Sep 2018, Mathieu Desnoyers wrote: > Here is a rough prototype registering rseq(2) TLS for each thread > (including main), and unregistering for each thread (excluding > main). "rseq" stands for Restartable Sequences. A final patch would need to add documentation and tests and a NEWS entry and fix various coding style issues. > diff --git a/nptl/Versions b/nptl/Versions > index e7f691da7a..7316c2815d 100644 > --- a/nptl/Versions > +++ b/nptl/Versions > @@ -275,6 +275,7 @@ libpthread { > mtx_init; mtx_lock; mtx_timedlock; mtx_trylock; mtx_unlock; mtx_destroy; > call_once; cnd_broadcast; cnd_destroy; cnd_init; cnd_signal; > cnd_timedwait; cnd_wait; tss_create; tss_delete; tss_get; tss_set; > + __rseq_abi; __rseq_refcount; That's the GLIBC_2.28 section, but 2.28 is already out. New symbols would need to go in GLIBC_2.29 or later (and the ABI test baselines would all need updating). > diff --git a/sysdeps/unix/sysv/linux/rseq.h b/sysdeps/unix/sysv/linux/rseq.h This looks like it's coming from the Linux kernel. Can't the relevant uapi header just be used directly without copying into glibc (with due care to ensure that glibc still builds if the kernel headers used for the build are too old - you need such conditionals anyway if they don't define the relevant syscall number)? -- Joseph S. Myers joseph@codesourcery.com
next prev parent reply other threads:[~2018-09-19 16:37 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-19 14:44 [RFC PATCH] glibc: Perform rseq(2) registration at nptl init and thread creation Mathieu Desnoyers 2018-09-19 16:37 ` Joseph Myers [this message] 2018-09-19 16:37 ` Joseph Myers 2018-09-19 16:53 ` Mathieu Desnoyers 2018-09-19 17:10 ` Joseph Myers 2018-09-20 20:14 ` Mathieu Desnoyers 2018-09-20 20:20 ` Joseph Myers 2018-09-21 16:29 ` Mathieu Desnoyers 2018-09-20 20:04 ` Mathieu Desnoyers 2018-09-20 20:29 ` Joseph Myers 2018-09-19 17:38 ` Szabolcs Nagy 2018-09-19 19:49 ` Joseph Myers 2018-09-19 19:49 ` Joseph Myers 2018-09-19 20:10 ` Mathieu Desnoyers 2018-09-19 21:01 ` Mathieu Desnoyers 2018-09-20 10:28 ` Szabolcs Nagy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.21.1809191630260.26757@digraph.polyomino.org.uk \ --to=joseph@codesourcery.com \ --cc=bmaurer@fb.com \ --cc=boqun.feng@gmail.com \ --cc=carlos@redhat.com \ --cc=davejwatson@fb.com \ --cc=fweimer@redhat.com \ --cc=libc-alpha@sourceware.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mathieu.desnoyers@efficios.com \ --cc=paulmck@linux.vnet.ibm.com \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=tglx@linutronix.de \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.