All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Nayna Jain <nayna@linux.vnet.ibm.com>,
	"Usyskin, Alexander" <alexander.usyskin@intel.com>,
	"Struk, Tadeusz" <tadeusz.struk@intel.com>,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>,
	"linux-security-module@vger.kernel.org" 
	<linux-security-module@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] tpm: tpm_try_transmit() refactor error flow.
Date: Wed, 24 Oct 2018 11:59:34 +0300 (EEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1810241150580.3525@jsakkine-mobl1> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9D9FB5D1@hasmsx109.ger.corp.intel.com>

On Tue, 23 Oct 2018, Winkler, Tomas wrote:
> To  the  out  label we jump after we are  done with locality and cmd
> read() before we jump to locality 'locality'.  We will need to add
> another variable to check If cmd_ready() was called or not in order to
> get rid of the extran label, it's not internally tracked so far.

I think this is fine.

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

I tested this by assigning rc error code instead of requesting locality
in addition of testig unchanged code.

/Jarkko

  reply	other threads:[~2018-10-24  8:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-16 13:37 [PATCH] tpm: tpm_try_transmit() refactor error flow Tomas Winkler
2018-10-18  0:14 ` Jarkko Sakkinen
2018-10-18  6:06   ` Winkler, Tomas
2018-10-18  6:06     ` Winkler, Tomas
2018-10-19 23:34     ` Jarkko Sakkinen
2018-10-19 23:34       ` Jarkko Sakkinen
2018-10-20 22:49       ` Winkler, Tomas
2018-10-20 22:49         ` Winkler, Tomas
2018-10-23 13:27         ` Jarkko Sakkinen
2018-10-23 13:27           ` Jarkko Sakkinen
2018-10-23 14:16           ` Winkler, Tomas
2018-10-23 14:16             ` Winkler, Tomas
2018-10-24  8:59             ` Jarkko Sakkinen [this message]
2018-10-24  8:59               ` Jarkko Sakkinen
2018-10-24  9:01               ` Winkler, Tomas
2018-10-24  9:01                 ` Winkler, Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1810241150580.3525@jsakkine-mobl1 \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nayna@linux.vnet.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=tadeusz.struk@intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.