All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: erofs: Modify conditional check.
@ 2018-11-04 19:57 ` Bhagyashri P. Dighole
  0 siblings, 0 replies; 6+ messages in thread
From: Bhagyashri P. Dighole @ 2018-11-04 19:57 UTC (permalink / raw)


This patch includes modified condition to check for bio struct.

Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri at gmail.com>
---
 drivers/staging/erofs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
index 6384f73..a671ad4 100644
--- a/drivers/staging/erofs/data.c
+++ b/drivers/staging/erofs/data.c
@@ -240,7 +240,7 @@ static inline struct bio *erofs_read_raw_page(
 		bio = NULL;
 	}
 
-	if (bio == NULL) {
+	if (!bio) {
 		struct erofs_map_blocks map = {
 			.m_la = blknr_to_addr(current_block),
 		};
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] staging: erofs: Modify conditional check.
@ 2018-11-04 19:57 ` Bhagyashri P. Dighole
  0 siblings, 0 replies; 6+ messages in thread
From: Bhagyashri P. Dighole @ 2018-11-04 19:57 UTC (permalink / raw)
  To: Gao Xiang, Chao Yu, Greg Kroah-Hartman, Sasha Levin
  Cc: Outreachy, linux-erofs

This patch includes modified condition to check for bio struct.

Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri@gmail.com>
---
 drivers/staging/erofs/data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
index 6384f73..a671ad4 100644
--- a/drivers/staging/erofs/data.c
+++ b/drivers/staging/erofs/data.c
@@ -240,7 +240,7 @@ static inline struct bio *erofs_read_raw_page(
 		bio = NULL;
 	}
 
-	if (bio == NULL) {
+	if (!bio) {
 		struct erofs_map_blocks map = {
 			.m_la = blknr_to_addr(current_block),
 		};
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Outreachy kernel] [PATCH] staging: erofs: Modify conditional check.
  2018-11-04 19:57 ` Bhagyashri P. Dighole
@ 2018-11-04 20:06   ` Julia Lawall
  -1 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2018-11-04 20:06 UTC (permalink / raw)




On Mon, 5 Nov 2018, Bhagyashri P. Dighole wrote:

> This patch includes modified condition to check for bio struct.

The commit message is sort of wordy and imprecise.  Don't say "This patch
includes".  The commit log message should be in the imperative.  That is,
it should start with a verb.  Here, the first word could perhaps be
Modify.  Afterwards, you should explain what was done and why.  Here you
could say "Use ! for a NULL test rather than explicitly comparing to NULL,
to be more concise and readable".  Then, if you came across this issue due
to checkpatch, it would be nice to acknowledge that - Issue found using
checkpatch.

Finally, if you are going to send the other changes then they all need to
be in a series.  On the other hand, for your first patch, it is fine to
only send this change.  But in that case you have to work on something
else until Greg picks this up.  If there are multiple changes on one file,
he needs the series number to know in what order to apply them.

julia

>
> Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri at gmail.com>
> ---
>  drivers/staging/erofs/data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
> index 6384f73..a671ad4 100644
> --- a/drivers/staging/erofs/data.c
> +++ b/drivers/staging/erofs/data.c
> @@ -240,7 +240,7 @@ static inline struct bio *erofs_read_raw_page(
>  		bio = NULL;
>  	}
>
> -	if (bio == NULL) {
> +	if (!bio) {
>  		struct erofs_map_blocks map = {
>  			.m_la = blknr_to_addr(current_block),
>  		};
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe at googlegroups.com.
> To post to this group, send email to outreachy-kernel at googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104195701.GA18201%40bhagyashri-Lenovo-G570.
> For more options, visit https://groups.google.com/d/optout.
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: erofs: Modify conditional check.
@ 2018-11-04 20:06   ` Julia Lawall
  0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2018-11-04 20:06 UTC (permalink / raw)
  To: Bhagyashri P. Dighole
  Cc: Gao Xiang, Chao Yu, Greg Kroah-Hartman, Sasha Levin, Outreachy,
	linux-erofs



On Mon, 5 Nov 2018, Bhagyashri P. Dighole wrote:

> This patch includes modified condition to check for bio struct.

The commit message is sort of wordy and imprecise.  Don't say "This patch
includes".  The commit log message should be in the imperative.  That is,
it should start with a verb.  Here, the first word could perhaps be
Modify.  Afterwards, you should explain what was done and why.  Here you
could say "Use ! for a NULL test rather than explicitly comparing to NULL,
to be more concise and readable".  Then, if you came across this issue due
to checkpatch, it would be nice to acknowledge that - Issue found using
checkpatch.

Finally, if you are going to send the other changes then they all need to
be in a series.  On the other hand, for your first patch, it is fine to
only send this change.  But in that case you have to work on something
else until Greg picks this up.  If there are multiple changes on one file,
he needs the series number to know in what order to apply them.

julia

>
> Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri@gmail.com>
> ---
>  drivers/staging/erofs/data.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
> index 6384f73..a671ad4 100644
> --- a/drivers/staging/erofs/data.c
> +++ b/drivers/staging/erofs/data.c
> @@ -240,7 +240,7 @@ static inline struct bio *erofs_read_raw_page(
>  		bio = NULL;
>  	}
>
> -	if (bio == NULL) {
> +	if (!bio) {
>  		struct erofs_map_blocks map = {
>  			.m_la = blknr_to_addr(current_block),
>  		};
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181104195701.GA18201%40bhagyashri-Lenovo-G570.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Outreachy kernel] [PATCH] staging: erofs: Modify conditional check.
  2018-11-04 20:06   ` Julia Lawall
@ 2018-11-05  4:23     ` Bhagyashri Dighole
  -1 siblings, 0 replies; 6+ messages in thread
From: Bhagyashri Dighole @ 2018-11-05  4:23 UTC (permalink / raw)


Thanks Julia, I will update commit log message for patch and add version
for patch. I will also add series number if there are multiple changes on
the same file.

Bhagyashri

On Mon, Nov 5, 2018@1:36 AM Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Mon, 5 Nov 2018, Bhagyashri P. Dighole wrote:
>
> > This patch includes modified condition to check for bio struct.
>
> The commit message is sort of wordy and imprecise.  Don't say "This patch
> includes".  The commit log message should be in the imperative.  That is,
> it should start with a verb.  Here, the first word could perhaps be
> Modify.  Afterwards, you should explain what was done and why.  Here you
> could say "Use ! for a NULL test rather than explicitly comparing to NULL,
> to be more concise and readable".  Then, if you came across this issue due
> to checkpatch, it would be nice to acknowledge that - Issue found using
> checkpatch.
>
> Finally, if you are going to send the other changes then they all need to
> be in a series.  On the other hand, for your first patch, it is fine to
> only send this change.  But in that case you have to work on something
> else until Greg picks this up.  If there are multiple changes on one file,
> he needs the series number to know in what order to apply them.
>
> julia
>
> >
> > Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri at gmail.com>
> > ---
> >  drivers/staging/erofs/data.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
> > index 6384f73..a671ad4 100644
> > --- a/drivers/staging/erofs/data.c
> > +++ b/drivers/staging/erofs/data.c
> > @@ -240,7 +240,7 @@ static inline struct bio *erofs_read_raw_page(
> >               bio = NULL;
> >       }
> >
> > -     if (bio == NULL) {
> > +     if (!bio) {
> >               struct erofs_map_blocks map = {
> >                       .m_la = blknr_to_addr(current_block),
> >               };
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe at googlegroups.com.
> > To post to this group, send email to outreachy-kernel at googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20181104195701.GA18201%40bhagyashri-Lenovo-G570
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-erofs/attachments/20181105/02cba1c2/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: erofs: Modify conditional check.
@ 2018-11-05  4:23     ` Bhagyashri Dighole
  0 siblings, 0 replies; 6+ messages in thread
From: Bhagyashri Dighole @ 2018-11-05  4:23 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Gao Xiang, Chao Yu, Greg Kroah-Hartman, Sasha Levin, Outreachy,
	linux-erofs

[-- Attachment #1: Type: text/plain, Size: 2533 bytes --]

Thanks Julia, I will update commit log message for patch and add version
for patch. I will also add series number if there are multiple changes on
the same file.

Bhagyashri

On Mon, Nov 5, 2018 at 1:36 AM Julia Lawall <julia.lawall@lip6.fr> wrote:

>
>
> On Mon, 5 Nov 2018, Bhagyashri P. Dighole wrote:
>
> > This patch includes modified condition to check for bio struct.
>
> The commit message is sort of wordy and imprecise.  Don't say "This patch
> includes".  The commit log message should be in the imperative.  That is,
> it should start with a verb.  Here, the first word could perhaps be
> Modify.  Afterwards, you should explain what was done and why.  Here you
> could say "Use ! for a NULL test rather than explicitly comparing to NULL,
> to be more concise and readable".  Then, if you came across this issue due
> to checkpatch, it would be nice to acknowledge that - Issue found using
> checkpatch.
>
> Finally, if you are going to send the other changes then they all need to
> be in a series.  On the other hand, for your first patch, it is fine to
> only send this change.  But in that case you have to work on something
> else until Greg picks this up.  If there are multiple changes on one file,
> he needs the series number to know in what order to apply them.
>
> julia
>
> >
> > Signed-off-by: Bhagyashri P. Dighole <digholebhagyashri@gmail.com>
> > ---
> >  drivers/staging/erofs/data.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
> > index 6384f73..a671ad4 100644
> > --- a/drivers/staging/erofs/data.c
> > +++ b/drivers/staging/erofs/data.c
> > @@ -240,7 +240,7 @@ static inline struct bio *erofs_read_raw_page(
> >               bio = NULL;
> >       }
> >
> > -     if (bio == NULL) {
> > +     if (!bio) {
> >               struct erofs_map_blocks map = {
> >                       .m_la = blknr_to_addr(current_block),
> >               };
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20181104195701.GA18201%40bhagyashri-Lenovo-G570
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>

[-- Attachment #2: Type: text/html, Size: 3596 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-05  4:23 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-04 19:57 [PATCH] staging: erofs: Modify conditional check Bhagyashri P. Dighole
2018-11-04 19:57 ` Bhagyashri P. Dighole
2018-11-04 20:06 ` [Outreachy kernel] " Julia Lawall
2018-11-04 20:06   ` Julia Lawall
2018-11-05  4:23   ` Bhagyashri Dighole
2018-11-05  4:23     ` Bhagyashri Dighole

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.