[PATCH 0/2] staging: greybus: fix styling and bool comparison

[PATCH 0/2] staging: greybus: fix styling and bool comparison

[Ioannis Valasakis]

Fix styling and bool comparison per coccinelle warnings.

Ioannis Valasakis (2):
  staging: greybus: remove comparison to BOOL
  staging: graybus: match open parentheses

 drivers/staging/greybus/es2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.19.1

[PATCH 1/2] staging: greybus: remove comparison to BOOL

[Ioannis Valasakis]

Remove two instances of a comparison to BOOL.
Reported by coccinelle.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/es2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index b082d81833a0..afaa6d15c23b 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -316,8 +316,8 @@ static struct urb *next_free_urb(struct es2_ap_dev *es2, gfp_t gfp_mask)
 
 	/* Look in our pool of allocated urbs first, as that's the "fastest" */
 	for (i = 0; i < NUM_CPORT_OUT_URB; ++i) {
-		if (es2->cport_out_urb_busy[i] == false &&
-				es2->cport_out_urb_cancelled[i] == false) {
+		if (!es2->cport_out_urb_busy[i] &&
+				!es2->cport_out_urb_cancelled[i]) {
 			es2->cport_out_urb_busy[i] = true;
 			urb = es2->cport_out_urb[i];
 			break;
-- 
2.19.1

[PATCH 2/2] staging: graybus: match open parentheses

[Ioannis Valasakis]

Match open parentheses by indenting.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/es2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index afaa6d15c23b..b4e3d6a3d523 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -317,7 +317,7 @@ static struct urb *next_free_urb(struct es2_ap_dev *es2, gfp_t gfp_mask)
 	/* Look in our pool of allocated urbs first, as that's the "fastest" */
 	for (i = 0; i < NUM_CPORT_OUT_URB; ++i) {
 		if (!es2->cport_out_urb_busy[i] &&
-				!es2->cport_out_urb_cancelled[i]) {
+		    !es2->cport_out_urb_cancelled[i]) {
 			es2->cport_out_urb_busy[i] = true;
 			urb = es2->cport_out_urb[i];
 			break;
-- 
2.19.1

Re: [Outreachy kernel] [PATCH 0/2] staging: greybus: fix styling and bool comparison

[Julia Lawall]

On Sun, 4 Nov 2018, Ioannis Valasakis wrote:

> Fix styling and bool comparison per coccinelle warnings.
>
> Ioannis Valasakis (2):
>   staging: greybus: remove comparison to BOOL
>   staging: graybus: match open parentheses

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

>
>  drivers/staging/greybus/es2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.19.1
>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1541366816.git.code%40wizofe.uk.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH 0/2] staging: greybus: fix styling and bool comparison

[Greg KH]

On Sun, Nov 04, 2018 at 09:27:47PM +0000, Ioannis Valasakis wrote:
> Fix styling and bool comparison per coccinelle warnings.
> 
> Ioannis Valasakis (2):
>   staging: greybus: remove comparison to BOOL
>   staging: graybus: match open parentheses
> 
>  drivers/staging/greybus/es2.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why isn't this part of the previous patch series?

And I only see 1 patch here, not 2.

There's way too many changes floating around from you for these drivers
for me to be able to easily figure out what is going on.
Can you resend the latest version of all of your patches for the greybus
drivers, as one single patch series, with the latest "version" number on
them, so I know what to review and hopefully apply to the tree?

thanks,

greg k-h

Re: [PATCH 2/2] staging: graybus: match open parentheses

[Greg KH]

On Sun, Nov 04, 2018 at 09:28:06PM +0000, Ioannis Valasakis wrote:
> Match open parentheses by indenting.
> Reported by checkpatch.
> 
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/es2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ah, this is the 2/2 patch, it didn't show up in my searching as you
mispelled "greybus" on the Subject: line :(

Re: [PATCH 2/2] staging: graybus: match open parentheses

[Ioannis Valasakis]

On Mon, Nov 05, 2018 at 02:53:14PM +0100, Greg KH wrote:
> On Sun, Nov 04, 2018 at 09:28:06PM +0000, Ioannis Valasakis wrote:
> > Match open parentheses by indenting.
> > Reported by checkpatch.
> > 
> > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > ---
> >  drivers/staging/greybus/es2.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Ah, this is the 2/2 patch, it didn't show up in my searching as you
> mispelled "greybus" on the Subject: line :(
Oh, I am sorry about this! Do you still need the whole series of greybus
to be send as a patchset? thanks 

ioannis
> 

Re: [PATCH 2/2] staging: graybus: match open parentheses

[Greg KH]

On Mon, Nov 05, 2018 at 01:59:04PM +0000, Ioannis Valasakis wrote:
> On Mon, Nov 05, 2018 at 02:53:14PM +0100, Greg KH wrote:
> > On Sun, Nov 04, 2018 at 09:28:06PM +0000, Ioannis Valasakis wrote:
> > > Match open parentheses by indenting.
> > > Reported by checkpatch.
> > > 
> > > Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> > > ---
> > >  drivers/staging/greybus/es2.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Ah, this is the 2/2 patch, it didn't show up in my searching as you
> > mispelled "greybus" on the Subject: line :(
> Oh, I am sorry about this! Do you still need the whole series of greybus
> to be send as a patchset? thanks 

Yes, all of the patches have now been processed by me, so if I did not
apply them, please redo and resend.

thanks,

greg k-h