* [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig @ 2019-03-01 9:02 Wentao Cai 2019-03-01 9:08 ` Greg Kroah-Hartman 0 siblings, 1 reply; 6+ messages in thread From: Wentao Cai @ 2019-03-01 9:02 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: outreachy-kernel, Wentao Cai Delete the newline at the end of a Kconfig file, to silence the checkpatch warning: WARNING: please write a paragraph that describes the config symbol fully. Signed-off-by: Wentao Cai <etsai042@gmail.com> --- drivers/staging/gs_fpgaboot/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/Kconfig b/drivers/staging/gs_fpgaboot/Kconfig index 550645291fab..f1179eef2d78 100644 --- a/drivers/staging/gs_fpgaboot/Kconfig +++ b/drivers/staging/gs_fpgaboot/Kconfig @@ -5,4 +5,4 @@ config GS_FPGABOOT tristate "Xilinx FPGA firmware download module" default n help - Xilinx FPGA firmware download module + Xilinx FPGA firmware download module \ No newline at end of file -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig 2019-03-01 9:02 [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig Wentao Cai @ 2019-03-01 9:08 ` Greg Kroah-Hartman 2019-03-13 8:34 ` Wentao Cai 0 siblings, 1 reply; 6+ messages in thread From: Greg Kroah-Hartman @ 2019-03-01 9:08 UTC (permalink / raw) To: Wentao Cai; +Cc: outreachy-kernel On Fri, Mar 01, 2019 at 05:02:25PM +0800, Wentao Cai wrote: > Delete the newline at the end of a Kconfig file, to silence the > checkpatch warning: > WARNING: please write a paragraph that describes the config symbol > fully. That is not the way to fix this warning :) You need to actually write a paragraph, not delete an empty line. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig 2019-03-01 9:08 ` Greg Kroah-Hartman @ 2019-03-13 8:34 ` Wentao Cai 2019-03-13 8:37 ` [Outreachy kernel] " Julia Lawall 2019-03-13 14:18 ` Greg KH 0 siblings, 2 replies; 6+ messages in thread From: Wentao Cai @ 2019-03-13 8:34 UTC (permalink / raw) To: outreachy-kernel [-- Attachment #1.1: Type: text/plain, Size: 951 bytes --] On Friday, March 1, 2019 at 1:08:53 AM UTC-8, gregkh wrote: > > > On Fri, Mar 01, 2019 at 05:02:25PM +0800, Wentao Cai wrote: > > > Delete the newline at the end of a Kconfig file, to silence the > > > checkpatch warning: > > > WARNING: please write a paragraph that describes the config symbol > > > fully. > > > > That is not the way to fix this warning :) > > > > You need to actually write a paragraph, not delete an empty line. > > > Hi, greg, I wonder if it is ok to solve this problem by adding this? Say Y if you want to include this driver in the kernel. To compile this driver as a module, choose M here. The module will be called gs_fpgaboot.ko. Also I have a stupid question. I've just reinstall my system, so I can't revise my previous patches through git log. If I want to revise those patches, should I still send them with a [PATCH vn] version or just with [PATCH]? Thanks, Wentao > thanks, > > > > greg k-h > [-- Attachment #1.2: Type: text/html, Size: 1485 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig 2019-03-13 8:34 ` Wentao Cai @ 2019-03-13 8:37 ` Julia Lawall 2019-03-13 8:53 ` Wentao Cai 2019-03-13 14:18 ` Greg KH 1 sibling, 1 reply; 6+ messages in thread From: Julia Lawall @ 2019-03-13 8:37 UTC (permalink / raw) To: Wentao Cai; +Cc: outreachy-kernel [-- Attachment #1: Type: text/plain, Size: 1788 bytes --] On Wed, 13 Mar 2019, Wentao Cai wrote: > > > On Friday, March 1, 2019 at 1:08:53 AM UTC-8, gregkh wrote: > > On Fri, Mar 01, 2019 at 05:02:25PM +0800, Wentao Cai wrote: > > > Delete the newline at the end of a Kconfig file, to silence the > > > checkpatch warning: > > > WARNING: please write a paragraph that describes the config symbol > > > fully. > > > > That is not the way to fix this warning :) > > > > You need to actually write a paragraph, not delete an empty line. > > > > Hi, greg, I wonder if it is ok to solve this problem by adding this? > > Say Y if you want to include this driver in the kernel. > To compile this driver as a module, choose M here. The module will be called gs_fpgaboot.ko. > > Also I have a stupid question. I've just reinstall my system, so I can't revise my previous patches through git log. > If I want to revise those patches, should I still send them with a [PATCH vn] version or just with [PATCH]? The version number is from the recipient's point of view. So it doesn't matter if you are revising your previos patch or creating it again from scratch. julia > > Thanks, > > Wentao > > > thanks, > > > > greg k-h > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/6289455c-2178-4baf-b1ae-899b7c19fa2a%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig 2019-03-13 8:37 ` [Outreachy kernel] " Julia Lawall @ 2019-03-13 8:53 ` Wentao Cai 0 siblings, 0 replies; 6+ messages in thread From: Wentao Cai @ 2019-03-13 8:53 UTC (permalink / raw) To: outreachy-kernel [-- Attachment #1.1: Type: text/plain, Size: 1208 bytes --] On Wednesday, March 13, 2019 at 1:37:40 AM UTC-7, Julia Lawall wrote: > > > Also I have a stupid question. I've just reinstall my system, so I can't > revise my previous patches through git log. > > If I want to revise those patches, should I still send them with a > [PATCH vn] version or just with [PATCH]? > > > The version number is from the recipient's point of view. So it doesn't > > matter if you are revising your previos patch or creating it again from > > scratch. > > > > julia > > Thanks, Julia! > > > > Thanks, > > > > Wentao > > > > > thanks, > > > > > > greg k-h > > > > -- > > You received this message because you are subscribed to the Google > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to outreachy-kern...@googlegroups.com <javascript:>. > > To post to this group, send email to outreach...@googlegroups.com > <javascript:>. > > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/6289455c-2178-4baf-b1ae-899b7c19fa2a%40googlegroups.com. > > > For more options, visit https://groups.google.com/d/optout. > > > > [-- Attachment #1.2: Type: text/html, Size: 2794 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig 2019-03-13 8:34 ` Wentao Cai 2019-03-13 8:37 ` [Outreachy kernel] " Julia Lawall @ 2019-03-13 14:18 ` Greg KH 1 sibling, 0 replies; 6+ messages in thread From: Greg KH @ 2019-03-13 14:18 UTC (permalink / raw) To: Wentao Cai; +Cc: outreachy-kernel On Wed, Mar 13, 2019 at 01:34:55AM -0700, Wentao Cai wrote: > > > On Friday, March 1, 2019 at 1:08:53 AM UTC-8, gregkh wrote: > > > > > On Fri, Mar 01, 2019 at 05:02:25PM +0800, Wentao Cai wrote: > > > > Delete the newline at the end of a Kconfig file, to silence the > > > > checkpatch warning: > > > > WARNING: please write a paragraph that describes the config symbol > > > > fully. > > > > > > That is not the way to fix this warning :) > > > > > > You need to actually write a paragraph, not delete an empty line. > > > > > > Hi, greg, I wonder if it is ok to solve this problem by adding this? > > Say Y if you want to include this driver in the kernel. > To compile this driver as a module, choose M here. The module will be > called gs_fpgaboot.ko. You need to say what the driver does, otherwise the user has no idea if they need it or not. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-13 14:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-01 9:02 [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig Wentao Cai 2019-03-01 9:08 ` Greg Kroah-Hartman 2019-03-13 8:34 ` Wentao Cai 2019-03-13 8:37 ` [Outreachy kernel] " Julia Lawall 2019-03-13 8:53 ` Wentao Cai 2019-03-13 14:18 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.