* [PATCH] [Outreachy kernel] staging: vt6655: spaces around operators
@ 2019-03-21 6:23 Payal Kshirsagar
2019-03-21 6:32 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Payal Kshirsagar @ 2019-03-21 6:23 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar
Prefer spaces around operators
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/vt6655/device_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index b370985..866d794 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -592,7 +592,7 @@ static int device_init_rd1_ring(struct vnt_private *priv)
goto err_free_rd;
}
- desc->next = &priv->aRD1Ring[(i+1) % priv->opts.rx_descs1];
+ desc->next = &priv->aRD1Ring[(i + 1) % priv->opts.rx_descs1];
desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_rx_desc));
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: vt6655: spaces around operators
2019-03-21 6:23 [PATCH] [Outreachy kernel] staging: vt6655: spaces around operators Payal Kshirsagar
@ 2019-03-21 6:32 ` Julia Lawall
2019-03-21 7:02 ` Payal Kshirsagar
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2019-03-21 6:32 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Thu, 21 Mar 2019, Payal Kshirsagar wrote:
> Prefer spaces around operators
Prefer -> Add
Add would say what you actually did.
julia
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index b370985..866d794 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -592,7 +592,7 @@ static int device_init_rd1_ring(struct vnt_private *priv)
> goto err_free_rd;
> }
>
> - desc->next = &priv->aRD1Ring[(i+1) % priv->opts.rx_descs1];
> + desc->next = &priv->aRD1Ring[(i + 1) % priv->opts.rx_descs1];
> desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_rx_desc));
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1553149424-7694-1-git-send-email-payal.s.kshirsagar.98%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: vt6655: spaces around operators
2019-03-21 6:32 ` Julia Lawall
@ 2019-03-21 7:02 ` Payal Kshirsagar
0 siblings, 0 replies; 3+ messages in thread
From: Payal Kshirsagar @ 2019-03-21 7:02 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]
On Thu, 21 Mar 2019 at 12:02, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Thu, 21 Mar 2019, Payal Kshirsagar wrote:
>
> > Prefer spaces around operators
>
> Prefer -> Add
>
> Add would say what you actually did.
>
> julia
>
Okay, I will resend it.
payal
>
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> > drivers/staging/vt6655/device_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6655/device_main.c
> b/drivers/staging/vt6655/device_main.c
> > index b370985..866d794 100644
> > --- a/drivers/staging/vt6655/device_main.c
> > +++ b/drivers/staging/vt6655/device_main.c
> > @@ -592,7 +592,7 @@ static int device_init_rd1_ring(struct vnt_private
> *priv)
> > goto err_free_rd;
> > }
> >
> > - desc->next = &priv->aRD1Ring[(i+1) % priv->opts.rx_descs1];
> > + desc->next = &priv->aRD1Ring[(i + 1) %
> priv->opts.rx_descs1];
> > desc->next_desc = cpu_to_le32(curr + sizeof(struct
> vnt_rx_desc));
> > }
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/1553149424-7694-1-git-send-email-payal.s.kshirsagar.98%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
>
[-- Attachment #2: Type: text/html, Size: 2906 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-21 7:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 6:23 [PATCH] [Outreachy kernel] staging: vt6655: spaces around operators Payal Kshirsagar
2019-03-21 6:32 ` Julia Lawall
2019-03-21 7:02 ` Payal Kshirsagar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.