From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Himanshu Jha <himanshujha199640@gmail.com>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: Coccinelle: api: add devm_platform_ioremap_resource script
Date: Sat, 8 Jun 2019 19:26:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1906081925090.2543@hadrien> (raw)
In-Reply-To: <f09006a3-691c-382a-23b8-8e9ff5b4a5f1@web.de>
On Sat, 8 Jun 2019, Markus Elfring wrote:
> > +- e1 = devm_ioremap_resource(arg4, id);
> > ++ e1 = devm_platform_ioremap_resource(arg1, arg3);
>
> Can the following specification variant matter for the shown SmPL
> change approach?
>
> + e1 =
> +- devm_ioremap_resource(arg4, id
> ++ devm_platform_ioremap_resource(arg1, arg3
> + );
In the latter case, the original formatting of e1 will be preserved. But
there is not usually any interesting formatting on the left side of an
assignment (ie typically no newlines or comments). I can see no purpose
to factorizing the right parenthesis.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
cocci@systeme.lip6.fr
Subject: Re: Coccinelle: api: add devm_platform_ioremap_resource script
Date: Sat, 08 Jun 2019 17:26:35 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.1906081925090.2543@hadrien> (raw)
In-Reply-To: <f09006a3-691c-382a-23b8-8e9ff5b4a5f1@web.de>
On Sat, 8 Jun 2019, Markus Elfring wrote:
> > +- e1 = devm_ioremap_resource(arg4, id);
> > ++ e1 = devm_platform_ioremap_resource(arg1, arg3);
>
> Can the following specification variant matter for the shown SmPL
> change approach?
>
> + e1 > +- devm_ioremap_resource(arg4, id
> ++ devm_platform_ioremap_resource(arg1, arg3
> + );
In the latter case, the original formatting of e1 will be preserved. But
there is not usually any interesting formatting on the left side of an
assignment (ie typically no newlines or comments). I can see no purpose
to factorizing the right parenthesis.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
cocci@systeme.lip6.fr
Subject: Re: [Cocci] Coccinelle: api: add devm_platform_ioremap_resource script
Date: Sat, 8 Jun 2019 19:26:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1906081925090.2543@hadrien> (raw)
In-Reply-To: <f09006a3-691c-382a-23b8-8e9ff5b4a5f1@web.de>
On Sat, 8 Jun 2019, Markus Elfring wrote:
> > +- e1 = devm_ioremap_resource(arg4, id);
> > ++ e1 = devm_platform_ioremap_resource(arg1, arg3);
>
> Can the following specification variant matter for the shown SmPL
> change approach?
>
> + e1 =
> +- devm_ioremap_resource(arg4, id
> ++ devm_platform_ioremap_resource(arg1, arg3
> + );
In the latter case, the original formatting of e1 will be preserved. But
there is not usually any interesting formatting on the left side of an
assignment (ie typically no newlines or comments). I can see no purpose
to factorizing the right parenthesis.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-06-08 17:27 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 6:11 [PATCH] coccinelle: api: add devm_platform_ioremap_resource script Himanshu Jha
2019-04-06 6:23 ` Himanshu Jha
2019-04-06 6:11 ` [Cocci] " Himanshu Jha
2019-04-06 6:31 ` Julia Lawall
2019-04-06 6:31 ` [Cocci] " Julia Lawall
2019-04-06 6:31 ` Julia Lawall
2019-04-06 6:34 ` Julia Lawall
2019-04-06 6:34 ` [Cocci] " Julia Lawall
2019-04-06 6:34 ` Julia Lawall
2019-07-06 12:16 ` [Cocci] " Masahiro Yamada
2019-07-06 12:16 ` Masahiro Yamada
2019-07-06 12:16 ` Masahiro Yamada
2019-07-06 13:39 ` Julia Lawall
2019-07-06 13:39 ` Julia Lawall
2019-07-06 13:39 ` Julia Lawall
2019-07-07 9:55 ` Coccinelle: " Markus Elfring
2019-07-07 9:55 ` [Cocci] " Markus Elfring
2019-07-07 9:55 ` Markus Elfring
2019-07-07 12:38 ` Masahiro Yamada
2019-07-07 12:38 ` [Cocci] " Masahiro Yamada
2019-07-07 12:38 ` Masahiro Yamada
2019-09-19 7:21 ` Markus Elfring
2019-09-19 7:21 ` [Cocci] " Markus Elfring
2019-09-19 7:21 ` Markus Elfring
2019-04-06 12:36 ` [PATCH] coccinelle: " Markus Elfring
2019-04-06 12:36 ` [Cocci] " Markus Elfring
2019-04-06 12:36 ` Markus Elfring
2019-06-08 15:24 ` Coccinelle: " Markus Elfring
2019-06-08 15:24 ` [Cocci] " Markus Elfring
2019-06-08 15:24 ` Markus Elfring
2019-06-08 17:26 ` Julia Lawall [this message]
2019-06-08 17:26 ` [Cocci] " Julia Lawall
2019-06-08 17:26 ` Julia Lawall
2019-06-09 8:55 ` Markus Elfring
2019-06-09 8:55 ` [Cocci] " Markus Elfring
2019-06-09 8:55 ` Markus Elfring
2019-06-11 20:40 ` Enrico Weigelt, metux IT consult
2019-06-11 20:40 ` [Cocci] " Enrico Weigelt, metux IT consult
2019-06-11 20:40 ` Enrico Weigelt, metux IT consult
2019-06-12 5:28 ` Julia Lawall
2019-06-12 5:28 ` [Cocci] " Julia Lawall
2019-06-12 5:28 ` Julia Lawall
2019-06-12 6:24 ` Markus Elfring
2019-06-12 6:24 ` [Cocci] " Markus Elfring
2019-06-12 6:24 ` Markus Elfring
2019-06-14 9:22 ` [PATCH] drivers: Inline code in devm_platform_ioremap_resource() from two functions Markus Elfring
2019-06-14 9:22 ` [Cocci] " Markus Elfring
2019-06-14 9:22 ` Markus Elfring
2019-06-14 9:27 ` [Cocci] " Julia Lawall
2019-06-14 9:27 ` Julia Lawall
2019-06-14 9:27 ` Julia Lawall
2019-06-15 11:00 ` Markus Elfring
2019-06-15 11:00 ` [Cocci] " Markus Elfring
2019-06-15 11:00 ` Markus Elfring
2019-06-14 10:07 ` [PATCH] " Greg Kroah-Hartman
2019-06-14 10:07 ` [Cocci] " Greg Kroah-Hartman
2019-06-14 10:07 ` Greg Kroah-Hartman
2019-06-17 20:21 ` Enrico Weigelt, metux IT consult
2019-06-17 20:21 ` [Cocci] " Enrico Weigelt, metux IT consult
2019-06-17 20:21 ` Enrico Weigelt, metux IT consult
2019-06-18 5:37 ` Markus Elfring
2019-06-18 5:37 ` [Cocci] " Markus Elfring
2019-06-18 5:37 ` Markus Elfring
2019-06-18 9:35 ` Enrico Weigelt, metux IT consult
2019-06-18 9:35 ` [Cocci] " Enrico Weigelt, metux IT consult
2019-06-18 9:35 ` Enrico Weigelt, metux IT consult
2019-06-18 10:21 ` Dan Carpenter
2019-06-18 10:21 ` [Cocci] " Dan Carpenter
2019-06-18 10:21 ` Dan Carpenter
2019-06-18 11:44 ` Markus Elfring
2019-06-18 11:44 ` [Cocci] " Markus Elfring
2019-06-18 11:44 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906081925090.2543@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.