Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Patch version changes in commit logs?

[Thomas Gleixner <tglx@linutronix.de>]

On Tue, 2 Jul 2019, James Bottomley wrote:

> On Tue, 2019-07-02 at 18:43 -0400, Theodore Ts'o wrote:
> > On Tue, Jul 02, 2019 at 03:26:48PM -0700, James Bottomley wrote:
> > > git is our upstream for version control and our upstream has
> > > already
> > > had this as a feature since 2014.  Trying to go to upstream  5
> > > years
> > > later and ask them to change it is likely going to be a singularly
> > > unsuccessful exercise, plus even in the unlikely event we can work
> > > out
> > > how to do it compatibly and without causing confusion and upstream
> > > said
> > > yes it would take another few years to propagate.
> > 
> > If we really want to use the Link: header, we should be able to do
> > this without requiring any changes to git.
> > 
> > Step 1)   git config am.messageid true
> > Step 2)   Write and install a .git/hooks/applypatch-msg script which
> > 	  looks for Message-Id: and transmogrifies that line to a
> > 	  Link: trailer, using the lore.kernel.org URL template
> > Step 3)   Document this in Documentation/process.  For bonus points
> > 	  create a script which automatically sets up the user's git
> > 	  configuration by setting up am.messageid config and
> > 	  installing the hook file.
> > Step 4)   Profit
> 
> But we don't need the intermediate stages of that: Thomas already has a
> hook that can pick the Message-Id out of the email and transform it
> directly to a Link: tag (although I suspect it might be a pre-
> applypatch hook).

My workflow is not git-am based at all. My script converts a mbox to a
quilt series. That also picks up all tags from replies in mbox and adds the
Link from the message id to each patch.

I use that both for review and to polish stuff before I expose it to git
with git quiltimport and push it out.

But yes, I could easily convert that into a 'prepare mbox for git-am'
tool. I'm happy to do that.

But writing a script which converts the Message-ID tag which git can
generate into a 'Link: lore...' format for whatever git hook is appropriate
is not rocket science either.

Both solutions require the maintainer to do something extra. Ted's proposal
is perhaps more conveniant as it is a one time effort to add the script and
enable the am.messageid thing. But then probably most people have scripts
around git-am so adding it there is equally one time :)

Thanks,

	tglx