All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
	 nishkadg.linux@gmail.com, kim.jamie.bradley@gmail.com,
	 devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	 lkcamp@lists.libreplanetbr.org
Subject: Re: [Outreachy kernel] [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h
Date: Thu, 31 Oct 2019 07:35:54 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1910310734520.2718@hadrien> (raw)
In-Reply-To: <20191030190514.10011-4-gabrielabittencourt00@gmail.com>



On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:

> Cleans up checks of "Avoid CamelCase" in file sd.h
>
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
> ---
>  drivers/staging/rts5208/sd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h
> index dc9e8cad7a74..f4ff62653b56 100644
> --- a/drivers/staging/rts5208/sd.h
> +++ b/drivers/staging/rts5208/sd.h
> @@ -232,7 +232,7 @@
>  #define DCM_LOW_FREQUENCY_MODE   0x01
>
>  #define DCM_HIGH_FREQUENCY_MODE_SET  0x0C
> -#define DCM_Low_FREQUENCY_MODE_SET   0x00
> +#define DCM_LOW_FREQUENCY_MODE_SET   0x00

So this is never used in the kernel?  In that case, maybe it would still
be useful to keep it, because it somehow documents the device.  But the
log message should say that this is the case.

julia

>
>  #define MULTIPLY_BY_1    0x00
>  #define MULTIPLY_BY_2    0x01
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030190514.10011-4-gabrielabittencourt00%40gmail.com.
>


WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
	lkcamp@lists.libreplanetbr.org, nishkadg.linux@gmail.com,
	kim.jamie.bradley@gmail.com
Subject: Re: [Outreachy kernel] [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h
Date: Thu, 31 Oct 2019 07:35:54 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.21.1910310734520.2718@hadrien> (raw)
In-Reply-To: <20191030190514.10011-4-gabrielabittencourt00@gmail.com>



On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:

> Cleans up checks of "Avoid CamelCase" in file sd.h
>
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
> ---
>  drivers/staging/rts5208/sd.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h
> index dc9e8cad7a74..f4ff62653b56 100644
> --- a/drivers/staging/rts5208/sd.h
> +++ b/drivers/staging/rts5208/sd.h
> @@ -232,7 +232,7 @@
>  #define DCM_LOW_FREQUENCY_MODE   0x01
>
>  #define DCM_HIGH_FREQUENCY_MODE_SET  0x0C
> -#define DCM_Low_FREQUENCY_MODE_SET   0x00
> +#define DCM_LOW_FREQUENCY_MODE_SET   0x00

So this is never used in the kernel?  In that case, maybe it would still
be useful to keep it, because it somehow documents the device.  But the
log message should say that this is the case.

julia

>
>  #define MULTIPLY_BY_1    0x00
>  #define MULTIPLY_BY_2    0x01
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030190514.10011-4-gabrielabittencourt00%40gmail.com.
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2019-10-31  6:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 19:05 [PATCH v3 0/3] staging: rts5208: Eliminate the use of Camel Case Gabriela Bittencourt
2019-10-30 19:05 ` Gabriela Bittencourt
2019-10-30 19:05 ` [PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h,c} Gabriela Bittencourt
2019-10-30 19:05   ` [PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h, c} Gabriela Bittencourt
2019-10-31  6:40   ` [Outreachy kernel] [PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h,c} Julia Lawall
2019-10-31  6:40     ` Julia Lawall
2019-10-30 19:05 ` [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h,c} Gabriela Bittencourt
2019-10-30 19:05   ` [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h, c} Gabriela Bittencourt
2019-10-31  6:39   ` [Outreachy kernel] [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h,c} Julia Lawall
2019-10-31  6:39     ` Julia Lawall
2019-10-30 19:05 ` [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h Gabriela Bittencourt
2019-10-30 19:05   ` Gabriela Bittencourt
2019-10-31  6:35   ` Julia Lawall [this message]
2019-10-31  6:35     ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1910310734520.2718@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=devel@driverdev.osuosl.org \
    --cc=gabrielabittencourt00@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kim.jamie.bradley@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=nishkadg.linux@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.