[PATCH] media: staging/intel-ipu3: Fix wrong assignment to boolean variable

[PATCH] media: staging/intel-ipu3: Fix wrong assignment to boolean variable

[Javier F. Arias]

This patch fixes a warning by replacing the incorrect value with
a boolean.
Issue found by Coccinelle.

Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
---
 drivers/staging/media/ipu3/ipu3-css.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
index fd1ed84c400c..f36de501edc6 100644
--- a/drivers/staging/media/ipu3/ipu3-css.c
+++ b/drivers/staging/media/ipu3/ipu3-css.c
@@ -1450,7 +1450,7 @@ bool imgu_css_pipe_queue_empty(struct imgu_css *css, unsigned int pipe)
 bool imgu_css_queue_empty(struct imgu_css *css)
 {
 	unsigned int pipe;
-	bool ret = 0;
+	bool ret = false;
 
 	for (pipe = 0; pipe < IMGU_MAX_PIPE_NUM; pipe++)
 		ret &= imgu_css_pipe_queue_empty(css, pipe);
-- 
2.20.1

Re: [Outreachy kernel] [PATCH] media: staging/intel-ipu3: Fix wrong assignment to boolean variable

[Julia Lawall]

On Fri, 1 Nov 2019, Javier F. Arias wrote:

> This patch fixes a warning by replacing the incorrect value with
> a boolean.
> Issue found by Coccinelle.

The value is not really incorrect or wrong.  It is just not expressed in
an ideal way.

julia

>
> Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> ---
>  drivers/staging/media/ipu3/ipu3-css.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index fd1ed84c400c..f36de501edc6 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -1450,7 +1450,7 @@ bool imgu_css_pipe_queue_empty(struct imgu_css *css, unsigned int pipe)
>  bool imgu_css_queue_empty(struct imgu_css *css)
>  {
>  	unsigned int pipe;
> -	bool ret = 0;
> +	bool ret = false;
>
>  	for (pipe = 0; pipe < IMGU_MAX_PIPE_NUM; pipe++)
>  		ret &= imgu_css_pipe_queue_empty(css, pipe);
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191101171914.rphvreggpu6qj77e%40gmail.com.
>

Re: [Outreachy kernel] [PATCH] media: staging/intel-ipu3: Fix wrong assignment to boolean variable

[Javier F. Arias]

Thanks for your feedback. I'll edit the subject.

On Fri, Nov 01, 2019 at 08:10:10PM +0100, Julia Lawall wrote:
> 
> 
> On Fri, 1 Nov 2019, Javier F. Arias wrote:
> 
> > This patch fixes a warning by replacing the incorrect value with
> > a boolean.
> > Issue found by Coccinelle.
> 
> The value is not really incorrect or wrong.  It is just not expressed in
> an ideal way.
> 
> julia
> 
> >
> > Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> > ---
> >  drivers/staging/media/ipu3/ipu3-css.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> > index fd1ed84c400c..f36de501edc6 100644
> > --- a/drivers/staging/media/ipu3/ipu3-css.c
> > +++ b/drivers/staging/media/ipu3/ipu3-css.c
> > @@ -1450,7 +1450,7 @@ bool imgu_css_pipe_queue_empty(struct imgu_css *css, unsigned int pipe)
> >  bool imgu_css_queue_empty(struct imgu_css *css)
> >  {
> >  	unsigned int pipe;
> > -	bool ret = 0;
> > +	bool ret = false;
> >
> >  	for (pipe = 0; pipe < IMGU_MAX_PIPE_NUM; pipe++)
> >  		ret &= imgu_css_pipe_queue_empty(css, pipe);
> > --
> > 2.20.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191101171914.rphvreggpu6qj77e%40gmail.com.
> >