[Cocci] Checking data processing for parentheses in SmPL scripts

[Cocci] Checking data processing for parentheses in SmPL scripts

[Markus Elfring]

Hello,

The following change specification gets accepted by the Coccinelle software.

@@
expression X;
@@
-((X-1)&X) == 0
+powerof2(X)


See also:
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/722c3b8b6376deab9407ff00b5e63018ab3aef0b/test/cocci/useful_macros.cocci#L53


I got into the development mood to try another code variant out
for the semantic patch language.

@adjustment@
expression X;
@@
+powerof2(
-(X-1)&
 X)
- == 0


Unfortunately, the error message “unexpected close parenthesis in line 6”
is reported then.
Can an other change variation make sense finally?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Checking data processing for parentheses in SmPL scripts

[Markus Elfring]

> Unfortunately, the error message “unexpected close parenthesis in line 6”
> is reported then.

The following change specification gets accepted by the Coccinelle software.

@adjustment@
expression X;
@@
+powerof2
 (
-(X-1)&
 X)
- == 0


Would you like to discuss similar SmPL code variations any more?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Checking data processing for parentheses in SmPL scripts

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]



On Tue, 12 Nov 2019, Markus Elfring wrote:

> > Unfortunately, the error message “unexpected close parenthesis in line 6”
> > is reported then.
>
> The following change specification gets accepted by the Coccinelle software.
>
> @adjustment@
> expression X;
> @@
> +powerof2
>  (
> -(X-1)&
>  X)
> - == 0
>
>
> Would you like to discuss similar SmPL code variations any more?

What is the question, exactly?  Is there any reason why you would not
expect the above code to be accepted?

julia

>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Checking data processing for parentheses in SmPL scripts

[Markus Elfring]

> What is the question, exactly?

I became curious to clarify consequences around the error message
“unexpected close parenthesis in line 6” for the other SmPL code variant
from yesterday.
Is the Coccinelle software looking for pairs of parentheses?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Checking data processing for parentheses in SmPL scripts

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]



On Tue, 12 Nov 2019, Markus Elfring wrote:

> > What is the question, exactly?
>
> I became curious to clarify consequences around the error message
> “unexpected close parenthesis in line 6” for the other SmPL code variant
> from yesterday.
> Is the Coccinelle software looking for pairs of parentheses?

It looks for a ( in column 0 and a matching ) that is not in column 0.  In
your example there was no ( or ) in column 0, so the message is not
relevant.

julia

>
> Regards,
> Markus
>

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci