[linux-review:Daniel-Walker/drivers-net-gianfar-Shortest-frame-drops-at-Ethernet-port/20191109-035430 1155/1179] drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c:1454:37-38: hw_get_fw_version: first occurrence line 1489, second occurrence line 1509 (fwd)

[linux-review:Daniel-Walker/drivers-net-gianfar-Shortest-frame-drops-at-Ethernet-port/20191109-035430 1155/1179] drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c:1454:37-38: hw_get_fw_version: first occurrence line 1489, second occurrence line 1509 (fwd)

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 7916 bytes --]

Hello,

Some fields are initialized more than once. See the lines marked with @

julia

---------- Forwarded message ----------
Date: Sat, 9 Nov 2019 05:57:21 +0800
From: kbuild test robot <lkp@intel.com>
To: kbuild(a)lists.01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject:
    [linux-review:Daniel-Walker/drivers-net-gianfar-Shortest-frame-drops-at-Ethe
    rnet-port/20191109-035430 1155/1179]
    drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c:1454:37-38:
    hw_get_fw_version: first occurrence line 1489, second occurrence line 1509


tree:   https://github.com/0day-ci/linux/commits/Daniel-Walker/drivers-net-gianfar-Shortest-frame-drops-at-Ethernet-port/20191109-035430
head:   775d8e02563c45d55d70ccffb571259d752a9ab4
commit: ea4b4d7fc1065165874c27b8add252e04d104137 [1155/1179] net: atlantic: loopback tests via private flags
:::::: branch date: 2 hours ago
:::::: commit date: 18 hours ago

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>

>> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c:1454:37-38: hw_get_fw_version: first occurrence line 1489, second occurrence line 1509
>> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c:1454:37-38: hw_get_hw_stats: first occurrence line 1488, second occurrence line 1508
>> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c:1454:37-38: hw_set_offload: first occurrence line 1507, second occurrence line 1510

# https://github.com/0day-ci/linux/commit/ea4b4d7fc1065165874c27b8add252e04d104137
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout ea4b4d7fc1065165874c27b8add252e04d104137
vim +1454 drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c

ea4b4d7fc10651 Igor Russkikh   2019-11-07  1453
4948293ff963e5 Igor Russkikh   2018-01-19 @1454  const struct aq_hw_ops hw_atl_ops_b0 = {
bab6de8fd180bc David VomLehn   2017-01-23  1455  	.hw_set_mac_address   = hw_atl_b0_hw_mac_addr_set,
bab6de8fd180bc David VomLehn   2017-01-23  1456  	.hw_init              = hw_atl_b0_hw_init,
bab6de8fd180bc David VomLehn   2017-01-23  1457  	.hw_reset             = hw_atl_b0_hw_reset,
bab6de8fd180bc David VomLehn   2017-01-23  1458  	.hw_start             = hw_atl_b0_hw_start,
bab6de8fd180bc David VomLehn   2017-01-23  1459  	.hw_ring_tx_start     = hw_atl_b0_hw_ring_tx_start,
bab6de8fd180bc David VomLehn   2017-01-23  1460  	.hw_ring_tx_stop      = hw_atl_b0_hw_ring_tx_stop,
bab6de8fd180bc David VomLehn   2017-01-23  1461  	.hw_ring_rx_start     = hw_atl_b0_hw_ring_rx_start,
bab6de8fd180bc David VomLehn   2017-01-23  1462  	.hw_ring_rx_stop      = hw_atl_b0_hw_ring_rx_stop,
bab6de8fd180bc David VomLehn   2017-01-23  1463  	.hw_stop              = hw_atl_b0_hw_stop,
bab6de8fd180bc David VomLehn   2017-01-23  1464
bab6de8fd180bc David VomLehn   2017-01-23  1465  	.hw_ring_tx_xmit         = hw_atl_b0_hw_ring_tx_xmit,
bab6de8fd180bc David VomLehn   2017-01-23  1466  	.hw_ring_tx_head_update  = hw_atl_b0_hw_ring_tx_head_update,
bab6de8fd180bc David VomLehn   2017-01-23  1467
bab6de8fd180bc David VomLehn   2017-01-23  1468  	.hw_ring_rx_receive      = hw_atl_b0_hw_ring_rx_receive,
bab6de8fd180bc David VomLehn   2017-01-23  1469  	.hw_ring_rx_fill         = hw_atl_b0_hw_ring_rx_fill,
bab6de8fd180bc David VomLehn   2017-01-23  1470
bab6de8fd180bc David VomLehn   2017-01-23  1471  	.hw_irq_enable           = hw_atl_b0_hw_irq_enable,
bab6de8fd180bc David VomLehn   2017-01-23  1472  	.hw_irq_disable          = hw_atl_b0_hw_irq_disable,
bab6de8fd180bc David VomLehn   2017-01-23  1473  	.hw_irq_read             = hw_atl_b0_hw_irq_read,
bab6de8fd180bc David VomLehn   2017-01-23  1474
bab6de8fd180bc David VomLehn   2017-01-23  1475  	.hw_ring_rx_init             = hw_atl_b0_hw_ring_rx_init,
bab6de8fd180bc David VomLehn   2017-01-23  1476  	.hw_ring_tx_init             = hw_atl_b0_hw_ring_tx_init,
bab6de8fd180bc David VomLehn   2017-01-23  1477  	.hw_packet_filter_set        = hw_atl_b0_hw_packet_filter_set,
9a8cac4b4dae9d Dmitry Bogdanov 2018-11-12  1478  	.hw_filter_l2_set            = hw_atl_b0_hw_fl2_set,
9a8cac4b4dae9d Dmitry Bogdanov 2018-11-12  1479  	.hw_filter_l2_clear          = hw_atl_b0_hw_fl2_clear,
a6ed6f2269d64b Dmitry Bogdanov 2018-11-12  1480  	.hw_filter_l3l4_set          = hw_atl_b0_hw_fl3l4_set,
54bcb3d162a884 Dmitry Bogdanov 2018-11-12  1481  	.hw_filter_vlan_set          = hw_atl_b0_hw_vlan_set,
7975d2aff5afb6 Dmitry Bogdanov 2018-11-12  1482  	.hw_filter_vlan_ctrl         = hw_atl_b0_hw_vlan_ctrl,
bab6de8fd180bc David VomLehn   2017-01-23  1483  	.hw_multicast_list_set       = hw_atl_b0_hw_multicast_list_set,
bab6de8fd180bc David VomLehn   2017-01-23  1484  	.hw_interrupt_moderation_set = hw_atl_b0_hw_interrupt_moderation_set,
bab6de8fd180bc David VomLehn   2017-01-23  1485  	.hw_rss_set                  = hw_atl_b0_hw_rss_set,
bab6de8fd180bc David VomLehn   2017-01-23  1486  	.hw_rss_hash_set             = hw_atl_b0_hw_rss_hash_set,
bab6de8fd180bc David VomLehn   2017-01-23  1487  	.hw_get_regs                 = hw_atl_utils_hw_get_regs,
bab6de8fd180bc David VomLehn   2017-01-23 @1488  	.hw_get_hw_stats             = hw_atl_utils_get_hw_stats,
bab6de8fd180bc David VomLehn   2017-01-23 @1489  	.hw_get_fw_version           = hw_atl_utils_get_fw_version,
910479a9f793f4 Egor Pomozov    2019-10-22  1490
94ad94558b0fbf Egor Pomozov    2019-10-22  1491  	.hw_tx_tc_mode_get       = hw_atl_b0_tx_tc_mode_get,
94ad94558b0fbf Egor Pomozov    2019-10-22  1492  	.hw_rx_tc_mode_get       = hw_atl_b0_rx_tc_mode_get,
94ad94558b0fbf Egor Pomozov    2019-10-22  1493
04a1839950d92a Egor Pomozov    2019-10-22  1494  	.hw_ring_hwts_rx_fill        = hw_atl_b0_hw_ring_hwts_rx_fill,
04a1839950d92a Egor Pomozov    2019-10-22  1495  	.hw_ring_hwts_rx_receive     = hw_atl_b0_hw_ring_hwts_rx_receive,
04a1839950d92a Egor Pomozov    2019-10-22  1496
910479a9f793f4 Egor Pomozov    2019-10-22  1497  	.hw_get_ptp_ts           = hw_atl_b0_get_ptp_ts,
910479a9f793f4 Egor Pomozov    2019-10-22  1498  	.hw_adj_sys_clock        = hw_atl_b0_adj_sys_clock,
910479a9f793f4 Egor Pomozov    2019-10-22  1499  	.hw_set_sys_clock        = hw_atl_b0_set_sys_clock,
9c477032f7d0be Dmitry Bezrukov 2019-10-22  1500  	.hw_ts_to_sys_clock      = hw_atl_b0_ts_to_sys_clock,
910479a9f793f4 Egor Pomozov    2019-10-22  1501  	.hw_adj_clock_freq       = hw_atl_b0_adj_clock_freq,
9c477032f7d0be Dmitry Bezrukov 2019-10-22  1502  	.hw_gpio_pulse           = hw_atl_b0_gpio_pulse,
9c477032f7d0be Dmitry Bezrukov 2019-10-22  1503  	.hw_extts_gpio_enable    = hw_atl_b0_extts_gpio_enable,
9c477032f7d0be Dmitry Bezrukov 2019-10-22  1504  	.hw_get_sync_ts          = hw_atl_b0_get_sync_ts,
04a1839950d92a Egor Pomozov    2019-10-22  1505  	.rx_extract_ts           = hw_atl_b0_rx_extract_ts,
04a1839950d92a Egor Pomozov    2019-10-22  1506  	.extract_hwts            = hw_atl_b0_extract_hwts,
bbb67a44baf973 Dmitry Bogdanov 2018-11-09 @1507  	.hw_set_offload          = hw_atl_b0_hw_offload_set,
ea4b4d7fc10651 Igor Russkikh   2019-11-07 @1508  	.hw_get_hw_stats         = hw_atl_utils_get_hw_stats,
ea4b4d7fc10651 Igor Russkikh   2019-11-07 @1509  	.hw_get_fw_version       = hw_atl_utils_get_fw_version,
ea4b4d7fc10651 Igor Russkikh   2019-11-07 @1510  	.hw_set_offload          = hw_atl_b0_hw_offload_set,

:::::: The code at line 1454 was first introduced by commit
:::::: 4948293ff963e5451a8f0c21be8f1dfc2c7f65f5 net: aquantia: Introduce new AQC devices and capabilities

:::::: TO: Igor Russkikh <igor.russkikh@aquantia.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation