From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915/dp: fix DP infoframe init for PORT_A on gen12+
Date: Thu, 28 Nov 2019 17:09:37 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911281707360.16459@zeliteleevi> (raw)
In-Reply-To: <20191126235220.GH6337@mdroper-desk1.amr.corp.intel.com>
Hi,
On Tue, 26 Nov 2019, Matt Roper wrote:
> On Mon, Nov 25, 2019 at 02:53:13PM +0200, Kai Vehmanen wrote:
> > Starting with gen12, PORT_A can be also connected to DP
> > transcoder. Update code in intel_dp_init() to take this
> > into account.
>
> I don't think this function gets called on gen12; this one is for
> pre-DDI platforms. DP initialization on recent platforms happens via
> intel_ddi_init() and that one calls intel_infoframe_init without the
> PORT_A restriction.
aa, ok. Thanks for the reviews!
I was doing a mechanical check for all logic for PORT_A that assumed it
cannot be connected to DP/HDMI, and didn't check the full call chain. But
yeah, if this function never gets called on gen12, then this is a
non-issue and patch an be dropped.
Br, Kai
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dp: fix DP infoframe init for PORT_A on gen12+
Date: Thu, 28 Nov 2019 17:09:37 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911281707360.16459@zeliteleevi> (raw)
Message-ID: <20191128150937.QVRzYR06lQim6AQX44Ttvq0Tv9c8ElrosUqI68aGxyA@z> (raw)
In-Reply-To: <20191126235220.GH6337@mdroper-desk1.amr.corp.intel.com>
Hi,
On Tue, 26 Nov 2019, Matt Roper wrote:
> On Mon, Nov 25, 2019 at 02:53:13PM +0200, Kai Vehmanen wrote:
> > Starting with gen12, PORT_A can be also connected to DP
> > transcoder. Update code in intel_dp_init() to take this
> > into account.
>
> I don't think this function gets called on gen12; this one is for
> pre-DDI platforms. DP initialization on recent platforms happens via
> intel_ddi_init() and that one calls intel_infoframe_init without the
> PORT_A restriction.
aa, ok. Thanks for the reviews!
I was doing a mechanical check for all logic for PORT_A that assumed it
cannot be connected to DP/HDMI, and didn't check the full call chain. But
yeah, if this function never gets called on gen12, then this is a
non-issue and patch an be dropped.
Br, Kai
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-28 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 12:53 [PATCH v2 1/2] drm/i915/dp: fix DP audio for PORT_A on gen12+ Kai Vehmanen
2019-11-25 12:53 ` [Intel-gfx] " Kai Vehmanen
2019-11-25 12:53 ` [PATCH v2 2/2] drm/i915/dp: fix DP infoframe init " Kai Vehmanen
2019-11-25 12:53 ` [Intel-gfx] " Kai Vehmanen
2019-11-26 23:52 ` Matt Roper
2019-11-26 23:52 ` [Intel-gfx] " Matt Roper
2019-11-28 15:09 ` Kai Vehmanen [this message]
2019-11-28 15:09 ` Kai Vehmanen
2019-11-25 16:28 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/dp: fix DP audio " Patchwork
2019-11-25 16:28 ` [Intel-gfx] " Patchwork
2019-11-26 2:03 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-26 2:03 ` [Intel-gfx] " Patchwork
2019-11-26 8:24 ` Kai Vehmanen
2019-11-26 8:24 ` [Intel-gfx] " Kai Vehmanen
2019-11-27 0:15 ` Matt Roper
2019-11-27 0:15 ` [Intel-gfx] " Matt Roper
2019-11-27 0:10 ` [PATCH v2 1/2] " Matt Roper
2019-11-27 0:10 ` [Intel-gfx] " Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911281707360.16459@zeliteleevi \
--to=kai.vehmanen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.