[sashal-linux-stable:queue-4.9 4/81] drivers/spi/spidev.c:667:17-23: ERROR: reference preceded by free on line 664 (fwd)

[sashal-linux-stable:queue-4.9 4/81] drivers/spi/spidev.c:667:17-23: ERROR: reference preceded by free on line 664 (fwd)

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 4321 bytes --]

Please check the dereference on line 667.

julia

---------- Forwarded message ----------
Date: Sun, 22 Dec 2019 17:46:06 +0800
From: kbuild test robot <lkp@intel.com>
To: kbuild(a)lists.01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [sashal-linux-stable:queue-4.9 4/81] drivers/spi/spidev.c:667:17-23:
    ERROR: reference preceded by free on line 664

CC: kbuild-all(a)lists.01.org
BCC: philip.li(a)intel.com
TO: Alexander Levin <alexander.levin@microsoft.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.9
head:   c1606b16ad2ef060272ddc88b3727c23e09ea618
commit: c0f6bf7f159a5ef7329d1fd587e324678365912b [4/81] spi: Add call to spi_slave_abort() function when spidev driver is released
:::::: branch date: 8 hours ago
:::::: commit date: 9 hours ago

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>

>> drivers/spi/spidev.c:667:17-23: ERROR: reference preceded by free on line 664

# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/commit/?id=c0f6bf7f159a5ef7329d1fd587e324678365912b
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git remote update sashal-linux-stable
git checkout c0f6bf7f159a5ef7329d1fd587e324678365912b
vim +667 drivers/spi/spidev.c

814a8d50eb1d88 Andrea Paterniani 2007-05-08  635
814a8d50eb1d88 Andrea Paterniani 2007-05-08  636  static int spidev_release(struct inode *inode, struct file *filp)
814a8d50eb1d88 Andrea Paterniani 2007-05-08  637  {
814a8d50eb1d88 Andrea Paterniani 2007-05-08  638  	struct spidev_data	*spidev;
814a8d50eb1d88 Andrea Paterniani 2007-05-08  639
814a8d50eb1d88 Andrea Paterniani 2007-05-08  640  	mutex_lock(&device_list_lock);
814a8d50eb1d88 Andrea Paterniani 2007-05-08  641  	spidev = filp->private_data;
814a8d50eb1d88 Andrea Paterniani 2007-05-08  642  	filp->private_data = NULL;
b2c8daddcbe03a David Brownell    2008-06-05  643
b2c8daddcbe03a David Brownell    2008-06-05  644  	/* last close? */
814a8d50eb1d88 Andrea Paterniani 2007-05-08  645  	spidev->users--;
814a8d50eb1d88 Andrea Paterniani 2007-05-08  646  	if (!spidev->users) {
b2c8daddcbe03a David Brownell    2008-06-05  647  		int		dofree;
b2c8daddcbe03a David Brownell    2008-06-05  648
865f6d1974ddd9 Ray Jui           2014-10-09  649  		kfree(spidev->tx_buffer);
865f6d1974ddd9 Ray Jui           2014-10-09  650  		spidev->tx_buffer = NULL;
865f6d1974ddd9 Ray Jui           2014-10-09  651
865f6d1974ddd9 Ray Jui           2014-10-09  652  		kfree(spidev->rx_buffer);
865f6d1974ddd9 Ray Jui           2014-10-09  653  		spidev->rx_buffer = NULL;
b2c8daddcbe03a David Brownell    2008-06-05  654
56ea1075e7f077 Mark Brown        2015-11-16  655  		spin_lock_irq(&spidev->spi_lock);
dd85ebf681ef0e Sudip Mukherjee   2015-09-10  656  		if (spidev->spi)
9169051617df7f Mark Brown        2014-11-08  657  			spidev->speed_hz = spidev->spi->max_speed_hz;
9169051617df7f Mark Brown        2014-11-08  658
b2c8daddcbe03a David Brownell    2008-06-05  659  		/* ... after we unbound from the underlying device? */
b2c8daddcbe03a David Brownell    2008-06-05  660  		dofree = (spidev->spi == NULL);
b2c8daddcbe03a David Brownell    2008-06-05  661  		spin_unlock_irq(&spidev->spi_lock);
b2c8daddcbe03a David Brownell    2008-06-05  662
b2c8daddcbe03a David Brownell    2008-06-05  663  		if (dofree)
b2c8daddcbe03a David Brownell    2008-06-05 @664  			kfree(spidev);
814a8d50eb1d88 Andrea Paterniani 2007-05-08  665  	}
c0f6bf7f159a5e Lukasz Majewski   2019-09-25  666  #ifdef CONFIG_SPI_SLAVE
c0f6bf7f159a5e Lukasz Majewski   2019-09-25 @667  	spi_slave_abort(spidev->spi);
c0f6bf7f159a5e Lukasz Majewski   2019-09-25  668  #endif
814a8d50eb1d88 Andrea Paterniani 2007-05-08  669  	mutex_unlock(&device_list_lock);
814a8d50eb1d88 Andrea Paterniani 2007-05-08  670
99472cc08a8bda Fabio Estevam     2015-05-09  671  	return 0;
814a8d50eb1d88 Andrea Paterniani 2007-05-08  672  }
814a8d50eb1d88 Andrea Paterniani 2007-05-08  673

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation