From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Wen Yang" <wenyang@linux.alibaba.com>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Gilles Muller" <Gilles.Muller@lip6.fr>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Matthias Männich" <maennich@google.com>,
"Michal Marek" <michal.lkml@markovi.net>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls
Date: Thu, 9 Jan 2020 11:41:27 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2001091140380.10786@hadrien> (raw)
In-Reply-To: <9a2b7d00-442e-0c1b-73cc-aed2bbecd13a@web.de>
On Thu, 9 Jan 2020, Markus Elfring wrote:
> > +@script:python depends on org@
> > +p << r.p;
> > +ul << r.ul;
>
> I interpret this variable assignment in the way that it will work only
> if the corresponding branch of the SmPL disjunction was actually matched
> by the referenced SmPL rule.
> Thus I suggest now to split the source code search pattern into
> four separate rules.
Why?
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Michal Marek" <michal.lkml@markovi.net>,
"Wen Yang" <wenyang@linux.alibaba.com>,
"Gilles Muller" <Gilles.Muller@lip6.fr>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matthias Männich" <maennich@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
cocci@systeme.lip6.fr
Subject: Re: [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls
Date: Thu, 09 Jan 2020 10:41:27 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2001091140380.10786@hadrien> (raw)
In-Reply-To: <9a2b7d00-442e-0c1b-73cc-aed2bbecd13a@web.de>
On Thu, 9 Jan 2020, Markus Elfring wrote:
> > +@script:python depends on org@
> > +p << r.p;
> > +ul << r.ul;
>
> I interpret this variable assignment in the way that it will work only
> if the corresponding branch of the SmPL disjunction was actually matched
> by the referenced SmPL rule.
> Thus I suggest now to split the source code search pattern into
> four separate rules.
Why?
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Michal Marek" <michal.lkml@markovi.net>,
"Wen Yang" <wenyang@linux.alibaba.com>,
"Gilles Muller" <Gilles.Muller@lip6.fr>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matthias Männich" <maennich@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls
Date: Thu, 9 Jan 2020 11:41:27 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2001091140380.10786@hadrien> (raw)
In-Reply-To: <9a2b7d00-442e-0c1b-73cc-aed2bbecd13a@web.de>
On Thu, 9 Jan 2020, Markus Elfring wrote:
> > +@script:python depends on org@
> > +p << r.p;
> > +ul << r.ul;
>
> I interpret this variable assignment in the way that it will work only
> if the corresponding branch of the SmPL disjunction was actually matched
> by the referenced SmPL rule.
> Thus I suggest now to split the source code search pattern into
> four separate rules.
Why?
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-01-09 10:41 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 17:02 [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls Wen Yang
2020-01-07 17:02 ` [Cocci] " Wen Yang
2020-01-07 17:25 ` Julia Lawall
2020-01-07 17:25 ` [Cocci] " Julia Lawall
2020-01-10 13:11 ` Wen Yang
2020-01-10 13:11 ` [Cocci] " Wen Yang
2020-01-09 10:35 ` Markus Elfring
2020-01-09 10:35 ` [Cocci] " Markus Elfring
2020-01-09 10:35 ` Markus Elfring
2020-01-09 10:41 ` Julia Lawall [this message]
2020-01-09 10:41 ` [Cocci] " Julia Lawall
2020-01-09 10:41 ` Julia Lawall
2020-01-09 12:00 ` [v2] " Markus Elfring
2020-01-09 12:00 ` [Cocci] " Markus Elfring
2020-01-09 12:00 ` Markus Elfring
2020-01-09 12:04 ` Julia Lawall
2020-01-09 12:04 ` [Cocci] " Julia Lawall
2020-01-09 12:04 ` Julia Lawall
2020-01-09 12:14 ` Markus Elfring
2020-01-09 12:14 ` [Cocci] " Markus Elfring
2020-01-09 12:14 ` Markus Elfring
2020-01-09 12:17 ` Julia Lawall
2020-01-09 12:17 ` [Cocci] " Julia Lawall
2020-01-09 12:17 ` Julia Lawall
2020-01-09 12:21 ` Markus Elfring
2020-01-09 12:21 ` [Cocci] " Markus Elfring
2020-01-09 12:21 ` Markus Elfring
2020-01-10 10:00 ` [PATCH v2] " Markus Elfring
2020-01-10 10:00 ` [Cocci] " Markus Elfring
2020-01-10 10:00 ` Markus Elfring
2020-01-10 12:34 ` Julia Lawall
2020-01-10 12:34 ` [Cocci] " Julia Lawall
2020-01-10 12:34 ` Julia Lawall
2020-01-10 15:46 ` [v2] coccinelle: semantic code search " Markus Elfring
2020-01-10 15:46 ` [Cocci] " Markus Elfring
2020-01-10 15:46 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001091140380.10786@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=tglx@linutronix.de \
--cc=wenyang@linux.alibaba.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.