From: Julia Lawall <julia.lawall@inria.fr> To: Jaskaran Singh <jaskaransingh7654321@gmail.com> Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Cocci] [PATCH v5 0/3] cocci: Align the C AST and Cocci AST for pointer Date: Wed, 12 Feb 2020 21:26:29 +0100 (CET) [thread overview] Message-ID: <alpine.DEB.2.21.2002122126000.2594@hadrien> (raw) In-Reply-To: <20200211140137.2304-1-jaskaransingh7654321@gmail.com> On Tue, 11 Feb 2020, Jaskaran Singh wrote: > This series is to address the type matching problem in Coccinelle. > > Patch 1/3 is for aligning the C and Cocci AST so that > pointer to const pointer and its variants can be matched. > > Patch 2/3 reflects the pretty printing changes made in > 1/3 in the ptrconstptr test case. A space is added between > the * and const. > > Patch 3/3 consists of a test case for matching a pointer to > const pointer and its variants. All applied, thanks. julia > > Changes in v5: > -------------- > - Remove unnecessary parantheses and return of unit in Patch 1/3. > - Have the test case in Patch 3/3 conform more closely with the > Linux kernel coding style. > > Changes in v4: > -------------- > - Fix coding style w/r/t placement of comment with List.iter and > the qualifier printing function. > > Changes in v3: > -------------- > - Add a space between the * and qualifier in Patch 1/3. > - Add Patch 2/3 to add a space between * and const in the test > case ptrconstptr. > > Changes in v2: > -------------- > - Change body and subject of Patch 2/2 as per suggestion of Markus > Elfring. > > [PATCH v5 1/3] parsing_c: Align C AST and Cocci AST for pointer > [PATCH v5 2/3] tests: Add space between * and const in > [PATCH v5 3/3] tests: Add test case to match const pointer variants > > parsing_c/parser_c.mly | 4 ++-- > parsing_c/pretty_print_c.ml | 15 ++++++++++----- > tests/constptr.c | 7 +++++++ > tests/constptr.cocci | 19 +++++++++++++++++++ > tests/constptr.res | 7 +++++++ > tests/ptrconstptr.res | 2 +- > 6 files changed, 46 insertions(+), 8 deletions(-) > > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr> To: Jaskaran Singh <jaskaransingh7654321@gmail.com> Cc: linux-kernel-mentees@lists.linuxfoundation.org, cocci@systeme.lip6.fr Subject: Re: [Linux-kernel-mentees] [PATCH v5 0/3] cocci: Align the C AST and Cocci AST for pointer Date: Wed, 12 Feb 2020 21:26:29 +0100 (CET) [thread overview] Message-ID: <alpine.DEB.2.21.2002122126000.2594@hadrien> (raw) In-Reply-To: <20200211140137.2304-1-jaskaransingh7654321@gmail.com> On Tue, 11 Feb 2020, Jaskaran Singh wrote: > This series is to address the type matching problem in Coccinelle. > > Patch 1/3 is for aligning the C and Cocci AST so that > pointer to const pointer and its variants can be matched. > > Patch 2/3 reflects the pretty printing changes made in > 1/3 in the ptrconstptr test case. A space is added between > the * and const. > > Patch 3/3 consists of a test case for matching a pointer to > const pointer and its variants. All applied, thanks. julia > > Changes in v5: > -------------- > - Remove unnecessary parantheses and return of unit in Patch 1/3. > - Have the test case in Patch 3/3 conform more closely with the > Linux kernel coding style. > > Changes in v4: > -------------- > - Fix coding style w/r/t placement of comment with List.iter and > the qualifier printing function. > > Changes in v3: > -------------- > - Add a space between the * and qualifier in Patch 1/3. > - Add Patch 2/3 to add a space between * and const in the test > case ptrconstptr. > > Changes in v2: > -------------- > - Change body and subject of Patch 2/2 as per suggestion of Markus > Elfring. > > [PATCH v5 1/3] parsing_c: Align C AST and Cocci AST for pointer > [PATCH v5 2/3] tests: Add space between * and const in > [PATCH v5 3/3] tests: Add test case to match const pointer variants > > parsing_c/parser_c.mly | 4 ++-- > parsing_c/pretty_print_c.ml | 15 ++++++++++----- > tests/constptr.c | 7 +++++++ > tests/constptr.cocci | 19 +++++++++++++++++++ > tests/constptr.res | 7 +++++++ > tests/ptrconstptr.res | 2 +- > 6 files changed, 46 insertions(+), 8 deletions(-) > > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-02-12 20:26 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-11 14:01 [Cocci] [PATCH v5 0/3] cocci: Align the C AST and Cocci AST for pointer Jaskaran Singh 2020-02-11 14:01 ` [Linux-kernel-mentees] " Jaskaran Singh 2020-02-11 14:01 ` [Cocci] [PATCH v5 1/3] parsing_c: Align " Jaskaran Singh 2020-02-11 14:01 ` [Linux-kernel-mentees] " Jaskaran Singh 2020-02-11 14:01 ` [Cocci] [PATCH v5 2/3] tests: Add space between * and const in ptrconstptr.res Jaskaran Singh 2020-02-11 14:01 ` [Linux-kernel-mentees] " Jaskaran Singh 2020-02-11 14:01 ` [Cocci] [PATCH v5 3/3] tests: Add test case to match const pointer variants Jaskaran Singh 2020-02-11 14:01 ` [Linux-kernel-mentees] " Jaskaran Singh 2020-02-12 20:26 ` Julia Lawall [this message] 2020-02-12 20:26 ` [Linux-kernel-mentees] [PATCH v5 0/3] cocci: Align the C AST and Cocci AST for pointer Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.21.2002122126000.2594@hadrien \ --to=julia.lawall@inria.fr \ --cc=cocci@systeme.lip6.fr \ --cc=jaskaransingh7654321@gmail.com \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.