From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: SOF: intel: Fix probe error without i915 graphics
Date: Mon, 17 Feb 2020 11:11:59 +0200 (EET) [thread overview]
Message-ID: <alpine.DEB.2.21.2002171058360.2957@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <20200216203516.10869-1-tiwai@suse.de>
Hi Takashi,
On Sun, 16 Feb 2020, Takashi Iwai wrote:
> When the driver is configured with CONFIG_SND_SOC_SOF_HDA, the SOF
> driver tries to bind with i915 audio component. But there is also a
> system without Intel graphics. On such a system, snd_hdac_i915_init()
> returns -ENODEV error and it leads to the whole probe error of SOF
> driver.
d'oh -- I was a bit too late with this. I've been working on the bug for a
while and a work in progress patch has been available in the bug for a
couple of weeks:
https://github.com/thesofproject/linux/issues/1658
https://github.com/thesofproject/linux/pull/1731
.. there have been multiple issues, so that the patchset has taken
multiple rounds, but it's very close now. Probably should have added
something in the other bugtrackers as well to avoid duplicated efforts.
With my patchset, if i915 is not present or the init fails, only the idisp
codec is dropped and the probe continues for other codecs.
Your patch will partly conflict with mine as I rely on i915_init to
report failure in this case. Ok if we wait until my patch gets in?
Br, Kai
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-17 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 20:35 [alsa-devel] [PATCH] ASoC: SOF: intel: Fix probe error without i915 graphics Takashi Iwai
2020-02-17 9:11 ` Kai Vehmanen [this message]
2020-02-17 9:17 ` Takashi Iwai
2020-02-17 9:45 ` Kai Vehmanen
2020-02-17 13:17 ` Kai Vehmanen
2020-02-17 13:55 ` Takashi Iwai
2020-02-17 14:21 ` Kai Vehmanen
2020-02-17 14:25 ` Takashi Iwai
2020-02-18 11:12 ` Kai Vehmanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2002171058360.2957@eliteleevi.tm.intel.com \
--to=kai.vehmanen@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.