Re: [alsa-devel] [PATCH] ASoC: SOF: intel: Fix probe error without i915 graphics

[Takashi Iwai <tiwai@suse.de>]

On Mon, 17 Feb 2020 10:11:59 +0100,
Kai Vehmanen wrote:
> 
> Hi Takashi,
> 
> On Sun, 16 Feb 2020, Takashi Iwai wrote:
> 
> > When the driver is configured with CONFIG_SND_SOC_SOF_HDA, the SOF
> > driver tries to bind with i915 audio component.  But there is also a
> > system without Intel graphics.  On such a system, snd_hdac_i915_init()
> > returns -ENODEV error and it leads to the whole probe error of SOF
> > driver.
> 
> d'oh -- I was a bit too late with this. I've been working on the bug for a 
> while and a work in progress patch has been available in the bug for a 
> couple of weeks: 
> https://github.com/thesofproject/linux/issues/1658 
> https://github.com/thesofproject/linux/pull/1731
> 
> .. there have been multiple issues, so that the patchset has taken 
> multiple rounds, but it's very close now. Probably should have added 
> something in the other bugtrackers as well to avoid duplicated efforts.
> 
> With my patchset, if i915 is not present or the init fails, only the idisp 
> codec is dropped and the probe continues for other codecs.
> 
> Your patch will partly conflict with mine as I rely on i915_init to 
> report failure in this case. Ok if we wait until my patch gets in? 

Sure, mine is just a quick fix.  If there is already a work on it,
let's take it instead.

But, this HP machine still seems broken even after ignoring i915, so
we'd need more work in anyway?


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel