* [PATCH] staging: rtl8712: Avoid multiple line dereference
@ 2020-03-20 9:14 Gokce Kuler
2020-03-20 13:41 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Gokce Kuler @ 2020-03-20 9:14 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
merge a line -> with a line ending with a sign
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 74dac74..7d5a50a 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -1094,8 +1094,7 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
src_ssid = pmlmepriv->assoc_bssid;
if (!memcmp(dst_ssid, src_ssid, ETH_ALEN)) {
if (check_fwstate(pmlmepriv, _FW_LINKED)) {
- if (is_same_network(&pmlmepriv->
- cur_network.network,
+ if (is_same_network(&pmlmepriv->cur_network.network,
&pnetwork->network)) {
_clr_fwstate_(pmlmepriv,
_FW_UNDER_LINKING);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: rtl8712: Avoid multiple line dereference
2020-03-20 9:14 [PATCH] staging: rtl8712: Avoid multiple line dereference Gokce Kuler
@ 2020-03-20 13:41 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2020-03-20 13:41 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, gregkh
On Fri, 20 Mar 2020, Gokce Kuler wrote:
> merge a line -> with a line ending with a sign
>
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index 74dac74..7d5a50a 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -1094,8 +1094,7 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
> src_ssid = pmlmepriv->assoc_bssid;
> if (!memcmp(dst_ssid, src_ssid, ETH_ALEN)) {
> if (check_fwstate(pmlmepriv, _FW_LINKED)) {
> - if (is_same_network(&pmlmepriv->
> - cur_network.network,
> + if (is_same_network(&pmlmepriv->cur_network.network,
> &pnetwork->network)) {
It's not really ideal to have the second argument so far to the left like
this. It should be aligned with the right side of the ( after
is_same_network.
julia
> _clr_fwstate_(pmlmepriv,
> _FW_UNDER_LINKING);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200320091413.GA6302%40siyah2.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-20 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-20 9:14 [PATCH] staging: rtl8712: Avoid multiple line dereference Gokce Kuler
2020-03-20 13:41 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.