* [PATCH -next] xen/pvcalls: Make pvcalls_back_global static
@ 2020-04-10 11:56 ` YueHaibing
0 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2020-04-10 11:56 UTC (permalink / raw)
To: boris.ostrovsky, jgross, sstabellini; +Cc: xen-devel, linux-kernel, YueHaibing
Fix sparse warning:
drivers/xen/pvcalls-back.c:30:3: warning:
symbol 'pvcalls_back_global' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/xen/pvcalls-back.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index cf4ce3e9358d..4807704f8d69 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -24,7 +24,7 @@
#define PVCALLS_VERSIONS "1"
#define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
-struct pvcalls_back_global {
+static struct pvcalls_back_global {
struct list_head frontends;
struct semaphore frontends_lock;
} pvcalls_back_global;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] xen/pvcalls: Make pvcalls_back_global static
@ 2020-04-10 11:56 ` YueHaibing
0 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2020-04-10 11:56 UTC (permalink / raw)
To: boris.ostrovsky, jgross, sstabellini; +Cc: xen-devel, YueHaibing, linux-kernel
Fix sparse warning:
drivers/xen/pvcalls-back.c:30:3: warning:
symbol 'pvcalls_back_global' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/xen/pvcalls-back.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index cf4ce3e9358d..4807704f8d69 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -24,7 +24,7 @@
#define PVCALLS_VERSIONS "1"
#define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
-struct pvcalls_back_global {
+static struct pvcalls_back_global {
struct list_head frontends;
struct semaphore frontends_lock;
} pvcalls_back_global;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] xen/pvcalls: Make pvcalls_back_global static
2020-04-10 11:56 ` YueHaibing
@ 2020-04-10 15:24 ` Stefano Stabellini
-1 siblings, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2020-04-10 15:24 UTC (permalink / raw)
To: YueHaibing; +Cc: boris.ostrovsky, jgross, sstabellini, xen-devel, linux-kernel
On Fri, 10 Apr 2020, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/xen/pvcalls-back.c:30:3: warning:
> symbol 'pvcalls_back_global' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> drivers/xen/pvcalls-back.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index cf4ce3e9358d..4807704f8d69 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -24,7 +24,7 @@
> #define PVCALLS_VERSIONS "1"
> #define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
>
> -struct pvcalls_back_global {
> +static struct pvcalls_back_global {
> struct list_head frontends;
> struct semaphore frontends_lock;
> } pvcalls_back_global;
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] xen/pvcalls: Make pvcalls_back_global static
@ 2020-04-10 15:24 ` Stefano Stabellini
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2020-04-10 15:24 UTC (permalink / raw)
To: YueHaibing; +Cc: jgross, xen-devel, boris.ostrovsky, sstabellini, linux-kernel
On Fri, 10 Apr 2020, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/xen/pvcalls-back.c:30:3: warning:
> symbol 'pvcalls_back_global' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> drivers/xen/pvcalls-back.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
> index cf4ce3e9358d..4807704f8d69 100644
> --- a/drivers/xen/pvcalls-back.c
> +++ b/drivers/xen/pvcalls-back.c
> @@ -24,7 +24,7 @@
> #define PVCALLS_VERSIONS "1"
> #define MAX_RING_ORDER XENBUS_MAX_RING_GRANT_ORDER
>
> -struct pvcalls_back_global {
> +static struct pvcalls_back_global {
> struct list_head frontends;
> struct semaphore frontends_lock;
> } pvcalls_back_global;
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-10 15:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 11:56 [PATCH -next] xen/pvcalls: Make pvcalls_back_global static YueHaibing
2020-04-10 11:56 ` YueHaibing
2020-04-10 15:24 ` Stefano Stabellini
2020-04-10 15:24 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.