From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Denis Efremov <efremov@linux.com>,
Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coccinelle: api: add kvfree script
Date: Sat, 6 Jun 2020 09:46:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2006060944320.2578@hadrien> (raw)
In-Reply-To: <99ed463c-b7ba-0400-7cf7-5bcc1992baef@web.de>
> > + E = \(kmalloc@kok\|kzalloc@kok\|krealloc@kok\|kcalloc@kok\|kmalloc_node@kok\|kzalloc_node@kok\|kmalloc_array@kok\|kmalloc_array_node@kok\|kcalloc_node@kok\)(...)
>
> I would prefer an other coding style here.
>
> * Items for such SmPL disjunctions can be specified also on multiple lines.
>
> * The semantic patch language supports further means to handle function name lists
> in more convenient ways.
> Would you like to work with customised constraints?
Please don't follow this advice. Coccinelle is not able to optimize its
search process according to the information in constraints. It will
needlessly parse many files.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Michal Marek <michal.lkml@markovi.net>,
Julia Lawall <Julia.Lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [PATCH] coccinelle: api: add kvfree script
Date: Sat, 06 Jun 2020 07:46:27 +0000 [thread overview]
Message-ID: <alpine.DEB.2.21.2006060944320.2578@hadrien> (raw)
In-Reply-To: <99ed463c-b7ba-0400-7cf7-5bcc1992baef@web.de>
> > + E = \(kmalloc@kok\|kzalloc@kok\|krealloc@kok\|kcalloc@kok\|kmalloc_node@kok\|kzalloc_node@kok\|kmalloc_array@kok\|kmalloc_array_node@kok\|kcalloc_node@kok\)(...)
>
> I would prefer an other coding style here.
>
> * Items for such SmPL disjunctions can be specified also on multiple lines.
>
> * The semantic patch language supports further means to handle function name lists
> in more convenient ways.
> Would you like to work with customised constraints?
Please don't follow this advice. Coccinelle is not able to optimize its
search process according to the information in constraints. It will
needlessly parse many files.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Michal Marek <michal.lkml@markovi.net>,
Julia Lawall <Julia.Lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [PATCH] coccinelle: api: add kvfree script
Date: Sat, 6 Jun 2020 09:46:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2006060944320.2578@hadrien> (raw)
In-Reply-To: <99ed463c-b7ba-0400-7cf7-5bcc1992baef@web.de>
> > + E = \(kmalloc@kok\|kzalloc@kok\|krealloc@kok\|kcalloc@kok\|kmalloc_node@kok\|kzalloc_node@kok\|kmalloc_array@kok\|kmalloc_array_node@kok\|kcalloc_node@kok\)(...)
>
> I would prefer an other coding style here.
>
> * Items for such SmPL disjunctions can be specified also on multiple lines.
>
> * The semantic patch language supports further means to handle function name lists
> in more convenient ways.
> Would you like to work with customised constraints?
Please don't follow this advice. Coccinelle is not able to optimize its
search process according to the information in constraints. It will
needlessly parse many files.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-06-06 7:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 7:30 [PATCH] coccinelle: api: add kvfree script Markus Elfring
2020-06-06 7:30 ` [Cocci] " Markus Elfring
2020-06-06 7:30 ` Markus Elfring
2020-06-06 7:46 ` Julia Lawall [this message]
2020-06-06 7:46 ` [Cocci] " Julia Lawall
2020-06-06 7:46 ` Julia Lawall
2020-06-06 9:50 ` Markus Elfring
2020-06-06 9:50 ` [Cocci] " Markus Elfring
2020-06-06 9:50 ` Markus Elfring
2020-06-07 14:02 ` Coccinelle: Extending capabilities for source file pre-selection Markus Elfring
2020-06-07 14:02 ` [Cocci] " Markus Elfring
2020-06-07 14:02 ` Markus Elfring
2020-06-06 11:06 ` coccinelle: api: add kvfree script Markus Elfring
2020-06-06 11:06 ` [Cocci] " Markus Elfring
2020-06-06 11:06 ` Markus Elfring
2020-06-06 11:11 ` Julia Lawall
2020-06-06 11:11 ` [Cocci] " Julia Lawall
2020-06-06 11:11 ` Julia Lawall
2020-06-06 11:21 ` Markus Elfring
2020-06-06 11:21 ` [Cocci] " Markus Elfring
2020-06-06 11:21 ` Markus Elfring
2020-06-07 6:42 ` Coccinelle: Improving software components around usage of SmPL disjunctions Markus Elfring
2020-06-07 6:42 ` [Cocci] " Markus Elfring
2020-06-07 6:42 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-06-06 14:04 [PATCH] coccinelle: api: add kvfree script Markus Elfring
2020-06-06 14:04 ` [Cocci] " Markus Elfring
2020-06-06 14:04 ` Markus Elfring
2020-06-06 14:39 ` Julia Lawall
2020-06-06 14:39 ` [Cocci] " Julia Lawall
2020-06-06 14:39 ` Julia Lawall
2020-06-06 15:10 ` Markus Elfring
2020-06-06 15:10 ` [Cocci] " Markus Elfring
2020-06-06 15:10 ` Markus Elfring
2020-06-05 20:42 [PATCH] " Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2006060944320.2578@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.