All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"jgross@suse.com" <jgross@suse.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH] xen: introduce xen_vring_use_dma
Date: Mon, 29 Jun 2020 16:49:07 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2006291647450.8121@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <DB6PR0402MB27601CA74B85DA5A9F5E5DD6886E0@DB6PR0402MB2760.eurprd04.prod.outlook.com>

On Mon, 29 Jun 2020, Peng Fan wrote:
> > > If that is the case, how is it possible that virtio breaks on ARM
> > > using the default dma_ops? The breakage is not Xen related (except
> > > that Xen turns dma_ops on). The original message from Peng was:
> > >
> > >   vring_map_one_sg -> vring_use_dma_api
> > >                    -> dma_map_page
> > >   		       -> __swiotlb_map_page
> > >   		                ->swiotlb_map_page
> > >   				->__dma_map_area(phys_to_virt(dma_to_phys(dev,
> > dev_addr)), size, dir);
> > >   However we are using per device dma area for rpmsg, phys_to_virt
> > >   could not return a correct virtual address for virtual address in
> > >   vmalloc area. Then kernel panic.
> > >
> > > I must be missing something. Maybe it is because it has to do with RPMesg?
> > 
> > I think it's an RPMesg bug, yes
> 
> rpmsg bug is another issue, it should not use dma_alloc_coherent for reserved area,
> and use vmalloc_to_page.
> 
> Anyway here using dma api will also trigger issue.

Is the stack trace above for the RPMesg issue or for the Trusty issue?
If it is the stack trace for RPMesg, can you also post the Trusty stack
trace? Or are they indentical?

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "jgross@suse.com" <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] xen: introduce xen_vring_use_dma
Date: Mon, 29 Jun 2020 16:49:07 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2006291647450.8121@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <DB6PR0402MB27601CA74B85DA5A9F5E5DD6886E0@DB6PR0402MB2760.eurprd04.prod.outlook.com>

On Mon, 29 Jun 2020, Peng Fan wrote:
> > > If that is the case, how is it possible that virtio breaks on ARM
> > > using the default dma_ops? The breakage is not Xen related (except
> > > that Xen turns dma_ops on). The original message from Peng was:
> > >
> > >   vring_map_one_sg -> vring_use_dma_api
> > >                    -> dma_map_page
> > >   		       -> __swiotlb_map_page
> > >   		                ->swiotlb_map_page
> > >   				->__dma_map_area(phys_to_virt(dma_to_phys(dev,
> > dev_addr)), size, dir);
> > >   However we are using per device dma area for rpmsg, phys_to_virt
> > >   could not return a correct virtual address for virtual address in
> > >   vmalloc area. Then kernel panic.
> > >
> > > I must be missing something. Maybe it is because it has to do with RPMesg?
> > 
> > I think it's an RPMesg bug, yes
> 
> rpmsg bug is another issue, it should not use dma_alloc_coherent for reserved area,
> and use vmalloc_to_page.
> 
> Anyway here using dma api will also trigger issue.

Is the stack trace above for the RPMesg issue or for the Trusty issue?
If it is the stack trace for RPMesg, can you also post the Trusty stack
trace? Or are they indentical?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "jgross@suse.com" <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] xen: introduce xen_vring_use_dma
Date: Mon, 29 Jun 2020 16:49:07 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2006291647450.8121@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <DB6PR0402MB27601CA74B85DA5A9F5E5DD6886E0@DB6PR0402MB2760.eurprd04.prod.outlook.com>

On Mon, 29 Jun 2020, Peng Fan wrote:
> > > If that is the case, how is it possible that virtio breaks on ARM
> > > using the default dma_ops? The breakage is not Xen related (except
> > > that Xen turns dma_ops on). The original message from Peng was:
> > >
> > >   vring_map_one_sg -> vring_use_dma_api
> > >                    -> dma_map_page
> > >   		       -> __swiotlb_map_page
> > >   		                ->swiotlb_map_page
> > >   				->__dma_map_area(phys_to_virt(dma_to_phys(dev,
> > dev_addr)), size, dir);
> > >   However we are using per device dma area for rpmsg, phys_to_virt
> > >   could not return a correct virtual address for virtual address in
> > >   vmalloc area. Then kernel panic.
> > >
> > > I must be missing something. Maybe it is because it has to do with RPMesg?
> > 
> > I think it's an RPMesg bug, yes
> 
> rpmsg bug is another issue, it should not use dma_alloc_coherent for reserved area,
> and use vmalloc_to_page.
> 
> Anyway here using dma api will also trigger issue.

Is the stack trace above for the RPMesg issue or for the Trusty issue?
If it is the stack trace for RPMesg, can you also post the Trusty stack
trace? Or are they indentical?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "jgross@suse.com" <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] xen: introduce xen_vring_use_dma
Date: Mon, 29 Jun 2020 16:49:07 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2006291647450.8121@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <DB6PR0402MB27601CA74B85DA5A9F5E5DD6886E0@DB6PR0402MB2760.eurprd04.prod.outlook.com>

On Mon, 29 Jun 2020, Peng Fan wrote:
> > > If that is the case, how is it possible that virtio breaks on ARM
> > > using the default dma_ops? The breakage is not Xen related (except
> > > that Xen turns dma_ops on). The original message from Peng was:
> > >
> > >   vring_map_one_sg -> vring_use_dma_api
> > >                    -> dma_map_page
> > >   		       -> __swiotlb_map_page
> > >   		                ->swiotlb_map_page
> > >   				->__dma_map_area(phys_to_virt(dma_to_phys(dev,
> > dev_addr)), size, dir);
> > >   However we are using per device dma area for rpmsg, phys_to_virt
> > >   could not return a correct virtual address for virtual address in
> > >   vmalloc area. Then kernel panic.
> > >
> > > I must be missing something. Maybe it is because it has to do with RPMesg?
> > 
> > I think it's an RPMesg bug, yes
> 
> rpmsg bug is another issue, it should not use dma_alloc_coherent for reserved area,
> and use vmalloc_to_page.
> 
> Anyway here using dma api will also trigger issue.

Is the stack trace above for the RPMesg issue or for the Trusty issue?
If it is the stack trace for RPMesg, can you also post the Trusty stack
trace? Or are they indentical?


  parent reply	other threads:[~2020-06-29 23:49 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24  9:17 [PATCH] xen: introduce xen_vring_use_dma Peng Fan
2020-06-24  9:17 ` Peng Fan
2020-06-24  9:17 ` Peng Fan
2020-06-24  9:17 ` Peng Fan
2020-06-24  9:17 ` Peng Fan
2020-06-24  9:06 ` Michael S. Tsirkin
2020-06-24  9:06   ` Michael S. Tsirkin
2020-06-24  9:06   ` Michael S. Tsirkin
2020-06-24  9:06   ` Michael S. Tsirkin
2020-06-24 17:59   ` Stefano Stabellini
2020-06-24 17:59     ` Stefano Stabellini
2020-06-24 17:59     ` Stefano Stabellini
2020-06-24 17:59     ` Stefano Stabellini
2020-06-24 20:47     ` Michael S. Tsirkin
2020-06-24 20:47       ` Michael S. Tsirkin
2020-06-24 20:47       ` Michael S. Tsirkin
2020-06-24 20:47       ` Michael S. Tsirkin
2020-06-24 20:47       ` Michael S. Tsirkin
2020-06-24 21:53       ` Stefano Stabellini
2020-06-24 21:53         ` Stefano Stabellini
2020-06-24 21:53         ` Stefano Stabellini
2020-06-24 21:53         ` Stefano Stabellini
2020-06-24 22:16         ` Michael S. Tsirkin
2020-06-24 22:16           ` Michael S. Tsirkin
2020-06-24 22:16           ` Michael S. Tsirkin
2020-06-24 22:16           ` Michael S. Tsirkin
2020-06-24 22:16           ` Michael S. Tsirkin
2020-06-25 17:31           ` Stefano Stabellini
2020-06-25 17:31             ` Stefano Stabellini
2020-06-25 17:31             ` Stefano Stabellini
2020-06-25 17:31             ` Stefano Stabellini
2020-06-26 15:32             ` Michael S. Tsirkin
2020-06-26 15:32               ` Michael S. Tsirkin
2020-06-26 15:32               ` Michael S. Tsirkin
2020-06-26 15:32               ` Michael S. Tsirkin
2020-06-26 15:32               ` Michael S. Tsirkin
2020-06-29  3:05               ` Peng Fan
2020-06-29  3:05                 ` Peng Fan
2020-06-29  3:05                 ` Peng Fan
2020-06-29  3:05                 ` Peng Fan
2020-06-29  3:05                 ` Peng Fan
2020-06-29  6:21                 ` Michael S. Tsirkin
2020-06-29  6:21                   ` Michael S. Tsirkin
2020-06-29  6:21                   ` Michael S. Tsirkin
2020-06-29  6:21                   ` Michael S. Tsirkin
2020-06-29  6:21                   ` Michael S. Tsirkin
2020-06-29  6:25                   ` Peng Fan
2020-06-29  6:25                     ` Peng Fan
2020-06-29  6:25                     ` Peng Fan
2020-06-29  6:25                     ` Peng Fan
2020-06-29  6:25                     ` Peng Fan
2020-06-29  6:33                     ` Michael S. Tsirkin
2020-06-29  6:33                       ` Michael S. Tsirkin
2020-06-29  6:33                       ` Michael S. Tsirkin
2020-06-29  6:33                       ` Michael S. Tsirkin
2020-06-29  6:33                       ` Michael S. Tsirkin
2020-06-29  6:35                       ` Peng Fan
2020-06-29  6:35                         ` Peng Fan
2020-06-29  6:35                         ` Peng Fan
2020-06-29  6:35                         ` Peng Fan
2020-06-29  6:35                         ` Peng Fan
2020-06-29 23:49                 ` Stefano Stabellini [this message]
2020-06-29 23:49                   ` Stefano Stabellini
2020-06-29 23:49                   ` Stefano Stabellini
2020-06-29 23:49                   ` Stefano Stabellini
2020-06-29 23:49                   ` Stefano Stabellini
2020-06-30  1:40                   ` Peng Fan
2020-06-30  1:40                     ` Peng Fan
2020-06-30  1:40                     ` Peng Fan
2020-06-30  1:40                     ` Peng Fan
2020-06-30  1:40                     ` Peng Fan
2020-06-29 23:46               ` Stefano Stabellini
2020-06-29 23:46                 ` Stefano Stabellini
2020-06-29 23:46                 ` Stefano Stabellini
2020-06-29 23:46                 ` Stefano Stabellini
2020-07-01 13:34                 ` Christoph Hellwig
2020-07-01 13:34                   ` Christoph Hellwig
2020-07-01 13:34                   ` Christoph Hellwig
2020-07-01 13:34                   ` Christoph Hellwig
2020-07-01 17:34                   ` Stefano Stabellini
2020-07-01 17:34                     ` Stefano Stabellini
2020-07-01 17:34                     ` Stefano Stabellini
2020-07-01 17:34                     ` Stefano Stabellini
2020-07-01 20:47                     ` Michael S. Tsirkin
2020-07-01 20:47                       ` Michael S. Tsirkin
2020-07-01 20:47                       ` Michael S. Tsirkin
2020-07-01 20:47                       ` Michael S. Tsirkin
2020-07-01 20:47                       ` Michael S. Tsirkin
2020-07-01 21:23                     ` Michael S. Tsirkin
2020-07-01 21:23                       ` Michael S. Tsirkin
2020-07-01 21:23                       ` Michael S. Tsirkin
2020-07-01 21:23                       ` Michael S. Tsirkin
2020-07-10 17:23                       ` Stefano Stabellini
2020-07-10 17:23                         ` Stefano Stabellini
2020-07-10 17:23                         ` Stefano Stabellini
2020-07-10 17:23                         ` Stefano Stabellini
2020-07-11 18:44                         ` Michael S. Tsirkin
2020-07-11 18:44                           ` Michael S. Tsirkin
2020-07-11 18:44                           ` Michael S. Tsirkin
2020-07-11 18:44                           ` Michael S. Tsirkin
2020-07-15 17:06                           ` Stefano Stabellini
2020-07-15 17:06                             ` Stefano Stabellini
2020-07-15 17:06                             ` Stefano Stabellini
2020-07-15 17:06                             ` Stefano Stabellini
2020-07-13  1:53                         ` Peng Fan
2020-07-13  1:53                           ` Peng Fan
2020-07-13  1:53                           ` Peng Fan
2020-07-13  1:53                           ` Peng Fan
2020-06-29  3:00             ` Peng Fan
2020-06-29  3:00               ` Peng Fan
2020-06-29  3:00               ` Peng Fan
2020-06-29  3:00               ` Peng Fan
2020-06-29  3:00               ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2006291647450.8121@sstabellini-ThinkPad-T480s \
    --to=sstabellini@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jasowang@redhat.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=peng.fan@nxp.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.