All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: Ben Levinsky <ben.levinsky@xilinx.com>,
	stefanos@xilinx.com, michals@xilinx.com, michael.auchter@ni.com,
	devicetree@vger.kernel.org, mathieu.poirier@linaro.org,
	emooring@xilinx.com, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Jason Wu <j.wu@xilinx.com>,
	Wendy Liang <jliang@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings
Date: Wed, 30 Sep 2020 15:40:08 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2009301536490.10908@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20200929183601.GA892636@bogus>

On Tue, 29 Sep 2020, Rob Herring wrote:
> > index 000000000000..ce02e425692e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
> > @@ -0,0 +1,120 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Xilinx R5 remote processor controller bindings
> > +
> > +description:
> > +  This document defines the binding for the remoteproc component that loads and
> > +  boots firmwares on the Xilinx Zynqmp and Versal family chipset.
> > +
> > +  Note that the Linux has global addressing view of the R5-related memory (TCM)
> > +  so the absolute address ranges are provided in TCM reg's.
> 
> blank line needed.
> 
> TCMs specifically I'm concerned about how they are represented in system 
> DT and here...

So far I have been keeping the TCMs in system DT as regular nodes under
/amba. E.g.:

		tcm: tcm@ffe00000 {
			compatible = "mmio-sram";
			reg = <0x0 0xffe00000 0x0 0x10000>;
		};

(I am not sure if "mmio-sram" is the right compatible.)

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: stefanos@xilinx.com, emooring@xilinx.com, michael.auchter@ni.com,
	mathieu.poirier@linaro.org, devicetree@vger.kernel.org,
	Ben Levinsky <ben.levinsky@xilinx.com>,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wendy Liang <jliang@xilinx.com>,
	michals@xilinx.com, Jason Wu <j.wu@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings
Date: Wed, 30 Sep 2020 15:40:08 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2009301536490.10908@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20200929183601.GA892636@bogus>

On Tue, 29 Sep 2020, Rob Herring wrote:
> > index 000000000000..ce02e425692e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml
> > @@ -0,0 +1,120 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Xilinx R5 remote processor controller bindings
> > +
> > +description:
> > +  This document defines the binding for the remoteproc component that loads and
> > +  boots firmwares on the Xilinx Zynqmp and Versal family chipset.
> > +
> > +  Note that the Linux has global addressing view of the R5-related memory (TCM)
> > +  so the absolute address ranges are provided in TCM reg's.
> 
> blank line needed.
> 
> TCMs specifically I'm concerned about how they are represented in system 
> DT and here...

So far I have been keeping the TCMs in system DT as regular nodes under
/amba. E.g.:

		tcm: tcm@ffe00000 {
			compatible = "mmio-sram";
			reg = <0x0 0xffe00000 0x0 0x10000>;
		};

(I am not sure if "mmio-sram" is the right compatible.)

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-09-30 22:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 22:39 [PATCH v16 0/5] Provide basic driver to control Arm R5 co-processor found on Xilinx ZynqMP Ben Levinsky
2020-09-22 22:39 ` Ben Levinsky
2020-09-22 22:39 ` [PATCH v16 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky
2020-09-22 22:39   ` Ben Levinsky
2020-09-22 22:39 ` [PATCH v16 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky
2020-09-22 22:39   ` Ben Levinsky
2020-09-22 22:39 ` [PATCH v16 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky
2020-09-22 22:39   ` Ben Levinsky
2020-09-22 22:39 ` [PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky
2020-09-22 22:39   ` Ben Levinsky
2020-09-29 18:36   ` Rob Herring
2020-09-29 18:36     ` Rob Herring
2020-09-30 16:21     ` Ben Levinsky
2020-09-30 16:21       ` Ben Levinsky
2020-11-05 19:42       ` Rob Herring
2020-11-05 19:42         ` Rob Herring
2020-09-30 22:40     ` Stefano Stabellini [this message]
2020-09-30 22:40       ` Stefano Stabellini
2020-09-22 22:39 ` [PATCH v16 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky
2020-09-22 22:39   ` Ben Levinsky
2020-10-01 11:32   ` kernel test robot
2020-10-01 11:32     ` kernel test robot
2020-10-01 11:32     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2009301536490.10908@sstabellini-ThinkPad-T480s \
    --to=stefano.stabellini@xilinx.com \
    --cc=ben.levinsky@xilinx.com \
    --cc=devicetree@vger.kernel.org \
    --cc=emooring@xilinx.com \
    --cc=j.wu@xilinx.com \
    --cc=jliang@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=michael.auchter@ni.com \
    --cc=michal.simek@xilinx.com \
    --cc=michals@xilinx.com \
    --cc=robh@kernel.org \
    --cc=stefanos@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.