From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Aditya <yashsri421@gmail.com>,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
dwaipayanray1@gmail.com
Subject: Re: [PATCH v3] checkpatch: fix false positives in REPEATED_WORD warning
Date: Sun, 25 Oct 2020 07:11:40 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2010250708050.6697@felia> (raw)
In-Reply-To: <252e2adc7ae9e2886171189f1421e2fe3c33629a.camel@perches.com>
On Sat, 24 Oct 2020, Joe Perches wrote:
> On Sun, 2020-10-25 at 06:51 +0100, Lukas Bulwahn wrote:
> > We can identify a set of rules and clear automatic fixes that
> > maintainers can simply run this script over the patches they pick
> > up when they pick them up.
>
> checkpatch --fix-inplace does that now.
>
> But realistically, this is more an interactive bit that IMO
> should be a separate script on top of checkpatch.
>
Agree, and of course, we can work with some maintainers to find the best
way to combine that into their 'pick up and apply patches' scripts?
E.g., some might be using b4 and we simply hook into that in a friendly
way.
Further just documenting the potential options for maintainer in the
maintainers handbook might also increase adoption.
WARNING: multiple messages have this Message-ID (diff)
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: dwaipayanray1@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, Aditya <yashsri421@gmail.com>
Subject: Re: [Linux-kernel-mentees] [PATCH v3] checkpatch: fix false positives in REPEATED_WORD warning
Date: Sun, 25 Oct 2020 07:11:40 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.2010250708050.6697@felia> (raw)
In-Reply-To: <252e2adc7ae9e2886171189f1421e2fe3c33629a.camel@perches.com>
On Sat, 24 Oct 2020, Joe Perches wrote:
> On Sun, 2020-10-25 at 06:51 +0100, Lukas Bulwahn wrote:
> > We can identify a set of rules and clear automatic fixes that
> > maintainers can simply run this script over the patches they pick
> > up when they pick them up.
>
> checkpatch --fix-inplace does that now.
>
> But realistically, this is more an interactive bit that IMO
> should be a separate script on top of checkpatch.
>
Agree, and of course, we can work with some maintainers to find the best
way to combine that into their 'pick up and apply patches' scripts?
E.g., some might be using b4 and we simply hook into that in a friendly
way.
Further just documenting the potential options for maintainer in the
maintainers handbook might also increase adoption.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-25 6:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 13:38 [PATCH v3] checkpatch: fix false positives in REPEATED_WORD warning Aditya Srivastava
2020-10-23 13:38 ` [Linux-kernel-mentees] " Aditya Srivastava
2020-10-23 19:06 ` Lukas Bulwahn
2020-10-23 19:06 ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-10-23 20:19 ` Joe Perches
2020-10-23 20:19 ` [Linux-kernel-mentees] " Joe Perches
2020-10-24 13:24 ` Aditya
2020-10-24 13:24 ` [Linux-kernel-mentees] " Aditya
2020-10-24 15:33 ` Joe Perches
2020-10-24 15:33 ` [Linux-kernel-mentees] " Joe Perches
2020-10-24 18:12 ` Aditya
2020-10-24 18:12 ` [Linux-kernel-mentees] " Aditya
2020-10-25 5:51 ` Lukas Bulwahn
2020-10-25 5:51 ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-10-25 6:06 ` Joe Perches
2020-10-25 6:06 ` [Linux-kernel-mentees] " Joe Perches
2020-10-25 6:11 ` Lukas Bulwahn [this message]
2020-10-25 6:11 ` Lukas Bulwahn
2020-10-25 10:01 ` Aditya
2020-10-25 10:01 ` [Linux-kernel-mentees] " Aditya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010250708050.6697@felia \
--to=lukas.bulwahn@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.