* Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
@ 2021-03-24 18:59 ` Randy Dunlap
0 siblings, 0 replies; 12+ messages in thread
From: Randy Dunlap @ 2021-03-24 18:59 UTC (permalink / raw)
To: Stefano Stabellini, Bhaskar Chowdhury
Cc: linux, xen-devel, linux-arm-kernel, linux-kernel, jgross,
boris.ostrovsky
On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
>> s/acrros/across/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>
>
Hi,
It seems to me like some of those "page" should be "pages".
>> ---
>> arch/arm/xen/mm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
>> index 467fa225c3d0..be7c942c74bf 100644
>> --- a/arch/arm/xen/mm.c
>> +++ b/arch/arm/xen/mm.c
>> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
>> * - The Linux page refers to foreign memory
>> * - The device doesn't support coherent DMA request
>> *
>> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although
pages,
>> * it's not possible to have a mix of local and foreign Xen page.
pages.
>> * Furthermore, range_straddles_page_boundary is already checking
>> * if buffer is physically contiguous in the host RAM.
>> --
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
2021-03-24 18:59 ` Randy Dunlap
(?)
@ 2021-03-24 19:11 ` Stefano Stabellini
-1 siblings, 0 replies; 12+ messages in thread
From: Stefano Stabellini @ 2021-03-24 19:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stefano Stabellini, Bhaskar Chowdhury, linux, xen-devel,
linux-arm-kernel, linux-kernel, jgross, boris.ostrovsky
On Wed, 24 Mar 2021, Randy Dunlap wrote:
> On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> >> s/acrros/across/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> >
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> >
>
> Hi,
> It seems to me like some of those "page" should be "pages".
Yes, good point actually
> >> ---
> >> arch/arm/xen/mm.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> >> index 467fa225c3d0..be7c942c74bf 100644
> >> --- a/arch/arm/xen/mm.c
> >> +++ b/arch/arm/xen/mm.c
> >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
> >> * - The Linux page refers to foreign memory
> >> * - The device doesn't support coherent DMA request
> >> *
> >> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although
>
> pages,
>
> >> * it's not possible to have a mix of local and foreign Xen page.
>
> pages.
yes to both
> >> * Furthermore, range_straddles_page_boundary is already checking
> >> * if buffer is physically contiguous in the host RAM.
> >> --
>
>
> --
> ~Randy
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
@ 2021-03-24 19:11 ` Stefano Stabellini
0 siblings, 0 replies; 12+ messages in thread
From: Stefano Stabellini @ 2021-03-24 19:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stefano Stabellini, Bhaskar Chowdhury, linux, xen-devel,
linux-arm-kernel, linux-kernel, jgross, boris.ostrovsky
On Wed, 24 Mar 2021, Randy Dunlap wrote:
> On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> >> s/acrros/across/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> >
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> >
>
> Hi,
> It seems to me like some of those "page" should be "pages".
Yes, good point actually
> >> ---
> >> arch/arm/xen/mm.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> >> index 467fa225c3d0..be7c942c74bf 100644
> >> --- a/arch/arm/xen/mm.c
> >> +++ b/arch/arm/xen/mm.c
> >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
> >> * - The Linux page refers to foreign memory
> >> * - The device doesn't support coherent DMA request
> >> *
> >> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although
>
> pages,
>
> >> * it's not possible to have a mix of local and foreign Xen page.
>
> pages.
yes to both
> >> * Furthermore, range_straddles_page_boundary is already checking
> >> * if buffer is physically contiguous in the host RAM.
> >> --
>
>
> --
> ~Randy
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
@ 2021-03-24 19:11 ` Stefano Stabellini
0 siblings, 0 replies; 12+ messages in thread
From: Stefano Stabellini @ 2021-03-24 19:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stefano Stabellini, Bhaskar Chowdhury, linux, xen-devel,
linux-arm-kernel, linux-kernel, jgross, boris.ostrovsky
On Wed, 24 Mar 2021, Randy Dunlap wrote:
> On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> >> s/acrros/across/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> >
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> >
>
> Hi,
> It seems to me like some of those "page" should be "pages".
Yes, good point actually
> >> ---
> >> arch/arm/xen/mm.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> >> index 467fa225c3d0..be7c942c74bf 100644
> >> --- a/arch/arm/xen/mm.c
> >> +++ b/arch/arm/xen/mm.c
> >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
> >> * - The Linux page refers to foreign memory
> >> * - The device doesn't support coherent DMA request
> >> *
> >> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although
>
> pages,
>
> >> * it's not possible to have a mix of local and foreign Xen page.
>
> pages.
yes to both
> >> * Furthermore, range_straddles_page_boundary is already checking
> >> * if buffer is physically contiguous in the host RAM.
> >> --
>
>
> --
> ~Randy
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
2021-03-24 18:59 ` Randy Dunlap
@ 2021-03-25 4:37 ` Bhaskar Chowdhury
-1 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-25 4:37 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stefano Stabellini, linux, xen-devel, linux-arm-kernel,
linux-kernel, jgross, boris.ostrovsky
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
On 11:59 Wed 24 Mar 2021, Randy Dunlap wrote:
>On 3/24/21 11:55 AM, Stefano Stabellini wrote:
>> On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
>>> s/acrros/across/
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>>
>
>Hi,
>It seems to me like some of those "page" should be "pages".
>
>>> ---
>>> arch/arm/xen/mm.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
>>> index 467fa225c3d0..be7c942c74bf 100644
>>> --- a/arch/arm/xen/mm.c
>>> +++ b/arch/arm/xen/mm.c
>>> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
>>> * - The Linux page refers to foreign memory
>>> * - The device doesn't support coherent DMA request
>>> *
>>> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although
>
> pages,
>
>>> * it's not possible to have a mix of local and foreign Xen page.
>
> pages.
>
>>> * Furthermore, range_straddles_page_boundary is already checking
>>> * if buffer is physically contiguous in the host RAM.
>>> --
>
Thank you....I have sent a V2 now.
>
>
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
@ 2021-03-25 4:37 ` Bhaskar Chowdhury
0 siblings, 0 replies; 12+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-25 4:37 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stefano Stabellini, linux, xen-devel, linux-arm-kernel,
linux-kernel, jgross, boris.ostrovsky
[-- Attachment #1.1: Type: text/plain, Size: 1354 bytes --]
On 11:59 Wed 24 Mar 2021, Randy Dunlap wrote:
>On 3/24/21 11:55 AM, Stefano Stabellini wrote:
>> On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
>>> s/acrros/across/
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>
>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>>
>>
>
>Hi,
>It seems to me like some of those "page" should be "pages".
>
>>> ---
>>> arch/arm/xen/mm.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
>>> index 467fa225c3d0..be7c942c74bf 100644
>>> --- a/arch/arm/xen/mm.c
>>> +++ b/arch/arm/xen/mm.c
>>> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
>>> * - The Linux page refers to foreign memory
>>> * - The device doesn't support coherent DMA request
>>> *
>>> - * The Linux page may be spanned acrros multiple Xen page, although>> + * The Linux page may be spanned across multiple Xen page, although
>
> pages,
>
>>> * it's not possible to have a mix of local and foreign Xen page.
>
> pages.
>
>>> * Furthermore, range_straddles_page_boundary is already checking
>>> * if buffer is physically contiguous in the host RAM.
>>> --
>
Thank you....I have sent a V2 now.
>
>
>~Randy
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread