All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: alex@ghiti.fr, Paul Walmsley <paul.walmsley@sifive.com>,
	dvyukov@google.com, linux-api@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024
Date: Tue, 30 Mar 2021 22:31:45 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2103302221590.18977@angie.orcam.me.uk> (raw)
In-Reply-To: <mhng-885e3a79-49cf-42fc-8561-a52c7b7e1ac6@palmerdabbelt-glaptop>

On Mon, 29 Mar 2021, Palmer Dabbelt wrote:

> > --- /dev/null
> > +++ b/arch/riscv/include/uapi/asm/setup.h
> > @@ -0,0 +1,8 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> > +
> > +#ifndef _UAPI_ASM_RISCV_SETUP_H
> > +#define _UAPI_ASM_RISCV_SETUP_H
> > +
> > +#define COMMAND_LINE_SIZE	1024
> > +
> > +#endif /* _UAPI_ASM_RISCV_SETUP_H */
> 
> I put this on fixes, but it seemes like this should really be a Kconfig
> enttry.  Either way, ours was quite a bit smaller than most architectures and
> it's great that syzbot has started to find bugs, so I'd rather get this in
> sooner.

 This macro is exported as a part of the user API so it must not depend on 
Kconfig.  Also changing it (rather than say adding COMMAND_LINE_SIZE_V2 or 
switching to an entirely new data object that has its dimension set in a 
different way) requires careful evaluation as external binaries have and 
will have the value it expands to compiled in, so it's a part of the ABI 
too.

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: alex@ghiti.fr, Paul Walmsley <paul.walmsley@sifive.com>,
	 dvyukov@google.com, linux-api@vger.kernel.org,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024
Date: Tue, 30 Mar 2021 22:31:45 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2103302221590.18977@angie.orcam.me.uk> (raw)
In-Reply-To: <mhng-885e3a79-49cf-42fc-8561-a52c7b7e1ac6@palmerdabbelt-glaptop>

On Mon, 29 Mar 2021, Palmer Dabbelt wrote:

> > --- /dev/null
> > +++ b/arch/riscv/include/uapi/asm/setup.h
> > @@ -0,0 +1,8 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
> > +
> > +#ifndef _UAPI_ASM_RISCV_SETUP_H
> > +#define _UAPI_ASM_RISCV_SETUP_H
> > +
> > +#define COMMAND_LINE_SIZE	1024
> > +
> > +#endif /* _UAPI_ASM_RISCV_SETUP_H */
> 
> I put this on fixes, but it seemes like this should really be a Kconfig
> enttry.  Either way, ours was quite a bit smaller than most architectures and
> it's great that syzbot has started to find bugs, so I'd rather get this in
> sooner.

 This macro is exported as a part of the user API so it must not depend on 
Kconfig.  Also changing it (rather than say adding COMMAND_LINE_SIZE_V2 or 
switching to an entirely new data object that has its dimension set in a 
different way) requires careful evaluation as external binaries have and 
will have the value it expands to compiled in, so it's a part of the ABI 
too.

  Maciej

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2021-03-30 20:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 19:34 [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024 Alexandre Ghiti
2021-03-16 19:34 ` Alexandre Ghiti
2021-03-30  5:07 ` Palmer Dabbelt
2021-03-30  5:07   ` Palmer Dabbelt
2021-03-30 20:31   ` Maciej W. Rozycki [this message]
2021-03-30 20:31     ` Maciej W. Rozycki
2021-04-02  4:37     ` Palmer Dabbelt
2021-04-02  4:37       ` Palmer Dabbelt
2021-04-02  8:40       ` Dmitry Vyukov
2021-04-02  8:40         ` Dmitry Vyukov
2021-04-02  8:58         ` David Abdurachmanov
2021-04-02  8:58           ` David Abdurachmanov
2021-04-02 18:33           ` Maciej W. Rozycki
2021-04-02 18:33             ` Maciej W. Rozycki
2021-04-23  2:57             ` Palmer Dabbelt
2021-04-23  2:57               ` Palmer Dabbelt
2021-06-21  7:11               ` Alex Ghiti
2021-06-21  7:11                 ` Alex Ghiti
2022-11-10 21:01                 ` Dmitry Vyukov
2022-11-10 21:01                   ` Dmitry Vyukov
2023-02-09 11:37                   ` Dmitry Vyukov
2023-02-09 11:37                     ` Dmitry Vyukov
2023-02-09 19:30                     ` Alex Ghiti
2023-02-09 19:30                       ` Alex Ghiti
2023-03-02  3:17 ` Palmer Dabbelt
2023-03-02  3:17   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2103302221590.18977@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=alex@ghiti.fr \
    --cc=dvyukov@google.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.