From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel@ffwll.ch>,
syzbot <syzbot+1f29e126cf461c4de3b3@syzkaller.appspotmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Colin King <colin.king@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jani Nikula <jani.nikula@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
"Antonino A. Daplas" <adaplas@gmail.com>
Subject: Re: [PATCH v2] tty: vt: always invoke vc->vc_sw->con_resize callback
Date: Sat, 15 May 2021 18:21:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2105151815040.3032@angie.orcam.me.uk> (raw)
In-Reply-To: <97f1d292-c3a8-f4d6-0651-b4f5571ecb72@i-love.sakura.ne.jp>
On Sat, 15 May 2021, Tetsuo Handa wrote:
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 3406067985b1..22bb3892f6bd 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -2019,7 +2019,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width,
> return -EINVAL;
>
> pr_debug("resize now %ix%i\n", var.xres, var.yres);
> - if (con_is_visible(vc)) {
> + if (con_is_visible(vc) && vc->vc_mode == KD_TEXT) {
> var.activate = FB_ACTIVATE_NOW |
> FB_ACTIVATE_FORCE;
> fb_set_var(info, &var);
LGTM, although I'll yet try to verify it with hardware. But it'll have
to wait another week or so as I'm currently away from my lab and this
requires physical presence.
Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>
Maciej
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jani Nikula <jani.nikula@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Colin King <colin.king@canonical.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
syzbot <syzbot+1f29e126cf461c4de3b3@syzkaller.appspotmail.com>
Subject: Re: [PATCH v2] tty: vt: always invoke vc->vc_sw->con_resize callback
Date: Sat, 15 May 2021 18:21:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2105151815040.3032@angie.orcam.me.uk> (raw)
In-Reply-To: <97f1d292-c3a8-f4d6-0651-b4f5571ecb72@i-love.sakura.ne.jp>
On Sat, 15 May 2021, Tetsuo Handa wrote:
> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> index 3406067985b1..22bb3892f6bd 100644
> --- a/drivers/video/fbdev/core/fbcon.c
> +++ b/drivers/video/fbdev/core/fbcon.c
> @@ -2019,7 +2019,7 @@ static int fbcon_resize(struct vc_data *vc, unsigned int width,
> return -EINVAL;
>
> pr_debug("resize now %ix%i\n", var.xres, var.yres);
> - if (con_is_visible(vc)) {
> + if (con_is_visible(vc) && vc->vc_mode == KD_TEXT) {
> var.activate = FB_ACTIVATE_NOW |
> FB_ACTIVATE_FORCE;
> fb_set_var(info, &var);
LGTM, although I'll yet try to verify it with hardware. But it'll have
to wait another week or so as I'm currently away from my lab and this
requires physical presence.
Reviewed-by: Maciej W. Rozycki <macro@orcam.me.uk>
Maciej
next prev parent reply other threads:[~2021-05-15 16:21 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 7:07 BUG: unable to handle kernel paging request in vga16fb_imageblit (2) syzbot
2020-05-08 7:07 ` syzbot
2020-05-08 7:07 ` syzbot
2021-05-01 20:31 ` [syzbot] " syzbot
2021-05-01 20:31 ` syzbot
2021-05-02 1:53 ` syzbot
2021-05-02 1:53 ` syzbot
2021-05-03 13:41 ` Tetsuo Handa
2021-05-03 13:41 ` Tetsuo Handa
2021-05-07 11:09 ` Tetsuo Handa
2021-05-14 16:19 ` [PATCH] video: fbdev: vga16fb: fix OOB write in vga16fb_imageblit() Tetsuo Handa
2021-05-14 16:19 ` Tetsuo Handa
2021-05-14 17:29 ` Linus Torvalds
2021-05-14 17:29 ` Linus Torvalds
2021-05-14 17:37 ` Linus Torvalds
2021-05-14 17:37 ` Linus Torvalds
2021-05-14 18:23 ` Linus Torvalds
2021-05-14 18:23 ` Linus Torvalds
2021-05-14 20:25 ` Maciej W. Rozycki
2021-05-14 20:25 ` Maciej W. Rozycki
2021-05-14 20:32 ` Linus Torvalds
2021-05-14 20:32 ` Linus Torvalds
2021-05-14 21:10 ` Linus Torvalds
2021-05-14 21:10 ` Linus Torvalds
2021-05-15 7:43 ` [PATCH v2] tty: vt: always invoke vc->vc_sw->con_resize callback Tetsuo Handa
2021-05-15 7:43 ` Tetsuo Handa
2021-05-15 16:21 ` Maciej W. Rozycki [this message]
2021-05-15 16:21 ` Maciej W. Rozycki
2021-05-15 16:32 ` Maciej W. Rozycki
2021-05-15 16:32 ` Maciej W. Rozycki
2021-05-15 16:41 ` Linus Torvalds
2021-05-15 16:41 ` Linus Torvalds
2021-05-17 13:13 ` Daniel Vetter
2021-05-17 13:13 ` Daniel Vetter
2021-05-15 16:11 ` [PATCH] video: fbdev: vga16fb: fix OOB write in vga16fb_imageblit() Maciej W. Rozycki
2021-05-15 16:11 ` Maciej W. Rozycki
2021-05-17 13:07 ` Daniel Vetter
2021-05-17 13:07 ` Daniel Vetter
2021-05-17 13:10 ` Daniel Vetter
2021-05-17 13:10 ` Daniel Vetter
2021-05-15 0:45 ` Tetsuo Handa
2021-05-15 0:45 ` Tetsuo Handa
-- strict thread matches above, loose matches on Subject: below --
2020-10-06 8:18 BUG: unable to handle kernel paging request in cfb_imageblit syzbot
2020-10-06 8:18 ` syzbot
2020-10-06 8:18 ` syzbot
2020-12-18 15:26 ` syzbot
2020-12-18 15:26 ` syzbot
2020-12-18 15:27 ` Dmitry Vyukov
2020-12-18 15:27 ` Dmitry Vyukov
2020-05-12 6:55 BUG: unable to handle kernel paging request in bitfill_aligned syzbot
2020-05-12 6:55 ` syzbot
2020-05-12 6:55 ` syzbot
2019-12-27 7:13 BUG: unable to handle kernel paging request in vga16fb_imageblit syzbot
2019-12-27 7:13 ` syzbot
2019-12-27 7:13 ` syzbot
2019-12-10 16:38 BUG: unable to handle kernel paging request in sys_imageblit syzbot
2019-12-10 16:38 ` syzbot
2019-12-10 16:38 ` syzbot
2020-06-19 4:56 ` syzbot
2020-06-19 4:56 ` syzbot
2020-06-19 4:56 ` syzbot
2013-02-19 17:33 BUG: unable to handle kernel paging request at ffffc90000669000, IP: [<ffffffff8139d84a>] bitfill_unaligned+0x10a/0x1a0 Tommi Rantala
2013-02-19 17:33 ` BUG: unable to handle kernel paging request at ffffc90000669000, IP: [<ffffffff8139d84a>] bitfill_un Tommi Rantala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2105151815040.3032@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=adaplas@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+1f29e126cf461c4de3b3@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.