All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] serial: 8250: Correct Kconfig help text for blacklisted PCI devices
Date: Sat, 12 Feb 2022 17:30:53 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2202121704560.34636@angie.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.2202121646020.34636@angie.orcam.me.uk>

Correct the Kconfig help text for SERIAL_8250_LPSS, SERIAL_8250_MID and 
SERIAL_8250_PERICOM configuration options for dedicated PCI UART drivers 
that have been blacklisted in the generic PCI 8250 UART driver and as 
from commit a13e19cf3dc10 ("serial: 8250_lpss: split LPSS driver to 
separate module"), commit d9eda9bab2372 ("serial: 8250_pci: Intel MID 
UART support to its own driver"), and commit fcfd3c09f4078 ("serial: 
8250_pci: Split out Pericom driver") respectively are not handled by 
said driver anymore (rather than for extra features only, as the current 
text indicates), and therefore require the respective dedicated drivers 
to work at all.

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
---
No changes from v1.
---
 drivers/tty/serial/8250/Kconfig |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

linux-serial-8250-pci-blacklist-help.diff
Index: linux-macro/drivers/tty/serial/8250/Kconfig
===================================================================
--- linux-macro.orig/drivers/tty/serial/8250/Kconfig
+++ linux-macro/drivers/tty/serial/8250/Kconfig
@@ -479,11 +479,12 @@ config SERIAL_8250_LPSS
 	select DW_DMAC_PCI if (SERIAL_8250_DMA && X86_INTEL_LPSS)
 	select RATIONAL
 	help
-	  Selecting this option will enable handling of the extra features
-	  present on the UART found on various Intel platforms such as:
+	  Selecting this option will enable handling of the UART found on
+	  various Intel platforms such as:
 	    - Intel Baytrail SoC
 	    - Intel Braswell SoC
 	    - Intel Quark X1000 SoC
+	  that are not covered by the more generic SERIAL_8250_PCI option.
 
 config SERIAL_8250_MID
 	tristate "Support for serial ports on Intel MID platforms"
@@ -494,17 +495,18 @@ config SERIAL_8250_MID
 	select HSU_DMA_PCI if (HSU_DMA && X86_INTEL_MID)
 	select RATIONAL
 	help
-	  Selecting this option will enable handling of the extra features
-	  present on the UART found on Intel Medfield SOC and various other
-	  Intel platforms.
+	  Selecting this option will enable handling of the UART found on
+	  Intel Medfield SOC and various other Intel platforms that is not
+	  covered by the more generic SERIAL_8250_PCI option.
 
 config SERIAL_8250_PERICOM
 	tristate "Support for Pericom and Acces I/O serial ports"
 	default SERIAL_8250
 	depends on SERIAL_8250 && PCI
 	help
-	  Selecting this option will enable handling of the extra features
-	  present on the Pericom and Acces I/O UARTs.
+	  Selecting this option will enable handling of the Pericom and Acces
+	  I/O UARTs that are not covered by the more generic SERIAL_8250_PCI
+	  option.
 
 config SERIAL_8250_PXA
 	tristate "PXA serial port support"

  reply	other threads:[~2022-02-12 17:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-12 17:30 [PATCH v2 0/2] serial: 8250: Correct basic issues with the PCI blacklist Maciej W. Rozycki
2022-02-12 17:30 ` Maciej W. Rozycki [this message]
2022-02-12 17:30 ` [PATCH v2 2/2] serial: 8250: Report which option to enable for blacklisted PCI devices Maciej W. Rozycki
2022-02-25  9:35   ` Greg Kroah-Hartman
2022-02-26 10:32     ` Maciej W. Rozycki
2022-02-27 23:06       ` Maciej W. Rozycki
2022-03-31  7:12         ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2202121704560.34636@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.