All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] serial: 8250: Report which option to enable for blacklisted PCI devices
Date: Thu, 31 Mar 2022 08:12:00 +0100 (BST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2203310125350.44113@angie.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.2202271516420.39915@angie.orcam.me.uk>

On Sun, 27 Feb 2022, Maciej W. Rozycki wrote:

> > > We don't do this for any other driver subsystem, so why is it really
> > > needed?  What is so special about this driver that distros can't
> > > just enable all of the drivers and all is good?  What is keeping those
> > > drivers fromb eing enabled?
> > 
> >  My justification is we have a supposedly generic PCI 8250 UART driver, 
> > except it explicitly and silently refuses to handle a handful of devices 
> > chosen by their PCI IDs based on that they may have extra features, even 
> > though they are otherwise fully compatible with a generic 8250.
> 
>  Actually as it happens we do have a precedent too, as here's what I have 
> just spotted on my laptop by chance when hibernating:
> 
> psmouse serio1: synaptics: The touchpad can support a better bus than the too old PS/2 protocol. Make sure MOUSE_PS2_SYNAPTICS_SMBUS and RMI4_SMB are enabled to get a better touchpad experience.
> 
> (with a distribution kernel, so clearly whoever packaged that has not 
> enabled what might be needed).  Someone else wanted to be helpful too as 
> it seems.

 I have now posted v3 with these clarifications included in the change 
descriptions.  Please review.

  Maciej

      reply	other threads:[~2022-03-31  7:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-12 17:30 [PATCH v2 0/2] serial: 8250: Correct basic issues with the PCI blacklist Maciej W. Rozycki
2022-02-12 17:30 ` [PATCH v2 1/2] serial: 8250: Correct Kconfig help text for blacklisted PCI devices Maciej W. Rozycki
2022-02-12 17:30 ` [PATCH v2 2/2] serial: 8250: Report which option to enable " Maciej W. Rozycki
2022-02-25  9:35   ` Greg Kroah-Hartman
2022-02-26 10:32     ` Maciej W. Rozycki
2022-02-27 23:06       ` Maciej W. Rozycki
2022-03-31  7:12         ` Maciej W. Rozycki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2203310125350.44113@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.