From: Paul Walmsley <paul.walmsley@sifive.com>
To: Rolf Eike Beer <eb@emlix.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
linux-kernel@vger.kernel.org
Subject: Re: riscv: remove unused barrier defines
Date: Mon, 17 Jun 2019 07:31:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1906170724240.32654@viisi.sifive.com> (raw)
In-Reply-To: <1862877.fiP6YxjBP5@devpool35>
On Mon, 17 Jun 2019, Rolf Eike Beer wrote:
> From 947f9fe483dc6561e31f0d2294eb6fedc1d6d9bb Mon Sep 17 00:00:00 2001
> From: Rolf Eike Beer <eb@emlix.com>
> Date: Mon, 17 Jun 2019 14:22:37 +0200
> Subject: [PATCH] riscv: remove unused barrier defines
>
> They were introduced in fab957c11efe2f405e08b9f0d080524bc2631428 long after
> 2e39465abc4b7856a0ea6fcf4f6b4668bb5db877 removed the remnants of all previous
> instances from the tree.
>
> Signed-off-by: Rolf Eike Beer <eb@emlix.com>
Thanks for the patch. checkpatch.pl flags an error on the format of the
commit IDs in the patch description. And there is also the spurious mbox
header. These have been fixed these up here, and the patch below has been
queued for v5.2-rc. It would help to run "checkpatch.pl --strict" on
future patches.
thanks again,
- Paul
From: Rolf Eike Beer <eb@emlix.com>
Date: Mon, 17 Jun 2019 14:25:59 +0200
Subject: [PATCH] riscv: remove unused barrier defines
They were introduced in commit fab957c11efe ("RISC-V: Atomic and
Locking Code") long after commit 2e39465abc4b ("locking: Remove
deprecated smp_mb__() barriers") removed the remnants of all previous
instances from the tree.
Signed-off-by: Rolf Eike Beer <eb@emlix.com>
[paul.walmsley@sifive.com: stripped spurious mbox header from patch
description; fixed commit references in patch header]
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
---
arch/riscv/include/asm/bitops.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h
index f30daf26f08f..01db98dfd043 100644
--- a/arch/riscv/include/asm/bitops.h
+++ b/arch/riscv/include/asm/bitops.h
@@ -23,11 +23,6 @@
#include <asm/barrier.h>
#include <asm/bitsperlong.h>
-#ifndef smp_mb__before_clear_bit
-#define smp_mb__before_clear_bit() smp_mb()
-#define smp_mb__after_clear_bit() smp_mb()
-#endif /* smp_mb__before_clear_bit */
-
#include <asm-generic/bitops/__ffs.h>
#include <asm-generic/bitops/ffz.h>
#include <asm-generic/bitops/fls.h>
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Walmsley <paul.walmsley@sifive.com>
To: Rolf Eike Beer <eb@emlix.com>
Cc: linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: riscv: remove unused barrier defines
Date: Mon, 17 Jun 2019 07:31:10 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1906170724240.32654@viisi.sifive.com> (raw)
In-Reply-To: <1862877.fiP6YxjBP5@devpool35>
On Mon, 17 Jun 2019, Rolf Eike Beer wrote:
> From 947f9fe483dc6561e31f0d2294eb6fedc1d6d9bb Mon Sep 17 00:00:00 2001
> From: Rolf Eike Beer <eb@emlix.com>
> Date: Mon, 17 Jun 2019 14:22:37 +0200
> Subject: [PATCH] riscv: remove unused barrier defines
>
> They were introduced in fab957c11efe2f405e08b9f0d080524bc2631428 long after
> 2e39465abc4b7856a0ea6fcf4f6b4668bb5db877 removed the remnants of all previous
> instances from the tree.
>
> Signed-off-by: Rolf Eike Beer <eb@emlix.com>
Thanks for the patch. checkpatch.pl flags an error on the format of the
commit IDs in the patch description. And there is also the spurious mbox
header. These have been fixed these up here, and the patch below has been
queued for v5.2-rc. It would help to run "checkpatch.pl --strict" on
future patches.
thanks again,
- Paul
From: Rolf Eike Beer <eb@emlix.com>
Date: Mon, 17 Jun 2019 14:25:59 +0200
Subject: [PATCH] riscv: remove unused barrier defines
They were introduced in commit fab957c11efe ("RISC-V: Atomic and
Locking Code") long after commit 2e39465abc4b ("locking: Remove
deprecated smp_mb__() barriers") removed the remnants of all previous
instances from the tree.
Signed-off-by: Rolf Eike Beer <eb@emlix.com>
[paul.walmsley@sifive.com: stripped spurious mbox header from patch
description; fixed commit references in patch header]
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
---
arch/riscv/include/asm/bitops.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/riscv/include/asm/bitops.h b/arch/riscv/include/asm/bitops.h
index f30daf26f08f..01db98dfd043 100644
--- a/arch/riscv/include/asm/bitops.h
+++ b/arch/riscv/include/asm/bitops.h
@@ -23,11 +23,6 @@
#include <asm/barrier.h>
#include <asm/bitsperlong.h>
-#ifndef smp_mb__before_clear_bit
-#define smp_mb__before_clear_bit() smp_mb()
-#define smp_mb__after_clear_bit() smp_mb()
-#endif /* smp_mb__before_clear_bit */
-
#include <asm-generic/bitops/__ffs.h>
#include <asm-generic/bitops/ffz.h>
#include <asm-generic/bitops/fls.h>
--
2.20.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-06-17 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 12:25 riscv: remove unused barrier defines Rolf Eike Beer
2019-06-17 12:25 ` Rolf Eike Beer
2019-06-17 14:31 ` Paul Walmsley [this message]
2019-06-17 14:31 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1906170724240.32654@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=eb@emlix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.