From: Julia Lawall <julia.lawall@inria.fr>
To: Denis Efremov <efremov@linux.com>
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH v4] coccinelle: api: add kvfree script
Date: Fri, 31 Jul 2020 10:48:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2007311045490.2439@hadrien> (raw)
In-Reply-To: <dda490e5-35c8-f097-af2a-e42e7ba21ae0@linux.com>
> >
> > Do the checks for the opportunities for kvmalloc really belong in this
> > rule? That issue is not mentioned in the commit log or the description of
> > the semantic patch.
>
> I added this at the last moment. It was easy enough to add it based on existing
> patterns. I will add description for this warnings. Or do you want me to single
> out this warning to a separate rule?
It seems like a different issue. A separate rule might be better. Also,
there is no patch variant, so if one runs the patch mode on this script,
where the patch mode is useful, then one will miss the kvmalloc
suggestions completely. Coccicheck has a mode where is first tries patch
and then report; I think 0-day uses this.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Denis Efremov <efremov@linux.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [Cocci] [PATCH v4] coccinelle: api: add kvfree script
Date: Fri, 31 Jul 2020 10:48:07 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2007311045490.2439@hadrien> (raw)
In-Reply-To: <dda490e5-35c8-f097-af2a-e42e7ba21ae0@linux.com>
> >
> > Do the checks for the opportunities for kvmalloc really belong in this
> > rule? That issue is not mentioned in the commit log or the description of
> > the semantic patch.
>
> I added this at the last moment. It was easy enough to add it based on existing
> patterns. I will add description for this warnings. Or do you want me to single
> out this warning to a separate rule?
It seems like a different issue. A separate rule might be better. Also,
there is no patch variant, so if one runs the patch mode on this script,
where the patch mode is useful, then one will miss the kvmalloc
suggestions completely. Coccicheck has a mode where is first tries patch
and then report; I think 0-day uses this.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2020-07-31 8:48 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 20:42 [PATCH] coccinelle: api: add kvfree script Denis Efremov
2020-06-05 20:42 ` [Cocci] " Denis Efremov
2020-06-05 20:51 ` Julia Lawall
2020-06-05 20:51 ` Julia Lawall
2020-06-05 21:15 ` Denis Efremov
2020-06-05 21:15 ` Denis Efremov
2020-06-05 21:19 ` Julia Lawall
2020-06-05 21:19 ` Julia Lawall
2020-06-14 9:03 ` Denis Efremov
2020-06-14 9:03 ` Denis Efremov
2020-06-14 9:17 ` Julia Lawall
2020-06-14 9:17 ` Julia Lawall
2020-06-14 9:24 ` Denis Efremov
2020-06-14 9:24 ` Denis Efremov
2020-06-14 18:36 ` [PATCH v2] " Denis Efremov
2020-06-14 18:36 ` [Cocci] " Denis Efremov
2020-07-17 12:00 ` Denis Efremov
2020-07-17 12:00 ` [Cocci] " Denis Efremov
2020-07-30 14:01 ` [PATCH v3] " Denis Efremov
2020-07-30 14:01 ` [Cocci] " Denis Efremov
2020-07-30 14:05 ` Denis Efremov
2020-07-30 14:05 ` [Cocci] " Denis Efremov
2020-07-30 14:07 ` [PATCH v4] " Denis Efremov
2020-07-30 14:07 ` [Cocci] " Denis Efremov
2020-07-30 20:15 ` Julia Lawall
2020-07-30 20:15 ` [Cocci] " Julia Lawall
2020-07-30 20:38 ` Julia Lawall
2020-07-30 20:38 ` [Cocci] " Julia Lawall
2020-07-31 8:31 ` Denis Efremov
2020-07-31 8:31 ` [Cocci] " Denis Efremov
2020-07-31 8:48 ` Julia Lawall [this message]
2020-07-31 8:48 ` Julia Lawall
2020-07-31 10:47 ` [PATCH v5] " Denis Efremov
2020-07-31 10:47 ` [Cocci] " Denis Efremov
2020-07-31 21:00 ` [PATCH v6] " Denis Efremov
2020-07-31 21:00 ` [Cocci] " Denis Efremov
2020-08-02 20:24 ` Julia Lawall
2020-08-02 20:24 ` [Cocci] " Julia Lawall
2020-08-03 11:33 ` Denis Efremov
2020-08-03 11:33 ` [Cocci] " Denis Efremov
2020-08-03 12:18 ` Julia Lawall
2020-08-03 12:18 ` [Cocci] " Julia Lawall
2020-08-03 11:45 ` Denis Efremov
2020-08-03 11:45 ` [Cocci] " Denis Efremov
2020-08-03 12:12 ` Julia Lawall
2020-08-03 12:12 ` [Cocci] " Julia Lawall
2020-08-03 18:34 ` [PATCH v7] coccinelle: api: add kfree_mismatch script Denis Efremov
2020-08-03 18:34 ` [Cocci] " Denis Efremov
2020-09-21 17:15 ` Denis Efremov
2020-09-21 17:15 ` [Cocci] " Denis Efremov
2020-10-15 20:48 ` Julia Lawall
2020-10-15 20:48 ` [Cocci] " Julia Lawall
2020-10-16 8:54 ` [PATCH v8] " Denis Efremov
2020-10-16 8:54 ` [Cocci] " Denis Efremov
2020-10-17 21:17 ` Julia Lawall
2020-10-17 21:17 ` Julia Lawall
[not found] <75532a99-4498-c64a-de34-c9033782aa9e@web.de>
2020-07-30 19:27 ` [PATCH v4] coccinelle: api: add kvfree script Julia Lawall
2020-07-30 19:27 ` Julia Lawall
[not found] ` <96a71d0e-ae6f-9355-b02a-b1a084376f1e@web.de>
2020-07-31 8:45 ` Julia Lawall
2020-07-31 8:45 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2007311045490.2439@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.