From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Denis Efremov <efremov@linux.com>,
Coccinelle <cocci@systeme.lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [RFC PATCH] coccinelle: misc: add uninitialized_var.cocci script
Date: Wed, 12 Aug 2020 11:27:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2008121127120.2572@hadrien> (raw)
In-Reply-To: <1b8537dd-8bf3-d3b6-4c10-af2fa623f1fe@web.de>
On Wed, 12 Aug 2020, Markus Elfring wrote:
> > +@r@
> > +identifier var;
> > +type T;
> > +position p;
> > +@@
> > +
> > +(
> > +* T var@p = var;
> > +|
> > +* T var@p = *(&(var));
>
> I suggest to simplify such code for the semantic patch language a bit.
> Can an other variant be more succinct for the application of a SmPL disjunction?
>
> +*T var@p = \( var \| *(&(var)) \);
It's fine as is.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Michal Marek <michal.lkml@markovi.net>,
Kees Cook <keescook@chromium.org>,
Gilles Muller <Gilles.Muller@lip6.fr>,
kernel-janitors@vger.kernel.org,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [RFC PATCH] coccinelle: misc: add uninitialized_var.cocci script
Date: Wed, 12 Aug 2020 09:27:45 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2008121127120.2572@hadrien> (raw)
In-Reply-To: <1b8537dd-8bf3-d3b6-4c10-af2fa623f1fe@web.de>
On Wed, 12 Aug 2020, Markus Elfring wrote:
> > +@r@
> > +identifier var;
> > +type T;
> > +position p;
> > +@@
> > +
> > +(
> > +* T var@p = var;
> > +|
> > +* T var@p = *(&(var));
>
> I suggest to simplify such code for the semantic patch language a bit.
> Can an other variant be more succinct for the application of a SmPL disjunction?
>
> +*T var@p = \( var \| *(&(var)) \);
It's fine as is.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Michal Marek <michal.lkml@markovi.net>,
Kees Cook <keescook@chromium.org>,
Gilles Muller <Gilles.Muller@lip6.fr>,
kernel-janitors@vger.kernel.org,
Nicolas Palix <nicolas.palix@imag.fr>,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] [RFC PATCH] coccinelle: misc: add uninitialized_var.cocci script
Date: Wed, 12 Aug 2020 11:27:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2008121127120.2572@hadrien> (raw)
In-Reply-To: <1b8537dd-8bf3-d3b6-4c10-af2fa623f1fe@web.de>
On Wed, 12 Aug 2020, Markus Elfring wrote:
> > +@r@
> > +identifier var;
> > +type T;
> > +position p;
> > +@@
> > +
> > +(
> > +* T var@p = var;
> > +|
> > +* T var@p = *(&(var));
>
> I suggest to simplify such code for the semantic patch language a bit.
> Can an other variant be more succinct for the application of a SmPL disjunction?
>
> +*T var@p = \( var \| *(&(var)) \);
It's fine as is.
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next parent reply other threads:[~2020-08-12 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b8537dd-8bf3-d3b6-4c10-af2fa623f1fe@web.de>
2020-08-12 9:27 ` Julia Lawall [this message]
2020-08-12 9:27 ` [Cocci] [RFC PATCH] coccinelle: misc: add uninitialized_var.cocci script Julia Lawall
2020-08-12 9:27 ` Julia Lawall
2020-08-11 21:01 Denis Efremov
2020-08-29 19:36 ` Julia Lawall
2020-08-29 19:38 ` Joe Perches
2020-08-29 19:48 ` Julia Lawall
2020-08-29 20:13 ` Denis Efremov
2020-08-29 20:26 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2008121127120.2572@hadrien \
--to=julia.lawall@inria.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=efremov@linux.com \
--cc=gustavoars@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.