All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK
Date: Thu, 3 Sep 2020 17:55:09 +0300 (EEST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2009031753180.3186@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <20200903134755.GV6112@intel.com>

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

Hey,

On Thu, 3 Sep 2020, Ville Syrjälä wrote:

> On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote:
>> In commit 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking
>> to separate function") the order of force_min_cdclk_changed check and
>> intel_modeset_checks(), was reversed. This broke the mechanism to
> 
> Amended the commit msg with a bit more details:
> "[vsyrjala: It also broke the ability of planes to bump up the cdclk
> and thus could lead to underruns when eg. flipping from 32bpp to
> 64bpp framebuffer. To be clear, we still compute the new cdclk

ack on that, thanks!

> The "Fixes" line was also a bit wrong: )" vs ") at the end. Took
> me a while to figure out what dim was complaining about :)
> 
> Pushed to dinq. Thanks!

Uh, sorry about that. I actually fixed that in some (?) version due to 
checkpatch warnings, but apparently it slipped though. Sorry about that, 
took me a while to figure it out, as well :)

Br, Kai

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2020-09-03 14:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 15:10 [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK Kai Vehmanen
2020-09-01 15:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-09-02 10:31 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-09-02 12:12   ` Lisovskiy, Stanislav
2020-09-02 12:17     ` Ville Syrjälä
2020-09-02 12:34       ` Lisovskiy, Stanislav
2020-09-02 12:48         ` Ville Syrjälä
2020-09-02 12:37   ` Lisovskiy, Stanislav
2020-09-02 16:57 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2020-09-03 13:47 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-09-03 14:55   ` Kai Vehmanen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2009031753180.3186@eliteleevi.tm.intel.com \
    --to=kai.vehmanen@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.