[km13park-linux-1:master 4/6] drivers/scan_at_field/scan_at_field.c:258:1-22: alloc with no test, possible model on line 276 (fwd)

[km13park-linux-1:master 4/6] drivers/scan_at_field/scan_at_field.c:258:1-22: alloc with no test, possible model on line 276 (fwd)

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 6241 bytes --]

There should normally be a null test after the call ot kzalloc on line
258.

julia

---------- Forwarded message ----------
Date: Thu, 29 Apr 2021 13:47:15 +0800
From: kernel test robot <lkp@intel.com>
To: kbuild(a)lists.01.org
Cc: lkp(a)intel.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: [km13park-linux-1:master 4/6]
    drivers/scan_at_field/scan_at_field.c:258:1-22: alloc with no test,
    possible model on line 276

CC: kbuild-all(a)lists.01.org
TO: Kyung Min Park <kyung.min.park@intel.com>

tree:   https://github.com/km13park/linux-1.git master
head:   2599cfd82a427fcb66aba75fb0d5d8ae10bfac06
commit: a101b2eee22165a2a507d0d6f843897c4ff5d830 [4/6] saf: scan at field warnings fix
:::::: branch date: 13 hours ago
:::::: commit date: 2 days ago
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/scan_at_field/scan_at_field.c:258:1-22: alloc with no test, possible model on line 276

vim +258 drivers/scan_at_field/scan_at_field.c

4dab1d6923971a Kyung Min Park 2021-04-18  244
4dab1d6923971a Kyung Min Park 2021-04-18  245  /*
4dab1d6923971a Kyung Min Park 2021-04-18  246   * Load scan hash and data binaries. Scan hash copy and authentication must be run on
4dab1d6923971a Kyung Min Park 2021-04-18  247   * the first cpu for each package.
4dab1d6923971a Kyung Min Park 2021-04-18  248   * The first byte of scan hash holds the information to determine whether it is for scan
4dab1d6923971a Kyung Min Park 2021-04-18  249   * at field or not.
4dab1d6923971a Kyung Min Park 2021-04-18  250   */
4dab1d6923971a Kyung Min Park 2021-04-18  251  int load_scan_binaries(void)
4dab1d6923971a Kyung Min Park 2021-04-18  252  {
4dab1d6923971a Kyung Min Park 2021-04-18  253  	char name[20], hash_path[256], scan_path[256];
4dab1d6923971a Kyung Min Park 2021-04-18  254  	const struct firmware *hash_fw, *test_fw;
4dab1d6923971a Kyung Min Park 2021-04-18  255  	int cpu, ret, curr_pkg;
4dab1d6923971a Kyung Min Park 2021-04-18  256  	u64 current_blob_ptr;
4dab1d6923971a Kyung Min Park 2021-04-18  257
a101b2eee22165 Kyung Min Park 2021-04-26 @258  	package_authenticated = kzalloc(sizeof(bool) * NR_CPUS, GFP_KERNEL);
4dab1d6923971a Kyung Min Park 2021-04-18  259  	snprintf(name, sizeof(name), "%02x-%02x-%02x", boot_cpu_data.x86, boot_cpu_data.x86_model,
4dab1d6923971a Kyung Min Park 2021-04-18  260  		 boot_cpu_data.x86_stepping);
4dab1d6923971a Kyung Min Park 2021-04-18  261
4dab1d6923971a Kyung Min Park 2021-04-18  262  	/* scan hash and test files will be named as "ff-mm--ss.hash" and "ff-mm--ss.scan" */
4dab1d6923971a Kyung Min Park 2021-04-18  263  	snprintf(hash_path, sizeof(hash_path), "%s%s%s", saf_path, name, ".hash");
4dab1d6923971a Kyung Min Park 2021-04-18  264  	snprintf(scan_path, sizeof(scan_path), "%s%s%s", saf_path, name, ".scan");
4dab1d6923971a Kyung Min Park 2021-04-18  265
4dab1d6923971a Kyung Min Park 2021-04-18  266  	current_blob_ptr = saf_params.hash_blob_ptr;
4dab1d6923971a Kyung Min Park 2021-04-18  267
4dab1d6923971a Kyung Min Park 2021-04-18  268  	/* load the scan hash and authenticate per package */
4dab1d6923971a Kyung Min Park 2021-04-18  269  	for_each_online_cpu(cpu) {
4dab1d6923971a Kyung Min Park 2021-04-18  270  		curr_pkg = topology_physical_package_id(cpu);
4dab1d6923971a Kyung Min Park 2021-04-18  271  		if (package_authenticated[curr_pkg])
4dab1d6923971a Kyung Min Park 2021-04-18  272  			continue;
4dab1d6923971a Kyung Min Park 2021-04-18  273  		package_authenticated[curr_pkg] = 1;
77464b203e49ef Kyung Min Park 2021-04-18  274  		sema_init(&sems[curr_pkg], max_cores);
4dab1d6923971a Kyung Min Park 2021-04-18  275
4dab1d6923971a Kyung Min Park 2021-04-18 @276  		hash_fw = load_scan_binary(hash_path, 1);
4dab1d6923971a Kyung Min Park 2021-04-18  277  		if (!hash_fw)
4dab1d6923971a Kyung Min Park 2021-04-18  278  			goto out;
4dab1d6923971a Kyung Min Park 2021-04-18  279
4dab1d6923971a Kyung Min Park 2021-04-18  280  		if (!has_newer_binary_blob((char *)current_blob_ptr, (char *)hash_fw->data))
4dab1d6923971a Kyung Min Park 2021-04-18  281  			goto out;
4dab1d6923971a Kyung Min Park 2021-04-18  282
4dab1d6923971a Kyung Min Park 2021-04-18  283  		saf_params.hash_blob_ptr = (u64)hash_fw->data;
4dab1d6923971a Kyung Min Park 2021-04-18  284
4dab1d6923971a Kyung Min Park 2021-04-18  285  		if (*(hash_fw->data) == SCAN_PROGRAM) {
4dab1d6923971a Kyung Min Park 2021-04-18  286  			test_fw = load_scan_binary(scan_path, 0);
4dab1d6923971a Kyung Min Park 2021-04-18  287  		} else {
4dab1d6923971a Kyung Min Park 2021-04-18  288  			pr_err("wrong module type for scan test");
4dab1d6923971a Kyung Min Park 2021-04-18  289  			goto out;
4dab1d6923971a Kyung Min Park 2021-04-18  290  		}
4dab1d6923971a Kyung Min Park 2021-04-18  291  		if (!test_fw)
4dab1d6923971a Kyung Min Park 2021-04-18  292  			goto out;
4dab1d6923971a Kyung Min Park 2021-04-18  293
4dab1d6923971a Kyung Min Park 2021-04-18  294  		saf_params.test_blob_ptr = (u64)test_fw->data;
4dab1d6923971a Kyung Min Park 2021-04-18  295
4dab1d6923971a Kyung Min Park 2021-04-18  296  		ret = smp_call_function_single(cpu, (void *)copy_scan_hashes_authenticate, NULL, 1);
4dab1d6923971a Kyung Min Park 2021-04-18  297  		if (ret)
4dab1d6923971a Kyung Min Park 2021-04-18  298  			return -EINVAL;
4dab1d6923971a Kyung Min Park 2021-04-18  299  	}
4dab1d6923971a Kyung Min Park 2021-04-18  300  out:
a101b2eee22165 Kyung Min Park 2021-04-26  301  	kfree(package_authenticated);
4dab1d6923971a Kyung Min Park 2021-04-18  302  	release_firmware(hash_fw);
4dab1d6923971a Kyung Min Park 2021-04-18  303  	release_firmware(test_fw);
4dab1d6923971a Kyung Min Park 2021-04-18  304
4dab1d6923971a Kyung Min Park 2021-04-18  305  	return 0;
4dab1d6923971a Kyung Min Park 2021-04-18  306  }
4dab1d6923971a Kyung Min Park 2021-04-18  307

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65469 bytes --]