All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hw/i386/ich9: add comment explaining an argument to acpi_pcihp_reset call
@ 2021-07-27  4:45 Ani Sinha
  2021-07-29 13:13 ` Ani Sinha
  2021-08-03 14:13 ` Michael S. Tsirkin
  0 siblings, 2 replies; 5+ messages in thread
From: Ani Sinha @ 2021-07-27  4:45 UTC (permalink / raw)
  To: qemu-devel; +Cc: Ani Sinha, Igor Mammedov, Michael S. Tsirkin

acpi_pcihp_reset() call from ich9/pm_reset() passes an unconditional truth value
as the second argument. Added a commnet here to explain the reason why the
argument is being passed unconditionally.

Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
 hw/acpi/ich9.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 778e27b659..b2e3c46075 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -281,6 +281,11 @@ static void pm_reset(void *opaque)
     pm->smi_en_wmask = ~0;
 
     if (pm->use_acpi_hotplug_bridge) {
+        /*
+         * PCI Express root buses do not support hot-plug, for
+         * details see docs/pcie.txt. Hence, the second argument
+         * is unconditionally true.
+         */
         acpi_pcihp_reset(&pm->acpi_pci_hotplug, true);
     }
 
-- 
2.25.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-04 13:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27  4:45 [PATCH] hw/i386/ich9: add comment explaining an argument to acpi_pcihp_reset call Ani Sinha
2021-07-29 13:13 ` Ani Sinha
2021-08-03 11:34   ` Ani Sinha
2021-08-03 14:13 ` Michael S. Tsirkin
2021-08-04 13:19   ` Ani Sinha

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.