From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
xen-devel@lists.xenproject.org,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Bertrand.Marquis@arm.com
Subject: Re: [PATCH v2 2/2] xen/arm: add FF-A mediator
Date: Mon, 13 Jun 2022 16:18:03 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2206131617490.1837490@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <f664f35b-2fec-38e4-3382-1fd14ba66e8d@xen.org>
On Sat, 11 Jun 2022, Julien Grall wrote:
> On 11/06/2022 02:23, Stefano Stabellini wrote:
> > > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr,
> > > + uint32_t page_count)
> > > +{
> > > + const struct arm_smccc_1_2_regs arg = {
> > > +#ifdef CONFIG_ARM_64
> > > + .a0 = FFA_RXTX_MAP_64,
> > > +#endif
> >
> > This ifdef is unnecessary given that FFA depends on ARM64 and SMCCCv1.2
> > is only implemented on ARM64. It also applies to all the other ifdefs in
> > this file. You can remove the code under #ifdef CONFIG_ARM_32.
>
> To me the #ifdef indicates that it would be possible to use FFA on arm32. So I
> think it is better to keep them rather than having to retrofitting them in the
> future.
OK, fair enough
next prev parent reply other threads:[~2022-06-13 23:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 6:18 [PATCH v2 0/2] Xen FF-A mediator Jens Wiklander
2022-06-09 6:18 ` [PATCH v2 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers Jens Wiklander
2022-06-11 0:41 ` Stefano Stabellini
2022-06-11 9:41 ` Julien Grall
2022-06-13 23:18 ` Stefano Stabellini
2022-06-15 15:58 ` Jens Wiklander
2022-06-15 19:01 ` Julien Grall
2022-06-15 22:09 ` Jens Wiklander
2022-06-16 15:13 ` Julien Grall
2022-06-15 19:43 ` Julien Grall
2022-06-16 0:09 ` Stefano Stabellini
2022-06-09 6:18 ` [PATCH v2 2/2] xen/arm: add FF-A mediator Jens Wiklander
2022-06-11 1:23 ` Stefano Stabellini
2022-06-11 9:08 ` Julien Grall
2022-06-13 23:18 ` Stefano Stabellini [this message]
2022-06-16 18:05 ` Jens Wiklander
2022-06-14 19:47 ` Volodymyr Babchuk
2022-06-15 18:15 ` Julien Grall
2022-06-16 22:37 ` Jens Wiklander
2022-06-17 8:16 ` Julien Grall
2022-06-20 13:05 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2206131617490.1837490@ubuntu-linux-20-04-desktop \
--to=sstabellini@kernel.org \
--cc=Bertrand.Marquis@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=jens.wiklander@linaro.org \
--cc=julien@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.