* [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation
@ 2022-06-21 15:44 Xenia Ragiadakou
2022-06-21 15:44 ` [PATCH 2/2] xen/arm: vtimer: Remove duplicate header Xenia Ragiadakou
2022-06-21 23:44 ` [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation Stefano Stabellini
0 siblings, 2 replies; 5+ messages in thread
From: Xenia Ragiadakou @ 2022-06-21 15:44 UTC (permalink / raw)
To: xen-devel
Cc: Xenia Ragiadakou, Stefano Stabellini, Julien Grall,
Bertrand Marquis, Volodymyr Babchuk
Include vtimer.h so that the declarations of vtimer functions with external
linkage are visible before the function definitions.
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---
xen/arch/arm/vtimer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
index 5bb5970f58..5f26463354 100644
--- a/xen/arch/arm/vtimer.c
+++ b/xen/arch/arm/vtimer.c
@@ -29,6 +29,7 @@
#include <asm/time.h>
#include <asm/vgic.h>
#include <asm/vreg.h>
+#include <asm/vtimer.h>
#include <asm/regs.h>
/*
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] xen/arm: vtimer: Remove duplicate header
2022-06-21 15:44 [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation Xenia Ragiadakou
@ 2022-06-21 15:44 ` Xenia Ragiadakou
2022-06-21 23:44 ` Stefano Stabellini
2022-06-21 23:44 ` [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation Stefano Stabellini
1 sibling, 1 reply; 5+ messages in thread
From: Xenia Ragiadakou @ 2022-06-21 15:44 UTC (permalink / raw)
To: xen-devel
Cc: Xenia Ragiadakou, Stefano Stabellini, Julien Grall,
Bertrand Marquis, Volodymyr Babchuk
The header file <asm/regs.h> is already included above and can be removed here.
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
---
xen/arch/arm/vtimer.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
index 5f26463354..6b78fea77d 100644
--- a/xen/arch/arm/vtimer.c
+++ b/xen/arch/arm/vtimer.c
@@ -30,7 +30,6 @@
#include <asm/vgic.h>
#include <asm/vreg.h>
#include <asm/vtimer.h>
-#include <asm/regs.h>
/*
* Check if regs is allowed access, user_gate is tail end of a
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation
2022-06-21 15:44 [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation Xenia Ragiadakou
2022-06-21 15:44 ` [PATCH 2/2] xen/arm: vtimer: Remove duplicate header Xenia Ragiadakou
@ 2022-06-21 23:44 ` Stefano Stabellini
2022-06-23 18:56 ` Julien Grall
1 sibling, 1 reply; 5+ messages in thread
From: Stefano Stabellini @ 2022-06-21 23:44 UTC (permalink / raw)
To: Xenia Ragiadakou
Cc: xen-devel, Stefano Stabellini, Julien Grall, Bertrand Marquis,
Volodymyr Babchuk
On Tue, 21 Jun 2022, Xenia Ragiadakou wrote:
> Include vtimer.h so that the declarations of vtimer functions with external
> linkage are visible before the function definitions.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/vtimer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
> index 5bb5970f58..5f26463354 100644
> --- a/xen/arch/arm/vtimer.c
> +++ b/xen/arch/arm/vtimer.c
> @@ -29,6 +29,7 @@
> #include <asm/time.h>
> #include <asm/vgic.h>
> #include <asm/vreg.h>
> +#include <asm/vtimer.h>
> #include <asm/regs.h>
>
> /*
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] xen/arm: vtimer: Remove duplicate header
2022-06-21 15:44 ` [PATCH 2/2] xen/arm: vtimer: Remove duplicate header Xenia Ragiadakou
@ 2022-06-21 23:44 ` Stefano Stabellini
0 siblings, 0 replies; 5+ messages in thread
From: Stefano Stabellini @ 2022-06-21 23:44 UTC (permalink / raw)
To: Xenia Ragiadakou
Cc: xen-devel, Stefano Stabellini, Julien Grall, Bertrand Marquis,
Volodymyr Babchuk
On Tue, 21 Jun 2022, Xenia Ragiadakou wrote:
> The header file <asm/regs.h> is already included above and can be removed here.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/vtimer.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
> index 5f26463354..6b78fea77d 100644
> --- a/xen/arch/arm/vtimer.c
> +++ b/xen/arch/arm/vtimer.c
> @@ -30,7 +30,6 @@
> #include <asm/vgic.h>
> #include <asm/vreg.h>
> #include <asm/vtimer.h>
> -#include <asm/regs.h>
>
> /*
> * Check if regs is allowed access, user_gate is tail end of a
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation
2022-06-21 23:44 ` [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation Stefano Stabellini
@ 2022-06-23 18:56 ` Julien Grall
0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2022-06-23 18:56 UTC (permalink / raw)
To: Stefano Stabellini, Xenia Ragiadakou
Cc: xen-devel, Bertrand Marquis, Volodymyr Babchuk
Hi Xenia,
On 22/06/2022 00:44, Stefano Stabellini wrote:
> On Tue, 21 Jun 2022, Xenia Ragiadakou wrote:
>> Include vtimer.h so that the declarations of vtimer functions with external
>> linkage are visible before the function definitions.
>>
>> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Like your other series, I wasn't able to find a cover letter so replying
here.
I have now committed it. But in the future, please create a cover letter.
Cheers,
--
Julien Grall
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-23 18:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 15:44 [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation Xenia Ragiadakou
2022-06-21 15:44 ` [PATCH 2/2] xen/arm: vtimer: Remove duplicate header Xenia Ragiadakou
2022-06-21 23:44 ` Stefano Stabellini
2022-06-21 23:44 ` [PATCH 1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation Stefano Stabellini
2022-06-23 18:56 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.