[PATCH] EFI - PXE - include details from proxy (altserviceboot) offer when available

[PATCH] EFI - PXE - include details from proxy (altserviceboot) offer when available

[Mroczek, Joseph T]

Addresses Bug# 41488
https://savannah.gnu.org/bugs/?41488 

This is my first time submitting a patch. Please let me know what I can do to help drive this improvement.

~joe

diff -Naur grub-2.02~beta2/grub-core/net/drivers/efi/efinet.c grub-2.02~beta2-bug41488-jtm/grub-core/net/drivers/efi/efinet.c
--- grub-2.02~beta2/grub-core/net/drivers/efi/efinet.c	2013-12-24 11:29:27.000000000 -0500
+++ grub-2.02~beta2-bug41488-jtm/grub-core/net/drivers/efi/efinet.c	2014-02-10 16:37:22.566895600 -0500
@@ -250,6 +250,12 @@
 				    &pxe_mode->dhcp_ack,
 				    sizeof (pxe_mode->dhcp_ack),
 				    1, device, path);
+    if (pxe_mode->unused[10])  //ProxyOfferRecieved
+      grub_net_configure_by_dhcp_ack (card->name, card, 0,
+				    (struct grub_net_bootp_packet *)
+				    &pxe_mode->proxy_offer,
+				    sizeof (pxe_mode->proxy_offer),
+				    1, device, path);
     return;
   }
 }

Re: [PATCH] EFI - PXE - include details from proxy (altserviceboot) offer when available

[Seth Goldberg]

Hi,

Quoting Mroczek, Joseph T, who wrote the following on Mon, 10 Feb 2014:

> Addresses Bug# 41488
> https://savannah.gnu.org/bugs/?41488
>
> This is my first time submitting a patch. Please let me know what I can do to help drive this improvement.

   Since "unused[10]" is rather hard to understand, how about changing the 
pxe_mode structure to include the proper name for that member?  Your patch 
came at just the right moment for me, BTW ;).

  --S

>
> ~joe
>
> diff -Naur grub-2.02~beta2/grub-core/net/drivers/efi/efinet.c grub-2.02~beta2-bug41488-jtm/grub-core/net/drivers/efi/efinet.c
> --- grub-2.02~beta2/grub-core/net/drivers/efi/efinet.c	2013-12-24 11:29:27.000000000 -0500
> +++ grub-2.02~beta2-bug41488-jtm/grub-core/net/drivers/efi/efinet.c	2014-02-10 16:37:22.566895600 -0500
> @@ -250,6 +250,12 @@
> 				    &pxe_mode->dhcp_ack,
> 				    sizeof (pxe_mode->dhcp_ack),
> 				    1, device, path);
> +    if (pxe_mode->unused[10])  //ProxyOfferRecieved
> +      grub_net_configure_by_dhcp_ack (card->name, card, 0,
> +				    (struct grub_net_bootp_packet *)
> +				    &pxe_mode->proxy_offer,
> +				    sizeof (pxe_mode->proxy_offer),
> +				    1, device, path);
>     return;
>   }
> }
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>