* [PATCH] 125 run ftrunc with relative path
@ 2010-04-16 7:27 Lukas Czerner
2010-04-16 15:48 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Czerner @ 2010-04-16 7:27 UTC (permalink / raw)
To: xfs; +Cc: Lukas Czerner, Eric Sandeen
>From 16588d733e681954386f1b92dd6e47cfef92a207 Mon Sep 17 00:00:00 2001
From: Lukas Czerner <lczerner@redhat.com>
Date: Tue, 13 Apr 2010 19:34:07 +0200
Subject: [PATCH] 125 run ftrunc with relative path
Since ftrunc is invoked with su $qa_user, it can fail when absolute path
is not accessible to everyone.
---
125 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/125 b/125
index e84109a..9a29941 100755
--- a/125
+++ b/125
@@ -61,7 +61,7 @@ touch $TESTFILE
chmod a+rw $TESTDIR
chmod a+rw $TESTFILE
-su $qa_user -c "$here/src/ftrunc -f $TESTFILE"
+su $qa_user -c "./src/ftrunc -f $TESTFILE"
if [ "$?" != "0" ]; then
echo src/ftrunc returned non 0 status!
--
1.6.6.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] 125 run ftrunc with relative path
2010-04-16 7:27 [PATCH] 125 run ftrunc with relative path Lukas Czerner
@ 2010-04-16 15:48 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2010-04-16 15:48 UTC (permalink / raw)
To: Lukas Czerner; +Cc: xfs
On 04/16/2010 02:27 AM, Lukas Czerner wrote:
> From 16588d733e681954386f1b92dd6e47cfef92a207 Mon Sep 17 00:00:00 2001
> From: Lukas Czerner <lczerner@redhat.com>
> Date: Tue, 13 Apr 2010 19:34:07 +0200
> Subject: [PATCH] 125 run ftrunc with relative path
>
> Since ftrunc is invoked with su $qa_user, it can fail when absolute path
> is not accessible to everyone.
Looks right to me.
After talking w/ you on IRC, I'll take the liberty of adding your
signed-off-by: to the patch, and check it in with my reviewed-by:
Thanks,
-Eric
> ---
> 125 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/125 b/125
> index e84109a..9a29941 100755
> --- a/125
> +++ b/125
> @@ -61,7 +61,7 @@ touch $TESTFILE
> chmod a+rw $TESTDIR
> chmod a+rw $TESTFILE
>
> -su $qa_user -c "$here/src/ftrunc -f $TESTFILE"
> +su $qa_user -c "./src/ftrunc -f $TESTFILE"
>
> if [ "$?" != "0" ]; then
> echo src/ftrunc returned non 0 status!
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-16 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-16 7:27 [PATCH] 125 run ftrunc with relative path Lukas Czerner
2010-04-16 15:48 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.