* [PATCH] time: jiffies.c: fix typos in comment
@ 2010-10-23 16:06 Serafeim Zanikolas
2010-10-24 14:22 ` Thomas Gleixner
0 siblings, 1 reply; 4+ messages in thread
From: Serafeim Zanikolas @ 2010-10-23 16:06 UTC (permalink / raw)
To: linux-kernel
Signed-off-by: Serafeim Zanikolas <sez@debian.org>
---
kernel/time/jiffies.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
index 5404a84..12ba9a7 100644
--- a/kernel/time/jiffies.c
+++ b/kernel/time/jiffies.c
@@ -30,8 +30,8 @@
* the timer interrupt frequency HZ and it suffers
* inaccuracies caused by missed or lost timer
* interrupts and the inability for the timer
- * interrupt hardware to accuratly tick at the
- * requested HZ value. It is also not reccomended
+ * interrupt hardware to accurately tick at the
+ * requested HZ value. It is also not recommended
* for "tick-less" systems.
*/
#define NSEC_PER_JIFFY ((u32)((((u64)NSEC_PER_SEC)<<8)/ACTHZ))
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] time: jiffies.c: fix typos in comment
2010-10-23 16:06 [PATCH] time: jiffies.c: fix typos in comment Serafeim Zanikolas
@ 2010-10-24 14:22 ` Thomas Gleixner
2010-10-24 17:01 ` Kyle Moffett
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Gleixner @ 2010-10-24 14:22 UTC (permalink / raw)
To: Serafeim Zanikolas; +Cc: linux-kernel
On Sat, 23 Oct 2010, Serafeim Zanikolas wrote:
>
> Signed-off-by: Serafeim Zanikolas <sez@debian.org>
> ---
> kernel/time/jiffies.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
> index 5404a84..12ba9a7 100644
> --- a/kernel/time/jiffies.c
> +++ b/kernel/time/jiffies.c
> @@ -30,8 +30,8 @@
> * the timer interrupt frequency HZ and it suffers
> * inaccuracies caused by missed or lost timer
> * interrupts and the inability for the timer
> - * interrupt hardware to accuratly tick at the
> - * requested HZ value. It is also not reccomended
> + * interrupt hardware to accurately tick at the
> + * requested HZ value. It is also not recommended
> * for "tick-less" systems.
You are not only correcting a typo. You are changing the sense of the
comment, unfortunately in the wrong way.
Why wouldn't it be recommended that the interrupt hardware ticks at
the requested HZ value ?
The inability of it to tick accurately at the requested HZ value is
one of the causes which make jiffies clocksource inaccurate. And that
what the comment says.
Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] time: jiffies.c: fix typos in comment
2010-10-24 14:22 ` Thomas Gleixner
@ 2010-10-24 17:01 ` Kyle Moffett
2010-10-24 18:08 ` Thomas Gleixner
0 siblings, 1 reply; 4+ messages in thread
From: Kyle Moffett @ 2010-10-24 17:01 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Serafeim Zanikolas, linux-kernel
On Sun, Oct 24, 2010 at 10:22, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Sat, 23 Oct 2010, Serafeim Zanikolas wrote:
>> diff --git a/kernel/time/jiffies.c b/kernel/time/jiffies.c
>> index 5404a84..12ba9a7 100644
>> --- a/kernel/time/jiffies.c
>> +++ b/kernel/time/jiffies.c
>> @@ -30,8 +30,8 @@
>> * the timer interrupt frequency HZ and it suffers
>> * inaccuracies caused by missed or lost timer
>> * interrupts and the inability for the timer
>> - * interrupt hardware to accuratly tick at the
>> - * requested HZ value. It is also not reccomended
>> + * interrupt hardware to accurately tick at the
>> + * requested HZ value. It is also not recommended
>> * for "tick-less" systems.
>
> You are not only correcting a typo. You are changing the sense of the
> comment, unfortunately in the wrong way.
>
> Why wouldn't it be recommended that the interrupt hardware ticks at
> the requested HZ value ?
>
> The inability of it to tick accurately at the requested HZ value is
> one of the causes which make jiffies clocksource inaccurate. And that
> what the comment says.
Thomas,
Please reread the patch again, I think it does exactly what he said it
did. Specifically, the old text is:
>> * the timer interrupt frequency HZ and it suffers
>> * inaccuracies caused by missed or lost timer
>> * interrupts and the inability for the timer
>> * interrupt hardware to accuratly tick at the
>> * requested HZ value. It is also not reccomended
>> * for "tick-less" systems.
While the new text is:
>> * the timer interrupt frequency HZ and it suffers
>> * inaccuracies caused by missed or lost timer
>> * interrupts and the inability for the timer
>> * interrupt hardware to accurately tick at the
>> * requested HZ value. It is also not recommended
>> * for "tick-less" systems.
I misread it the first time myself, mentally combining the second line
of the old text with the new text; what you probably saw was:
>> - * requested HZ value. It is also not reccomended
>> + * interrupt hardware to accurately tick at the
>> + * requested HZ value.
Cheers,
Kyle Moffett
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] time: jiffies.c: fix typos in comment
2010-10-24 17:01 ` Kyle Moffett
@ 2010-10-24 18:08 ` Thomas Gleixner
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2010-10-24 18:08 UTC (permalink / raw)
To: Kyle Moffett; +Cc: Serafeim Zanikolas, linux-kernel
On Sun, 24 Oct 2010, Kyle Moffett wrote:
> Thomas,
>
> Please reread the patch again, I think it does exactly what he said it
> did. Specifically, the old text is:
> >> * the timer interrupt frequency HZ and it suffers
> >> * inaccuracies caused by missed or lost timer
> >> * interrupts and the inability for the timer
> >> * interrupt hardware to accuratly tick at the
> >> * requested HZ value. It is also not reccomended
> >> * for "tick-less" systems.
>
> While the new text is:
> >> * the timer interrupt frequency HZ and it suffers
> >> * inaccuracies caused by missed or lost timer
> >> * interrupts and the inability for the timer
> >> * interrupt hardware to accurately tick at the
> >> * requested HZ value. It is also not recommended
> >> * for "tick-less" systems.
>
> I misread it the first time myself, mentally combining the second line
> of the old text with the new text; what you probably saw was:
>
> >> - * requested HZ value. It is also not reccomended
> >> + * interrupt hardware to accurately tick at the
> >> + * requested HZ value.
Crap yes. I read it twice and still failed to parse it correctly.
Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-24 18:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-23 16:06 [PATCH] time: jiffies.c: fix typos in comment Serafeim Zanikolas
2010-10-24 14:22 ` Thomas Gleixner
2010-10-24 17:01 ` Kyle Moffett
2010-10-24 18:08 ` Thomas Gleixner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.