From: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> To: "Kirill A. Shutsemov" <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> Cc: jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Arjan van de Ven <arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Subject: Re: [PATCH, v6 2/3] Implement timer slack notifier chain Date: Mon, 14 Feb 2011 14:32:23 +0100 (CET) [thread overview] Message-ID: <alpine.LFD.2.00.1102141428080.26192@localhost6.localdomain6> (raw) In-Reply-To: <1297688787-3592-3-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> On Mon, 14 Feb 2011, Kirill A. Shutsemov wrote: > From: Kirill A. Shutemov <kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> > > Process can change its timer slack using prctl(). Timer slack notifier > call chain allows to react on such change or forbid it. So we add a notifier call chain and more exports to allow what ? > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -1691,15 +1691,10 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, > error = perf_event_task_enable(); > break; > case PR_GET_TIMERSLACK: > - error = current->timer_slack_ns; > + error = prctl_get_timer_slack(); What's the point of replacing current->timer_slack_ns with a function which does exactly the same ? > +long prctl_set_timer_slack(long timer_slack_ns) > +{ > + int err; > + > + /* Reset timer slack to default value */ > + if (timer_slack_ns <= 0) { > + current->timer_slack_ns = current->default_timer_slack_ns; > + return 0; That does not make any sense at all. Why is setting default_timer_slack_ns not subject to validation ? Why is it treaded seperately ? > + } > + > + err = blocking_notifier_call_chain(&timer_slack_notify_list, > + timer_slack_ns, NULL); > + if (err == NOTIFY_DONE) > + current->timer_slack_ns = timer_slack_ns; > + > + return notifier_to_errno(err); Thanks, tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: "Kirill A. Shutsemov" <kirill@shutemov.name> Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>, containers@lists.linux-foundation.org, jacob.jun.pan@linux.intel.com, Arjan van de Ven <arjan@linux.intel.com>, linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, linux-api@vger.kernel.org Subject: Re: [PATCH, v6 2/3] Implement timer slack notifier chain Date: Mon, 14 Feb 2011 14:32:23 +0100 (CET) [thread overview] Message-ID: <alpine.LFD.2.00.1102141428080.26192@localhost6.localdomain6> (raw) In-Reply-To: <1297688787-3592-3-git-send-email-kirill@shutemov.name> On Mon, 14 Feb 2011, Kirill A. Shutsemov wrote: > From: Kirill A. Shutemov <kirill@shutemov.name> > > Process can change its timer slack using prctl(). Timer slack notifier > call chain allows to react on such change or forbid it. So we add a notifier call chain and more exports to allow what ? > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -1691,15 +1691,10 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, > error = perf_event_task_enable(); > break; > case PR_GET_TIMERSLACK: > - error = current->timer_slack_ns; > + error = prctl_get_timer_slack(); What's the point of replacing current->timer_slack_ns with a function which does exactly the same ? > +long prctl_set_timer_slack(long timer_slack_ns) > +{ > + int err; > + > + /* Reset timer slack to default value */ > + if (timer_slack_ns <= 0) { > + current->timer_slack_ns = current->default_timer_slack_ns; > + return 0; That does not make any sense at all. Why is setting default_timer_slack_ns not subject to validation ? Why is it treaded seperately ? > + } > + > + err = blocking_notifier_call_chain(&timer_slack_notify_list, > + timer_slack_ns, NULL); > + if (err == NOTIFY_DONE) > + current->timer_slack_ns = timer_slack_ns; > + > + return notifier_to_errno(err); Thanks, tglx
next prev parent reply other threads:[~2011-02-14 13:32 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-14 13:06 [PATCH, v6 0/3] Introduce timer slack controller Kirill A. Shutsemov 2011-02-14 13:06 ` Kirill A. Shutsemov 2011-02-14 13:06 ` [PATCH, v6 1/3] cgroups: export cgroup_iter_{start,next,end} Kirill A. Shutsemov 2011-02-14 13:27 ` Thomas Gleixner 2011-02-14 14:39 ` Kirill A. Shutemov 2011-02-14 14:39 ` Kirill A. Shutemov 2011-02-14 15:09 ` Thomas Gleixner 2011-02-14 15:09 ` Thomas Gleixner [not found] ` <20110214143902.GA3666-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 15:09 ` Thomas Gleixner [not found] ` <alpine.LFD.2.00.1102141421500.26192-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org> 2011-02-14 14:39 ` Kirill A. Shutemov [not found] ` <1297688787-3592-2-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 13:27 ` Thomas Gleixner 2011-02-14 13:06 ` [PATCH, v6 2/3] Implement timer slack notifier chain Kirill A. Shutsemov 2011-02-14 13:06 ` Kirill A. Shutsemov [not found] ` <1297688787-3592-3-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 13:32 ` Thomas Gleixner [this message] 2011-02-14 13:32 ` Thomas Gleixner 2011-02-14 14:52 ` Kirill A. Shutemov 2011-02-14 14:52 ` Kirill A. Shutemov 2011-02-14 15:16 ` Thomas Gleixner 2011-02-14 15:16 ` Thomas Gleixner [not found] ` <20110214145244.GB3666-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 15:16 ` Thomas Gleixner [not found] ` <alpine.LFD.2.00.1102141428080.26192-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org> 2011-02-14 14:52 ` Kirill A. Shutemov 2011-02-14 13:06 ` [PATCH, v6 3/3] cgroups: introduce timer slack controller Kirill A. Shutsemov 2011-02-14 13:59 ` Matt Helsley 2011-02-14 13:59 ` Matt Helsley 2011-02-14 22:59 ` Kirill A. Shutemov 2011-02-14 22:59 ` Kirill A. Shutemov 2011-02-15 0:00 ` Matt Helsley 2011-02-15 0:00 ` Matt Helsley [not found] ` <20110215000055.GR16432-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org> 2011-02-15 0:10 ` Kirill A. Shutemov 2011-02-15 0:10 ` Kirill A. Shutemov 2011-02-15 0:10 ` Kirill A. Shutemov 2011-02-15 0:10 ` Kirill A. Shutemov [not found] ` <20110214225940.GB6230-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-15 0:00 ` Matt Helsley [not found] ` <20110214135926.GO16432-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org> 2011-02-14 22:59 ` Kirill A. Shutemov 2011-02-14 14:00 ` Thomas Gleixner 2011-02-14 15:19 ` Kirill A. Shutemov 2011-02-14 15:19 ` Kirill A. Shutemov [not found] ` <20110214151914.GA4210-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 17:01 ` Thomas Gleixner 2011-02-14 17:01 ` Thomas Gleixner 2011-02-14 17:01 ` Thomas Gleixner 2011-02-14 22:39 ` Kirill A. Shutemov 2011-02-14 22:39 ` Kirill A. Shutemov 2011-02-14 23:39 ` Matt Helsley 2011-02-14 23:39 ` Matt Helsley 2011-02-15 6:04 ` Thomas Gleixner 2011-02-15 6:04 ` Thomas Gleixner [not found] ` <20110214223939.GA6230-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 23:39 ` Matt Helsley 2011-02-15 6:04 ` Thomas Gleixner [not found] ` <alpine.LFD.2.00.1102141753240.26192-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org> 2011-02-14 22:39 ` Kirill A. Shutemov [not found] ` <alpine.LFD.2.00.1102141432440.26192-bi+AKbBUZKagILUCTcTcHdKyNwTtLsGr@public.gmane.org> 2011-02-14 15:19 ` Kirill A. Shutemov [not found] ` <1297688787-3592-4-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 13:59 ` Matt Helsley 2011-02-14 14:00 ` Thomas Gleixner 2011-02-14 13:26 ` [PATCH, v6 0/3] Introduce " Thomas Gleixner 2011-02-14 13:26 ` Thomas Gleixner [not found] ` <1297688787-3592-1-git-send-email-kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org> 2011-02-14 13:06 ` [PATCH, v6 1/3] cgroups: export cgroup_iter_{start,next,end} Kirill A. Shutsemov 2011-02-14 13:06 ` [PATCH, v6 2/3] Implement timer slack notifier chain Kirill A. Shutsemov 2011-02-14 13:06 ` [PATCH, v6 3/3] cgroups: introduce timer slack controller Kirill A. Shutsemov 2011-02-14 13:26 ` [PATCH, v6 0/3] Introduce " Thomas Gleixner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LFD.2.00.1102141428080.26192@localhost6.localdomain6 \ --to=tglx-hfztesqfncyowbw4kg4ksq@public.gmane.org \ --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \ --cc=arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \ --cc=jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org \ --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.