* [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.
@ 2014-06-05 11:55 chishanmingshen
2014-06-23 9:08 ` Lukáš Czerner
0 siblings, 1 reply; 3+ messages in thread
From: chishanmingshen @ 2014-06-05 11:55 UTC (permalink / raw)
To: Alexander Viro; +Cc: linux-fsdevel, chishanmingshen
Just skip the unrelated buffer heads when clear buffer head's BH_new flag.
This patch is *untested*.
Signed-off-by: chishanmingshen <chishanmingshen@gmail.com>
---
fs/buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index 9ddb9fc..a28a1a1 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1987,8 +1987,8 @@ static int __block_commit_write(struct inode *inode, struct page *page,
} else {
set_buffer_uptodate(bh);
mark_buffer_dirty(bh);
+ clear_buffer_new(bh);
}
- clear_buffer_new(bh);
block_start = block_end;
bh = bh->b_this_page;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.
2014-06-05 11:55 [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads chishanmingshen
@ 2014-06-23 9:08 ` Lukáš Czerner
0 siblings, 0 replies; 3+ messages in thread
From: Lukáš Czerner @ 2014-06-23 9:08 UTC (permalink / raw)
To: chishanmingshen; +Cc: Alexander Viro, linux-fsdevel
On Thu, 5 Jun 2014, chishanmingshen wrote:
> Date: Thu, 5 Jun 2014 19:55:09 +0800
> From: chishanmingshen <chishanmingshen@gmail.com>
> To: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org, chishanmingshen <chishanmingshen@gmail.com>
> Subject: [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.
>
> Just skip the unrelated buffer heads when clear buffer head's BH_new flag.
I can see that from the code, but can you explain why in the commit
description ?
Thanks!
-Lukas
> This patch is *untested*.
>
> Signed-off-by: chishanmingshen <chishanmingshen@gmail.com>
> ---
> fs/buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 9ddb9fc..a28a1a1 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -1987,8 +1987,8 @@ static int __block_commit_write(struct inode *inode, struct page *page,
> } else {
> set_buffer_uptodate(bh);
> mark_buffer_dirty(bh);
> + clear_buffer_new(bh);
> }
> - clear_buffer_new(bh);
>
> block_start = block_end;
> bh = bh->b_this_page;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.
@ 2014-06-06 9:31 chishanmingshen
0 siblings, 0 replies; 3+ messages in thread
From: chishanmingshen @ 2014-06-06 9:31 UTC (permalink / raw)
To: Alexander Viro; +Cc: linux-fsdevel, linux-kernel, chishanmingshen
Just skip the unrelated buffer heads when clear buffer head's BH_new flag.
This patch is *untested*.
Signed-off-by: chishanmingshen <chishanmingshen@gmail.com>
---
fs/buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index 9ddb9fc..a28a1a1 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1987,8 +1987,8 @@ static int __block_commit_write(struct inode *inode, struct page *page,
} else {
set_buffer_uptodate(bh);
mark_buffer_dirty(bh);
+ clear_buffer_new(bh);
}
- clear_buffer_new(bh);
block_start = block_end;
bh = bh->b_this_page;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-23 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-05 11:55 [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads chishanmingshen
2014-06-23 9:08 ` Lukáš Czerner
2014-06-06 9:31 chishanmingshen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.