From: Thomas Gleixner <tglx@linutronix.de>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, grant.likely@secretlab.ca,
marc.zyngier@arm.com, thomas.abraham@linaro.org,
jamie@jamieiles.com, b-cousson@ti.com, shawn.guo@linaro.org,
Rob Herring <rob.herring@calxeda.com>
Subject: Re: [PATCH 2/5] irq: fix existing domain check in irq_domain_add
Date: Wed, 14 Sep 2011 18:44:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109141838510.2723@ionos> (raw)
In-Reply-To: <1316017900-19918-3-git-send-email-robherring2@gmail.com>
On Wed, 14 Sep 2011, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> irq_data will normally exist, so the domain was prevented from being set.
> The simple domain code did not hit this as nr_irq is always 0.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Thomas Gleixner <tglx@linutronix.de>
I take this and 1/5 through irq/urgent
Thanks,
tglx
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index d5828da..84f4110 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -29,7 +29,7 @@ void irq_domain_add(struct irq_domain *domain)
> */
> for (hwirq = 0; hwirq < domain->nr_irq; hwirq++) {
> d = irq_get_irq_data(irq_domain_to_irq(domain, hwirq));
> - if (d || d->domain) {
> + if (d && d->domain) {
> /* things are broken; just report, don't clean up */
> WARN(1, "error: irq_desc already assigned to a domain");
> return;
> --
> 1.7.5.4
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/5] irq: fix existing domain check in irq_domain_add
Date: Wed, 14 Sep 2011 18:44:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109141838510.2723@ionos> (raw)
In-Reply-To: <1316017900-19918-3-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, 14 Sep 2011, Rob Herring wrote:
> From: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
>
> irq_data will normally exist, so the domain was prevented from being set.
> The simple domain code did not hit this as nr_irq is always 0.
>
> Signed-off-by: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
I take this and 1/5 through irq/urgent
Thanks,
tglx
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index d5828da..84f4110 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -29,7 +29,7 @@ void irq_domain_add(struct irq_domain *domain)
> */
> for (hwirq = 0; hwirq < domain->nr_irq; hwirq++) {
> d = irq_get_irq_data(irq_domain_to_irq(domain, hwirq));
> - if (d || d->domain) {
> + if (d && d->domain) {
> /* things are broken; just report, don't clean up */
> WARN(1, "error: irq_desc already assigned to a domain");
> return;
> --
> 1.7.5.4
>
>
WARNING: multiple messages have this Message-ID (diff)
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] irq: fix existing domain check in irq_domain_add
Date: Wed, 14 Sep 2011 18:44:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1109141838510.2723@ionos> (raw)
In-Reply-To: <1316017900-19918-3-git-send-email-robherring2@gmail.com>
On Wed, 14 Sep 2011, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> irq_data will normally exist, so the domain was prevented from being set.
> The simple domain code did not hit this as nr_irq is always 0.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Thomas Gleixner <tglx@linutronix.de>
I take this and 1/5 through irq/urgent
Thanks,
tglx
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index d5828da..84f4110 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -29,7 +29,7 @@ void irq_domain_add(struct irq_domain *domain)
> */
> for (hwirq = 0; hwirq < domain->nr_irq; hwirq++) {
> d = irq_get_irq_data(irq_domain_to_irq(domain, hwirq));
> - if (d || d->domain) {
> + if (d && d->domain) {
> /* things are broken; just report, don't clean up */
> WARN(1, "error: irq_desc already assigned to a domain");
> return;
> --
> 1.7.5.4
>
>
next prev parent reply other threads:[~2011-09-14 16:44 UTC|newest]
Thread overview: 164+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 16:31 [PATCH 0/5] GIC OF bindings Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 16:31 ` [PATCH 1/5] irq: add declaration of irq_domain_simple_ops to irqdomain.h Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 16:31 ` [PATCH 2/5] irq: fix existing domain check in irq_domain_add Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 16:44 ` Thomas Gleixner [this message]
2011-09-14 16:44 ` Thomas Gleixner
2011-09-14 16:44 ` Thomas Gleixner
2011-09-17 23:24 ` Grant Likely
2011-09-17 23:24 ` Grant Likely
2011-09-17 23:24 ` Grant Likely
2011-09-14 16:31 ` [PATCH 3/5] of/irq: introduce of_irq_init Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-15 10:41 ` Arnd Bergmann
2011-09-15 10:41 ` Arnd Bergmann
2011-09-15 10:41 ` Arnd Bergmann
2011-09-17 23:53 ` Grant Likely
2011-09-17 23:53 ` Grant Likely
2011-09-17 23:53 ` Grant Likely
2011-09-18 1:37 ` Rob Herring
2011-09-18 1:37 ` Rob Herring
2011-09-18 1:37 ` Rob Herring
2011-09-18 6:02 ` Grant Likely
2011-09-18 6:02 ` Grant Likely
2011-09-18 6:02 ` Grant Likely
2011-09-14 16:31 ` [PATCH 4/5] ARM: gic: allow irq_start to be 0 Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-18 6:24 ` Grant Likely
2011-09-18 6:24 ` Grant Likely
2011-09-18 6:24 ` Grant Likely
2011-09-18 12:03 ` Russell King - ARM Linux
2011-09-18 12:03 ` Russell King - ARM Linux
2011-09-18 12:03 ` Russell King - ARM Linux
2011-09-14 16:31 ` [PATCH 5/5] ARM: gic: add OF based initialization Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 16:31 ` Rob Herring
2011-09-14 17:46 ` Marc Zyngier
2011-09-14 17:46 ` Marc Zyngier
2011-09-14 17:46 ` Marc Zyngier
2011-09-14 17:57 ` Rob Herring
2011-09-14 17:57 ` Rob Herring
2011-09-14 17:57 ` Rob Herring
2011-09-14 18:34 ` Marc Zyngier
2011-09-14 18:34 ` Marc Zyngier
2011-09-14 18:34 ` Marc Zyngier
2011-09-14 18:51 ` Rob Herring
2011-09-14 18:51 ` Rob Herring
2011-09-14 18:51 ` Rob Herring
2011-09-18 0:13 ` Grant Likely
2011-09-18 0:13 ` Grant Likely
2011-09-18 0:13 ` Grant Likely
2011-09-15 7:55 ` Thomas Abraham
2011-09-15 7:55 ` Thomas Abraham
2011-09-15 10:07 ` Cousson, Benoit
2011-09-15 10:07 ` Cousson, Benoit
2011-09-15 10:07 ` Cousson, Benoit
2011-09-15 10:29 ` Russell King - ARM Linux
2011-09-15 10:29 ` Russell King - ARM Linux
2011-09-15 10:29 ` Russell King - ARM Linux
2011-09-15 12:28 ` Cousson, Benoit
2011-09-15 12:28 ` Cousson, Benoit
2011-09-15 12:28 ` Cousson, Benoit
2011-09-15 12:51 ` Russell King - ARM Linux
2011-09-15 12:51 ` Russell King - ARM Linux
2011-09-15 12:51 ` Russell King - ARM Linux
2011-09-15 13:03 ` Cousson, Benoit
2011-09-15 13:03 ` Cousson, Benoit
2011-09-15 13:03 ` Cousson, Benoit
2011-09-15 13:11 ` Rob Herring
2011-09-15 13:11 ` Rob Herring
2011-09-15 13:11 ` Rob Herring
2011-09-15 13:52 ` Cousson, Benoit
2011-09-15 13:52 ` Cousson, Benoit
2011-09-15 13:52 ` Cousson, Benoit
2011-09-15 16:43 ` Rob Herring
2011-09-15 16:43 ` Rob Herring
2011-09-15 16:43 ` Rob Herring
2011-09-18 21:23 ` Rob Herring
2011-09-18 21:23 ` Rob Herring
2011-09-18 21:23 ` Rob Herring
2011-09-19 12:09 ` Cousson, Benoit
2011-09-19 12:09 ` Cousson, Benoit
2011-09-19 12:09 ` Cousson, Benoit
2011-09-19 13:48 ` Rob Herring
2011-09-19 13:48 ` Rob Herring
2011-09-19 13:48 ` Rob Herring
2011-09-19 14:32 ` Cousson, Benoit
2011-09-19 14:32 ` Cousson, Benoit
2011-09-19 14:32 ` Cousson, Benoit
2011-09-19 21:14 ` Grant Likely
2011-09-19 21:14 ` Grant Likely
2011-09-19 21:14 ` Grant Likely
2011-09-19 21:53 ` Rob Herring
2011-09-19 21:53 ` Rob Herring
2011-09-19 21:53 ` Rob Herring
2011-09-20 0:22 ` Grant Likely
2011-09-20 0:22 ` Grant Likely
2011-09-20 0:22 ` Grant Likely
2011-09-20 4:18 ` Grant Likely
2011-09-20 4:18 ` Grant Likely
2011-09-20 4:18 ` Grant Likely
2011-09-20 15:23 ` Cousson, Benoit
2011-09-20 15:23 ` Cousson, Benoit
2011-09-20 15:23 ` Cousson, Benoit
2011-09-19 16:00 ` Russell King - ARM Linux
2011-09-19 16:00 ` Russell King - ARM Linux
2011-09-19 16:00 ` Russell King - ARM Linux
2011-09-19 20:49 ` Grant Likely
2011-09-19 20:49 ` Grant Likely
2011-09-19 20:49 ` Grant Likely
2011-09-19 9:47 ` Cousson, Benoit
2011-09-19 9:47 ` Cousson, Benoit
2011-09-19 9:47 ` Cousson, Benoit
2011-09-19 13:33 ` Russell King - ARM Linux
2011-09-19 13:33 ` Russell King - ARM Linux
2011-09-19 13:33 ` Russell King - ARM Linux
2011-09-19 17:44 ` Grant Likely
2011-09-19 17:44 ` Grant Likely
2011-09-19 17:44 ` Grant Likely
2011-09-16 16:09 ` Dave Martin
2011-09-16 16:09 ` Dave Martin
2011-09-16 16:09 ` Dave Martin
2011-09-18 6:21 ` Grant Likely
2011-09-18 6:21 ` Grant Likely
2011-09-18 6:21 ` Grant Likely
2011-09-19 12:07 ` Dave Martin
2011-09-19 12:07 ` Dave Martin
2011-09-19 12:07 ` Dave Martin
2011-09-19 13:08 ` Cousson, Benoit
2011-09-19 13:08 ` Cousson, Benoit
2011-09-19 13:08 ` Cousson, Benoit
2011-09-18 6:15 ` Grant Likely
2011-09-18 6:15 ` Grant Likely
2011-09-18 6:15 ` Grant Likely
2011-09-19 8:47 ` Cousson, Benoit
2011-09-19 8:47 ` Cousson, Benoit
2011-09-19 8:47 ` Cousson, Benoit
2011-09-15 12:54 ` Rob Herring
2011-09-15 12:54 ` Rob Herring
2011-09-15 12:54 ` Rob Herring
2011-09-16 9:34 ` Thomas Abraham
2011-09-16 9:34 ` Thomas Abraham
2011-09-16 9:34 ` Thomas Abraham
2011-09-18 6:10 ` Grant Likely
2011-09-18 6:10 ` Grant Likely
2011-09-18 6:10 ` Grant Likely
2011-09-19 12:59 ` Thomas Abraham
2011-09-19 12:59 ` Thomas Abraham
2011-09-19 12:59 ` Thomas Abraham
2011-09-15 10:43 ` Arnd Bergmann
2011-09-15 10:43 ` Arnd Bergmann
2011-09-15 10:43 ` Arnd Bergmann
2011-09-18 6:30 ` Grant Likely
2011-09-18 6:30 ` Grant Likely
2011-09-18 6:30 ` Grant Likely
2011-09-15 8:50 ` [PATCH 0/5] GIC OF bindings Jamie Iles
2011-09-15 8:50 ` Jamie Iles
2011-09-15 13:53 ` Shawn Guo
2011-09-15 13:53 ` Shawn Guo
2011-09-15 13:53 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1109141838510.2723@ionos \
--to=tglx@linutronix.de \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.