All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Magnus Damm <damm@opensource.se>,
	Linus Walleij <linus.walleij@linaro.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH 2/9] ARM: export set_irq_flags
Date: Tue, 9 Oct 2012 18:20:13 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1210091820020.10988@ionos> (raw)
In-Reply-To: <1349796183-30648-3-git-send-email-arnd@arndb.de>



On Tue, 9 Oct 2012, Arnd Bergmann wrote:

> The recently added Emma Mobile GPIO driver calls set_irq_flags
> and irq_set_chip_and_handler for the interrupts it exports and
> it can be built as a module, which currently fails with
> 
> ERROR: "set_irq_flags" [drivers/gpio/gpio-em.ko] undefined!
> 
> We either need to replace the call to set_irq_flags with something
> else or export that function. This patch does the latter.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Thomas Gleixner <tglx@linutronix.de>

Acked-by-me

> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
>  arch/arm/kernel/irq.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
> index 16cedb4..8961650 100644
> --- a/arch/arm/kernel/irq.c
> +++ b/arch/arm/kernel/irq.c
> @@ -34,6 +34,7 @@
>  #include <linux/list.h>
>  #include <linux/kallsyms.h>
>  #include <linux/proc_fs.h>
> +#include <linux/export.h>
>  
>  #include <asm/exception.h>
>  #include <asm/mach/arch.h>
> @@ -109,6 +110,7 @@ void set_irq_flags(unsigned int irq, unsigned int iflags)
>  	/* Order is clear bits in "clr" then set bits in "set" */
>  	irq_modify_status(irq, clr, set & ~clr);
>  }
> +EXPORT_SYMBOL_GPL(set_irq_flags);
>  
>  void __init init_IRQ(void)
>  {
> -- 
> 1.7.10
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] ARM: export set_irq_flags
Date: Tue, 9 Oct 2012 18:20:13 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1210091820020.10988@ionos> (raw)
In-Reply-To: <1349796183-30648-3-git-send-email-arnd@arndb.de>



On Tue, 9 Oct 2012, Arnd Bergmann wrote:

> The recently added Emma Mobile GPIO driver calls set_irq_flags
> and irq_set_chip_and_handler for the interrupts it exports and
> it can be built as a module, which currently fails with
> 
> ERROR: "set_irq_flags" [drivers/gpio/gpio-em.ko] undefined!
> 
> We either need to replace the call to set_irq_flags with something
> else or export that function. This patch does the latter.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Thomas Gleixner <tglx@linutronix.de>

Acked-by-me

> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
>  arch/arm/kernel/irq.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
> index 16cedb4..8961650 100644
> --- a/arch/arm/kernel/irq.c
> +++ b/arch/arm/kernel/irq.c
> @@ -34,6 +34,7 @@
>  #include <linux/list.h>
>  #include <linux/kallsyms.h>
>  #include <linux/proc_fs.h>
> +#include <linux/export.h>
>  
>  #include <asm/exception.h>
>  #include <asm/mach/arch.h>
> @@ -109,6 +110,7 @@ void set_irq_flags(unsigned int irq, unsigned int iflags)
>  	/* Order is clear bits in "clr" then set bits in "set" */
>  	irq_modify_status(irq, clr, set & ~clr);
>  }
> +EXPORT_SYMBOL_GPL(set_irq_flags);
>  
>  void __init init_IRQ(void)
>  {
> -- 
> 1.7.10
> 
> 

  reply	other threads:[~2012-10-09 16:20 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09 15:22 [GIT PULL 0/9] ARM architecture fixes for 3.7 Arnd Bergmann
2012-10-09 15:22 ` Arnd Bergmann
2012-10-09 15:22 ` Arnd Bergmann
2012-10-09 15:22 ` [PATCH 1/9] ARM: kprobes: make more tests conditional Arnd Bergmann
2012-10-09 15:22   ` Arnd Bergmann
2012-10-09 15:22 ` [PATCH 2/9] ARM: export set_irq_flags Arnd Bergmann
2012-10-09 15:22   ` Arnd Bergmann
2012-10-09 16:20   ` Thomas Gleixner [this message]
2012-10-09 16:20     ` Thomas Gleixner
2012-10-10  6:42   ` Linus Walleij
2012-10-10  6:42     ` Linus Walleij
2012-10-09 15:22 ` [PATCH 3/9] ARM: Fix another build warning in arch/arm/mm/alignment.c Arnd Bergmann
2012-10-09 15:22   ` Arnd Bergmann
2012-10-09 15:22 ` [PATCH 4/9] ARM: export default read_current_timer Arnd Bergmann
2012-10-09 15:22   ` Arnd Bergmann
2012-10-09 15:40   ` Jonathan Austin
2012-10-09 15:40     ` Jonathan Austin
2012-10-09 16:06     ` Russell King - ARM Linux
2012-10-09 16:06       ` Russell King - ARM Linux
2012-10-18  8:43       ` Alexander Holler
2012-10-18  8:43         ` Alexander Holler
2012-10-09 15:22 ` [PATCH 5/9] ARM: Xen: fix initial build problems: Arnd Bergmann
2012-10-09 15:22   ` Arnd Bergmann
2012-10-09 15:35   ` [Xen-devel] " Ian Campbell
2012-10-09 15:35     ` Ian Campbell
2012-10-09 15:35     ` Ian Campbell
2012-10-09 15:39     ` Arnd Bergmann
2012-10-09 15:39       ` Arnd Bergmann
2012-10-09 15:39       ` Arnd Bergmann
2012-10-09 16:10       ` Ian Campbell
2012-10-09 16:10         ` Ian Campbell
2012-10-09 16:10         ` Ian Campbell
2012-10-09 18:19         ` Arnd Bergmann
2012-10-09 18:19           ` Arnd Bergmann
2012-10-09 18:19           ` Arnd Bergmann
2012-10-10  9:46           ` Ian Campbell
2012-10-10  9:46             ` Ian Campbell
2012-10-10  9:46             ` Ian Campbell
2012-10-10 11:07             ` Arnd Bergmann
2012-10-10 11:07               ` Arnd Bergmann
2012-10-10 11:07               ` Arnd Bergmann
2012-10-09 19:24     ` Dan Magenheimer
2012-10-10  7:53       ` Ian Campbell
2012-10-10 14:51         ` Stefano Stabellini
2012-10-09 15:37   ` Stefano Stabellini
2012-10-09 15:37     ` Stefano Stabellini
2012-10-09 15:37     ` Stefano Stabellini
2012-10-09 18:21     ` Arnd Bergmann
2012-10-09 18:21       ` Arnd Bergmann
2012-10-09 18:21       ` Arnd Bergmann
2012-10-10  7:54       ` [Xen-devel] " Ian Campbell
2012-10-10  7:54         ` Ian Campbell
2012-10-10  7:54         ` Ian Campbell
2012-10-10 14:47         ` Stefano Stabellini
2012-10-10 14:47           ` Stefano Stabellini
2012-10-10 14:47           ` Stefano Stabellini
2012-10-10 14:53           ` Ian Campbell
2012-10-10 14:53             ` Ian Campbell
2012-10-10 14:53             ` Ian Campbell
2012-10-10 16:01             ` Stefano Stabellini
2012-10-10 16:01               ` Stefano Stabellini
2012-10-10 16:01               ` Stefano Stabellini
2012-10-09 16:04   ` Russell King - ARM Linux
2012-10-09 16:04     ` Russell King - ARM Linux
2012-10-09 15:23 ` [PATCH 6/9] ARM: pass -marm to gcc by default for both C and assembler Arnd Bergmann
2012-10-09 15:23   ` Arnd Bergmann
2012-10-09 17:27   ` Dave Martin
2012-10-09 17:27     ` Dave Martin
2012-10-09 15:23 ` [PATCH 7/9] ARM: be really quiet when building with 'make -s' Arnd Bergmann
2012-10-09 15:23   ` Arnd Bergmann
2012-10-09 15:23 ` [PATCH 8/9] ARM: binfmt_flat: unused variable 'persistent' Arnd Bergmann
2012-10-09 15:23   ` Arnd Bergmann
2012-10-09 15:23 ` [PATCH 9/9] ARM: warnings in arch/arm/include/asm/uaccess.h Arnd Bergmann
2012-10-09 15:23   ` Arnd Bergmann
2012-10-09 16:08 ` [GIT PULL 0/9] ARM architecture fixes for 3.7 Russell King - ARM Linux
2012-10-09 16:08   ` Russell King - ARM Linux
2012-10-09 17:06   ` Stefano Stabellini
2012-10-09 17:06     ` Stefano Stabellini
2012-10-09 17:06     ` Stefano Stabellini
2012-10-09 18:40   ` Arnd Bergmann
2012-10-09 18:40     ` Arnd Bergmann
2012-10-10 14:58     ` Stefano Stabellini
2012-10-10 14:58       ` Stefano Stabellini
2012-10-10 14:58       ` Stefano Stabellini
2012-10-12 13:20     ` Will Deacon
2012-10-12 13:20       ` Will Deacon
2012-10-12 13:20       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1210091820020.10988@ionos \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=damm@opensource.se \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.