* [PATCH] sched.h: Remove useless `const' from function return type
@ 2014-06-28 23:18 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2014-06-28 23:18 UTC (permalink / raw)
To: Vincent Guittot
Cc: Dietmar Eggemann, Preeti U Murthy, Dietmar Eggemann,
Peter Zijlstra, Andrew Morton, Benjamin Herrenschmidt,
Bjorn Helgaas, Chris Metcalf, Christoph Lameter, David S. Miller,
Fenghua Yu, Greg Kroah-Hartman, Hanjun Guo, Heiko Carstens,
Jason Low, Linus Torvalds, Martin Schwidefsky, Tony Luck,
linux390, linux-ia64, linux-s390, Ingo Molnar, linux-kernel
This fixes:
cc1: warnings being treated as errors
In file included from include/linux/ptrace.h:5,
from arch/mips/kernel/cpu-probe.c:16:
include/linux/sched.h:1002: warning: type qualifiers ignored on function return type
make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1
This is a regression introduced with commit
143e1e28cb40bed836b0a06567208bd7347c9672 [sched: Rework sched_domain
topology definition]. The warning itself is benign except in places like
the arch/mips subtree where we use `-Werror' to enforce good coding
practices. Apparently the warning is GCC-version specific, some versions
produce it and some do not.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
Vincent,
Did you mean:
typedef int __attribute__((const)) (*sched_domain_flags_f)(void);
by any chance?
Maciej
linux-sched-domain-flags-type.patch
Index: linux-20140623-swarm64/include/linux/sched.h
===================================================================
--- linux-20140623-swarm64.orig/include/linux/sched.h
+++ linux-20140623-swarm64/include/linux/sched.h
@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t do
bool cpus_share_cache(int this_cpu, int that_cpu);
typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
#define SDTL_OVERLAP 0x01
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sched.h: Remove useless `const' from function return type
@ 2014-06-28 23:18 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2014-06-28 23:18 UTC (permalink / raw)
To: Vincent Guittot; +Cc: Dietmar Eggemann, Preeti U Murthy
This fixes:
cc1: warnings being treated as errors
In file included from include/linux/ptrace.h:5,
from arch/mips/kernel/cpu-probe.c:16:
include/linux/sched.h:1002: warning: type qualifiers ignored on function return type
make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1
This is a regression introduced with commit
143e1e28cb40bed836b0a06567208bd7347c9672 [sched: Rework sched_domain
topology definition]. The warning itself is benign except in places like
the arch/mips subtree where we use `-Werror' to enforce good coding
practices. Apparently the warning is GCC-version specific, some versions
produce it and some do not.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
Vincent,
Did you mean:
typedef int __attribute__((const)) (*sched_domain_flags_f)(void);
by any chance?
Maciej
linux-sched-domain-flags-type.patch
Index: linux-20140623-swarm64/include/linux/sched.h
===================================================================
--- linux-20140623-swarm64.orig/include/linux/sched.h
+++ linux-20140623-swarm64/include/linux/sched.h
@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t do
bool cpus_share_cache(int this_cpu, int that_cpu);
typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
#define SDTL_OVERLAP 0x01
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] sched.h: Remove useless `const' from function return type
@ 2014-06-28 23:18 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2014-06-28 23:18 UTC (permalink / raw)
To: Vincent Guittot
Cc: Dietmar Eggemann, Preeti U Murthy, Dietmar Eggemann,
Peter Zijlstra, Andrew Morton, Benjamin Herrenschmidt,
Bjorn Helgaas, Chris Metcalf, Christoph Lameter, David S. Miller,
Fenghua Yu, Greg Kroah-Hartman, Hanjun Guo, Heiko Carstens,
Jason Low, Linus Torvalds, Martin Schwidefsky, Tony Luck,
linux390, linux-ia64, linux-s390, Ingo Molnar, linux-kernel
This fixes:
cc1: warnings being treated as errors
In file included from include/linux/ptrace.h:5,
from arch/mips/kernel/cpu-probe.c:16:
include/linux/sched.h:1002: warning: type qualifiers ignored on function return type
make[2]: *** [arch/mips/kernel/cpu-probe.o] Error 1
This is a regression introduced with commit
143e1e28cb40bed836b0a06567208bd7347c9672 [sched: Rework sched_domain
topology definition]. The warning itself is benign except in places like
the arch/mips subtree where we use `-Werror' to enforce good coding
practices. Apparently the warning is GCC-version specific, some versions
produce it and some do not.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
Vincent,
Did you mean:
typedef int __attribute__((const)) (*sched_domain_flags_f)(void);
by any chance?
Maciej
linux-sched-domain-flags-type.patch
Index: linux-20140623-swarm64/include/linux/sched.h
=================================--- linux-20140623-swarm64.orig/include/linux/sched.h
+++ linux-20140623-swarm64/include/linux/sched.h
@@ -999,7 +999,7 @@ void free_sched_domains(cpumask_var_t do
bool cpus_share_cache(int this_cpu, int that_cpu);
typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
-typedef const int (*sched_domain_flags_f)(void);
+typedef int (*sched_domain_flags_f)(void);
#define SDTL_OVERLAP 0x01
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-28 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-28 23:18 [PATCH] sched.h: Remove useless `const' from function return type Maciej W. Rozycki
2014-06-28 23:18 ` Maciej W. Rozycki
2014-06-28 23:18 ` Maciej W. Rozycki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.