* [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()
@ 2014-07-05 23:23 ` Emil Goode
0 siblings, 0 replies; 6+ messages in thread
From: Emil Goode @ 2014-07-05 23:23 UTC (permalink / raw)
To: Ralf Baechle, Paul Gortmaker, John Crispin, Jonas Gorski
Cc: linux-mips, linux-kernel, kernel-janitors, Emil Goode
We check that the struct vm_area_struct pointer vma is NULL and then
dereference it a few lines below. The intent was to make sure vma is
not NULL but this is not necessary since the bug pre-dates GIT history
and seem to never have caused a problem. The tlb-4k and tlb-8k versions
of local_flush_tlb_page() don't bother checking if vma is NULL, also
vma is dereferenced before being passed to local_flush_tlb_page(),
thus it is safe to remove this NULL check.
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
arch/mips/mm/tlb-r3k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c
index d657493..4094bbd 100644
--- a/arch/mips/mm/tlb-r3k.c
+++ b/arch/mips/mm/tlb-r3k.c
@@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long page)
{
int cpu = smp_processor_id();
- if (!vma || cpu_context(cpu, vma->vm_mm) != 0) {
+ if (cpu_context(cpu, vma->vm_mm) != 0) {
unsigned long flags;
int oldpid, newpid, idx;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()
@ 2014-07-05 23:23 ` Emil Goode
0 siblings, 0 replies; 6+ messages in thread
From: Emil Goode @ 2014-07-05 23:23 UTC (permalink / raw)
To: Ralf Baechle, Paul Gortmaker, John Crispin, Jonas Gorski
Cc: linux-mips, linux-kernel, kernel-janitors, Emil Goode
We check that the struct vm_area_struct pointer vma is NULL and then
dereference it a few lines below. The intent was to make sure vma is
not NULL but this is not necessary since the bug pre-dates GIT history
and seem to never have caused a problem. The tlb-4k and tlb-8k versions
of local_flush_tlb_page() don't bother checking if vma is NULL, also
vma is dereferenced before being passed to local_flush_tlb_page(),
thus it is safe to remove this NULL check.
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
arch/mips/mm/tlb-r3k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c
index d657493..4094bbd 100644
--- a/arch/mips/mm/tlb-r3k.c
+++ b/arch/mips/mm/tlb-r3k.c
@@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long page)
{
int cpu = smp_processor_id();
- if (!vma || cpu_context(cpu, vma->vm_mm) != 0) {
+ if (cpu_context(cpu, vma->vm_mm) != 0) {
unsigned long flags;
int oldpid, newpid, idx;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()
2014-07-05 23:23 ` Emil Goode
@ 2014-07-06 10:22 ` Jonas Gorski
-1 siblings, 0 replies; 6+ messages in thread
From: Jonas Gorski @ 2014-07-06 10:22 UTC (permalink / raw)
To: Emil Goode
Cc: Ralf Baechle, Paul Gortmaker, John Crispin, MIPS Mailing List,
linux-kernel, kernel-janitors
On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode <emilgoode@gmail.com> wrote:
> We check that the struct vm_area_struct pointer vma is NULL and then
> dereference it a few lines below. The intent was to make sure vma is
> not NULL but this is not necessary since the bug pre-dates GIT history
> and seem to never have caused a problem. The tlb-4k and tlb-8k versions
> of local_flush_tlb_page() don't bother checking if vma is NULL, also
> vma is dereferenced before being passed to local_flush_tlb_page(),
> thus it is safe to remove this NULL check.
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
Looks good.
Reviewed-by: Jonas Gorski <jogo@openwrt.org>
> ---
> arch/mips/mm/tlb-r3k.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c
> index d657493..4094bbd 100644
> --- a/arch/mips/mm/tlb-r3k.c
> +++ b/arch/mips/mm/tlb-r3k.c
> @@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long page)
> {
> int cpu = smp_processor_id();
>
> - if (!vma || cpu_context(cpu, vma->vm_mm) != 0) {
> + if (cpu_context(cpu, vma->vm_mm) != 0) {
> unsigned long flags;
> int oldpid, newpid, idx;
>
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()
@ 2014-07-06 10:22 ` Jonas Gorski
0 siblings, 0 replies; 6+ messages in thread
From: Jonas Gorski @ 2014-07-06 10:22 UTC (permalink / raw)
To: Emil Goode
Cc: Ralf Baechle, Paul Gortmaker, John Crispin, MIPS Mailing List,
linux-kernel, kernel-janitors
On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode <emilgoode@gmail.com> wrote:
> We check that the struct vm_area_struct pointer vma is NULL and then
> dereference it a few lines below. The intent was to make sure vma is
> not NULL but this is not necessary since the bug pre-dates GIT history
> and seem to never have caused a problem. The tlb-4k and tlb-8k versions
> of local_flush_tlb_page() don't bother checking if vma is NULL, also
> vma is dereferenced before being passed to local_flush_tlb_page(),
> thus it is safe to remove this NULL check.
>
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
Looks good.
Reviewed-by: Jonas Gorski <jogo@openwrt.org>
> ---
> arch/mips/mm/tlb-r3k.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c
> index d657493..4094bbd 100644
> --- a/arch/mips/mm/tlb-r3k.c
> +++ b/arch/mips/mm/tlb-r3k.c
> @@ -158,7 +158,7 @@ void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long page)
> {
> int cpu = smp_processor_id();
>
> - if (!vma || cpu_context(cpu, vma->vm_mm) != 0) {
> + if (cpu_context(cpu, vma->vm_mm) != 0) {
> unsigned long flags;
> int oldpid, newpid, idx;
>
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()
2014-07-06 10:22 ` Jonas Gorski
@ 2014-07-06 11:19 ` Maciej W. Rozycki
-1 siblings, 0 replies; 6+ messages in thread
From: Maciej W. Rozycki @ 2014-07-06 11:19 UTC (permalink / raw)
To: Jonas Gorski
Cc: Emil Goode, Ralf Baechle, Paul Gortmaker, John Crispin,
MIPS Mailing List, linux-kernel, kernel-janitors
On Sun, 6 Jul 2014, Jonas Gorski wrote:
> On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode <emilgoode@gmail.com> wrote:
> > We check that the struct vm_area_struct pointer vma is NULL and then
> > dereference it a few lines below. The intent was to make sure vma is
> > not NULL but this is not necessary since the bug pre-dates GIT history
> > and seem to never have caused a problem. The tlb-4k and tlb-8k versions
> > of local_flush_tlb_page() don't bother checking if vma is NULL, also
> > vma is dereferenced before being passed to local_flush_tlb_page(),
> > thus it is safe to remove this NULL check.
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Looks good.
>
> Reviewed-by: Jonas Gorski <jogo@openwrt.org>
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
(as per the observations at the previous version).
Maciej
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()
@ 2014-07-06 11:19 ` Maciej W. Rozycki
0 siblings, 0 replies; 6+ messages in thread
From: Maciej W. Rozycki @ 2014-07-06 11:19 UTC (permalink / raw)
To: Jonas Gorski
Cc: Emil Goode, Ralf Baechle, Paul Gortmaker, John Crispin,
MIPS Mailing List, linux-kernel, kernel-janitors
On Sun, 6 Jul 2014, Jonas Gorski wrote:
> On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode <emilgoode@gmail.com> wrote:
> > We check that the struct vm_area_struct pointer vma is NULL and then
> > dereference it a few lines below. The intent was to make sure vma is
> > not NULL but this is not necessary since the bug pre-dates GIT history
> > and seem to never have caused a problem. The tlb-4k and tlb-8k versions
> > of local_flush_tlb_page() don't bother checking if vma is NULL, also
> > vma is dereferenced before being passed to local_flush_tlb_page(),
> > thus it is safe to remove this NULL check.
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Looks good.
>
> Reviewed-by: Jonas Gorski <jogo@openwrt.org>
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
(as per the observations at the previous version).
Maciej
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-06 11:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-05 23:23 [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page() Emil Goode
2014-07-05 23:23 ` Emil Goode
2014-07-06 10:22 ` Jonas Gorski
2014-07-06 10:22 ` Jonas Gorski
2014-07-06 11:19 ` Maciej W. Rozycki
2014-07-06 11:19 ` Maciej W. Rozycki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.