[PATCH rt-tests 1/3] all programs apart from sendme use pthreads so skip them on NPTL!=yes

[PATCH rt-tests 1/3] all programs apart from sendme use pthreads so skip them on NPTL!=yes

[Uwe Kleine-König]

---
 Makefile | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 6c96c9f31a19..af669263a5fb 100644
--- a/Makefile
+++ b/Makefile
@@ -7,11 +7,19 @@ OBJDIR = bld
 HAVE_NPTL ?= yes
 
 ifeq ($(HAVE_NPTL),yes)
-sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
+sources = cyclictest.c \
+	  hackbench.c \
+	  pip_stress.c \
+	  pi_stress.c \
+	  pmqtest.c \
+	  ptsematest.c \
+	  rt-migrate-test.c \
+	  signaltest.c \
+	  sigwaittest.c \
+	  svsematest.c
 endif
 
-sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \
-	  hackbench.c
+sources += sendme.c
 
 TARGETS = $(sources:.c=)
 
-- 
2.1.4

[PATCH rt-tests 2/3] rt-migrate-test: remove space before \n

[Uwe Kleine-König]

This fixes a checkpatch warning

	WARNING: unnecessary whitespace before a quoted newline
---
 src/rt-migrate-test/rt-migrate-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rt-migrate-test/rt-migrate-test.c b/src/rt-migrate-test/rt-migrate-test.c
index 85a78dab7403..d7b68ddac3e5 100644
--- a/src/rt-migrate-test/rt-migrate-test.c
+++ b/src/rt-migrate-test/rt-migrate-test.c
@@ -178,7 +178,7 @@ static void usage(char **argv)
 	printf("%s %1.2f\n", p, VERSION);
 	printf("Usage:\n"
 	       "%s <options> nr_tasks\n\n"
-	       "-p prio --prio  prio        base priority to start RT tasks with (2) \n"
+	       "-p prio --prio  prio        base priority to start RT tasks with (2)\n"
 	       "-r time --run-time time     Run time (ms) to busy loop the threads (20)\n"
 	       "-s time --sleep-time time   Sleep time (ms) between intervals (100)\n"
 	       "-m time --maxerr time       Max allowed error (microsecs)\n"
-- 
2.1.4

Re: [PATCH rt-tests 2/3] rt-migrate-test: remove space before \n

[John Kacur]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]



On Mon, 5 Oct 2015, Uwe Kleine-König wrote:

> This fixes a checkpatch warning
> 
> 	WARNING: unnecessary whitespace before a quoted newline
> ---
>  src/rt-migrate-test/rt-migrate-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/rt-migrate-test/rt-migrate-test.c b/src/rt-migrate-test/rt-migrate-test.c
> index 85a78dab7403..d7b68ddac3e5 100644
> --- a/src/rt-migrate-test/rt-migrate-test.c
> +++ b/src/rt-migrate-test/rt-migrate-test.c
> @@ -178,7 +178,7 @@ static void usage(char **argv)
>  	printf("%s %1.2f\n", p, VERSION);
>  	printf("Usage:\n"
>  	       "%s <options> nr_tasks\n\n"
> -	       "-p prio --prio  prio        base priority to start RT tasks with (2) \n"
> +	       "-p prio --prio  prio        base priority to start RT tasks with (2)\n"
>  	       "-r time --run-time time     Run time (ms) to busy loop the threads (20)\n"
>  	       "-s time --sleep-time time   Sleep time (ms) between intervals (100)\n"
>  	       "-m time --maxerr time       Max allowed error (microsecs)\n"
> -- 
> 2.1.4
> 

Fine, Signed-off-by: John Kacur <jkacur@redhat.com>

[PATCH rt-tests 3/3] remove license info containing an old FSF address

[Uwe Kleine-König]

The source tree contains the complete GPL so that paragraph isn't that
useful.

I didn't touch src/pi_tests/tst-mutexpi10.c (which is borrowed verbatim
from libc AFAIK) and the references containing the correct address of
the FSF.
---
 src/backfire/backfire.c               | 5 -----
 src/backfire/sendme.c                 | 5 -----
 src/pmqtest/pmqtest.c                 | 5 -----
 src/ptsematest/ptsematest.c           | 5 -----
 src/rt-migrate-test/rt-migrate-test.c | 4 ----
 src/sigwaittest/sigwaittest.c         | 5 -----
 src/svsematest/svsematest.c           | 5 -----
 7 files changed, 34 deletions(-)

diff --git a/src/backfire/backfire.c b/src/backfire/backfire.c
index aaf9c4af8e00..eb13998b8fed 100644
--- a/src/backfire/backfire.c
+++ b/src/backfire/backfire.c
@@ -12,11 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
- * USA.
  */
 
 #include <linux/module.h>
diff --git a/src/backfire/sendme.c b/src/backfire/sendme.c
index c1854d9660cb..8befffcbc722 100644
--- a/src/backfire/sendme.c
+++ b/src/backfire/sendme.c
@@ -12,11 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
- * USA.
  */
 #include <stdio.h>
 #include <stdlib.h>
diff --git a/src/pmqtest/pmqtest.c b/src/pmqtest/pmqtest.c
index 75d5ee8185a0..bd66a6fb5106 100644
--- a/src/pmqtest/pmqtest.c
+++ b/src/pmqtest/pmqtest.c
@@ -12,11 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
- * USA.
  */
 
 #include <stdio.h>
diff --git a/src/ptsematest/ptsematest.c b/src/ptsematest/ptsematest.c
index a31c745ec928..15d037d11fff 100644
--- a/src/ptsematest/ptsematest.c
+++ b/src/ptsematest/ptsematest.c
@@ -12,11 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
- * USA.
  */
 
 #include <stdio.h>
diff --git a/src/rt-migrate-test/rt-migrate-test.c b/src/rt-migrate-test/rt-migrate-test.c
index d7b68ddac3e5..72e02610cf22 100644
--- a/src/rt-migrate-test/rt-migrate-test.c
+++ b/src/rt-migrate-test/rt-migrate-test.c
@@ -14,10 +14,6 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- *
  * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  */
 #ifndef _GNU_SOURCE
diff --git a/src/sigwaittest/sigwaittest.c b/src/sigwaittest/sigwaittest.c
index 91fcdaa5f185..aafce38d3d48 100644
--- a/src/sigwaittest/sigwaittest.c
+++ b/src/sigwaittest/sigwaittest.c
@@ -12,11 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
- * USA.
  */
 
 #include <stdio.h>
diff --git a/src/svsematest/svsematest.c b/src/svsematest/svsematest.c
index eeb82858720a..13e5042813c4 100644
--- a/src/svsematest/svsematest.c
+++ b/src/svsematest/svsematest.c
@@ -12,11 +12,6 @@
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
- * USA.
  */
 
 #include <stdio.h>
-- 
2.1.4

Re: [PATCH rt-tests 3/3] remove license info containing an old FSF address

[John Kacur]

[-- Attachment #1: Type: text/plain, Size: 5655 bytes --]



On Mon, 5 Oct 2015, Uwe Kleine-König wrote:

> The source tree contains the complete GPL so that paragraph isn't that
> useful.
> 
> I didn't touch src/pi_tests/tst-mutexpi10.c (which is borrowed verbatim
> from libc AFAIK) and the references containing the correct address of
> the FSF.
> ---
>  src/backfire/backfire.c               | 5 -----
>  src/backfire/sendme.c                 | 5 -----
>  src/pmqtest/pmqtest.c                 | 5 -----
>  src/ptsematest/ptsematest.c           | 5 -----
>  src/rt-migrate-test/rt-migrate-test.c | 4 ----
>  src/sigwaittest/sigwaittest.c         | 5 -----
>  src/svsematest/svsematest.c           | 5 -----
>  7 files changed, 34 deletions(-)
> 
> diff --git a/src/backfire/backfire.c b/src/backfire/backfire.c
> index aaf9c4af8e00..eb13998b8fed 100644
> --- a/src/backfire/backfire.c
> +++ b/src/backfire/backfire.c
> @@ -12,11 +12,6 @@
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
> - * USA.
>   */
>  
>  #include <linux/module.h>
> diff --git a/src/backfire/sendme.c b/src/backfire/sendme.c
> index c1854d9660cb..8befffcbc722 100644
> --- a/src/backfire/sendme.c
> +++ b/src/backfire/sendme.c
> @@ -12,11 +12,6 @@
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
> - * USA.
>   */
>  #include <stdio.h>
>  #include <stdlib.h>
> diff --git a/src/pmqtest/pmqtest.c b/src/pmqtest/pmqtest.c
> index 75d5ee8185a0..bd66a6fb5106 100644
> --- a/src/pmqtest/pmqtest.c
> +++ b/src/pmqtest/pmqtest.c
> @@ -12,11 +12,6 @@
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
> - * USA.
>   */
>  
>  #include <stdio.h>
> diff --git a/src/ptsematest/ptsematest.c b/src/ptsematest/ptsematest.c
> index a31c745ec928..15d037d11fff 100644
> --- a/src/ptsematest/ptsematest.c
> +++ b/src/ptsematest/ptsematest.c
> @@ -12,11 +12,6 @@
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
> - * USA.
>   */
>  
>  #include <stdio.h>
> diff --git a/src/rt-migrate-test/rt-migrate-test.c b/src/rt-migrate-test/rt-migrate-test.c
> index d7b68ddac3e5..72e02610cf22 100644
> --- a/src/rt-migrate-test/rt-migrate-test.c
> +++ b/src/rt-migrate-test/rt-migrate-test.c
> @@ -14,10 +14,6 @@
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
>   *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> - *
>   * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   */
>  #ifndef _GNU_SOURCE
> diff --git a/src/sigwaittest/sigwaittest.c b/src/sigwaittest/sigwaittest.c
> index 91fcdaa5f185..aafce38d3d48 100644
> --- a/src/sigwaittest/sigwaittest.c
> +++ b/src/sigwaittest/sigwaittest.c
> @@ -12,11 +12,6 @@
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
> - * USA.
>   */
>  
>  #include <stdio.h>
> diff --git a/src/svsematest/svsematest.c b/src/svsematest/svsematest.c
> index eeb82858720a..13e5042813c4 100644
> --- a/src/svsematest/svsematest.c
> +++ b/src/svsematest/svsematest.c
> @@ -12,11 +12,6 @@
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307,
> - * USA.
>   */
>  
>  #include <stdio.h>
> -- 
> 2.1.4
> 

You can correct the address if you want to, but IANL, but if the Free 
Software Foundation says you should put that at the top of the file, I 
don't think you can just decide for yourself that you don't need to, just 
because you know you are doing the right thing by including a copy of the 
licence.

Thanks
John

Re: [PATCH rt-tests 3/3] remove license info containing an old FSF address

[Uwe Kleine-König]

Hello,

On Mon, Oct 05, 2015 at 09:52:40PM +0200, John Kacur wrote:
> On Mon, 5 Oct 2015, Uwe Kleine-König wrote:
> 
> > The source tree contains the complete GPL so that paragraph isn't that
> > useful.
> 
> You can correct the address if you want to, but IANL, but if the Free 
> Software Foundation says you should put that at the top of the file, I 
> don't think you can just decide for yourself that you don't need to, just 
> because you know you are doing the right thing by including a copy of the 
> licence.

I'm not a lawyer either just applied common sense (or what I think is
common sense). For GPL-3 the address isn't included any more, there it's
just:

	You should have received a copy of the GNU General Public
	License along with this program.  If not, see
	<http://www.gnu.org/licenses/>.

And I understand that snippet as an example. After all it also
recommends to say "either version 2 of the License, or (at your option)
any later version." which isn't used everywhere either.

And given that correcting the address now make us correct the address
once more when the FSF moves the next time I still think dropping wrong
addresses is the right thing to do.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rt-tests 1/3] all programs apart from sendme use pthreads so skip them on NPTL!=yes

[John Kacur]

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]



On Mon, 5 Oct 2015, Uwe Kleine-König wrote:

> ---
>  Makefile | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 6c96c9f31a19..af669263a5fb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,11 +7,19 @@ OBJDIR = bld
>  HAVE_NPTL ?= yes
>  
>  ifeq ($(HAVE_NPTL),yes)
> -sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
> +sources = cyclictest.c \
> +	  hackbench.c \
> +	  pip_stress.c \
> +	  pi_stress.c \
> +	  pmqtest.c \
> +	  ptsematest.c \
> +	  rt-migrate-test.c \
> +	  signaltest.c \
> +	  sigwaittest.c \
> +	  svsematest.c
>  endif
>  
> -sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \
> -	  hackbench.c
> +sources += sendme.c
>  
>  TARGETS = $(sources:.c=)
>  
> -- 
> 2.1.4

Ok, I thought that might be useful for bionic, but now I can see, that 
it's pretty much useless. Why don't you just remove HAVE_NPTL altogether?

Thanks
John

[PATCH rt-tests] drop compiling without NPTL support

[Uwe Kleine-König]

all programs apart from sendme use pthreads so NPTL=no is hardly useful
any more.
---
 Makefile | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/Makefile b/Makefile
index 1e255a983574..6ce2ecc7fc30 100644
--- a/Makefile
+++ b/Makefile
@@ -4,14 +4,17 @@ AR=$(CROSS_COMPILE)ar
 
 OBJDIR = bld
 
-HAVE_NPTL ?= yes
-
-ifeq ($(HAVE_NPTL),yes)
-sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
-endif

Re: [PATCH rt-tests] drop compiling without NPTL support

[John Kacur]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]



On Tue, 6 Oct 2015, Uwe Kleine-König wrote:

> all programs apart from sendme use pthreads so NPTL=no is hardly useful
> any more.
> ---
>  Makefile | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 1e255a983574..6ce2ecc7fc30 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -4,14 +4,17 @@ AR=$(CROSS_COMPILE)ar
>  
>  OBJDIR = bld
>  
> -HAVE_NPTL ?= yes
> -
> -ifeq ($(HAVE_NPTL),yes)
> -sources = cyclictest.c pi_stress.c pip_stress.c pmqtest.c rt-migrate-test.c
> -endif
> -
> -sources += signaltest.c ptsematest.c sigwaittest.c svsematest.c sendme.c \
> -	  hackbench.c
> +sources = cyclictest.c \
> +	  hackbench.c \
> +	  pip_stress.c \
> +	  pi_stress.c \
> +	  pmqtest.c \
> +	  ptsematest.c \
> +	  rt-migrate-test.c \
> +	  sendme.c \
> +	  signaltest.c \
> +	  sigwaittest.c \
> +	  svsematest.c
>  
>  TARGETS = $(sources:.c=)
>  
> -- 
> 2.1.4

Yes, it's outdated
Signed-off-by: John Kacur <jkacur@redhat.com>