All of lore.kernel.org
 help / color / mirror / Atom feed
From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: proc-v7.S: Adjust stack address when XIP_KERNEL
Date: Mon, 1 Feb 2016 16:15:38 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.20.1602011613360.32766@knanqh.ubzr> (raw)
In-Reply-To: <1454335736-10084-1-git-send-email-chris.brandt@renesas.com>

On Mon, 1 Feb 2016, Chris Brandt wrote:

> From: Nicolas Pitre <nico@linaro.org>
> 
> When XIP_KERNEL is enabled, the virt to phys address translation for RAM
> is not the same as the virt to phys address translation for .text.
> The only way to know where physical RAM is located is to use
> PLAT_PHYS_OFFSET.
> The MACRO will be useful for other places where there is a similar problem.
> 
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

Looks fine.  You may submit it here:

http://www.arm.linux.org.uk/developer/patches/


> ---
> v2:
> * Fixed Signed-off to show correct author
> ---
>  arch/arm/include/asm/memory.h | 8 ++++++++
>  arch/arm/mm/proc-v7.S         | 2 +-
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
> index c79b57b..7dd2ab5 100644
> --- a/arch/arm/include/asm/memory.h
> +++ b/arch/arm/include/asm/memory.h
> @@ -134,6 +134,14 @@
>   */
>  #define PLAT_PHYS_OFFSET	UL(CONFIG_PHYS_OFFSET)
>  
> +#ifdef CONFIG_XIP_KERNEL
> +#define PHYS_OFFSET_FIXUP \
> +	( XIP_VIRT_ADDR(CONFIG_XIP_PHYS_ADDR) - PAGE_OFFSET + \
> +	  PLAT_PHYS_OFFSET - CONFIG_XIP_PHYS_ADDR )
> +#else
> +#define PHYS_OFFSET_FIXUP 0
> +#endif
> +
>  #ifndef __ASSEMBLY__
>  
>  /*
> diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> index 0f92d57..1595fb2 100644
> --- a/arch/arm/mm/proc-v7.S
> +++ b/arch/arm/mm/proc-v7.S
> @@ -487,7 +487,7 @@ __errata_finish:
>  
>  	.align	2
>  __v7_setup_stack_ptr:
> -	.word	__v7_setup_stack - .
> +	.word	__v7_setup_stack - . + PHYS_OFFSET_FIXUP
>  ENDPROC(__v7_setup)
>  
>  	.bss
> -- 
> 1.9.1
> 
> 
> 

  reply	other threads:[~2016-02-01 21:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 22:11 [PATCH] ARM: proc-v7.S: Adjust stack address when XIP_KERNEL Chris Brandt
2016-01-31 23:20 ` Arnd Bergmann
2016-02-01 14:08   ` Chris Brandt
2016-02-01 14:08 ` [PATCH v2] " Chris Brandt
2016-02-01 21:15   ` Nicolas Pitre [this message]
2016-02-16 17:32     ` Russell King - ARM Linux
2016-02-16 18:53       ` Chris Brandt
2016-02-16 20:16       ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1602011613360.32766@knanqh.ubzr \
    --to=nicolas.pitre@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.